| Message ID | 20181001220942.2382-14-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | another SysBusDevice::init to Device::realize cleanup | expand |
On 2018-10-02 00:09, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/alpha/typhoon.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c > index d74b5b55e1..8004afe45b 100644 > --- a/hw/alpha/typhoon.c > +++ b/hw/alpha/typhoon.c > @@ -932,23 +932,10 @@ PCIBus *typhoon_init(ram_addr_t ram_size, ISABus **isa_bus, > return b; > } > > -static int typhoon_pcihost_init(SysBusDevice *dev) > -{ > - return 0; > -} > - > -static void typhoon_pcihost_class_init(ObjectClass *klass, void *data) > -{ > - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass); > - > - k->init = typhoon_pcihost_init; > -} > - > static const TypeInfo typhoon_pcihost_info = { > .name = TYPE_TYPHOON_PCI_HOST_BRIDGE, > .parent = TYPE_PCI_HOST_BRIDGE, > .instance_size = sizeof(TyphoonState), > - .class_init = typhoon_pcihost_class_init, > }; > > static void typhoon_iommu_memory_region_class_init(ObjectClass *klass, As far as I can see, this should be fine. Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index d74b5b55e1..8004afe45b 100644 --- a/hw/alpha/typhoon.c +++ b/hw/alpha/typhoon.c @@ -932,23 +932,10 @@ PCIBus *typhoon_init(ram_addr_t ram_size, ISABus **isa_bus, return b; } -static int typhoon_pcihost_init(SysBusDevice *dev) -{ - return 0; -} - -static void typhoon_pcihost_class_init(ObjectClass *klass, void *data) -{ - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass); - - k->init = typhoon_pcihost_init; -} - static const TypeInfo typhoon_pcihost_info = { .name = TYPE_TYPHOON_PCI_HOST_BRIDGE, .parent = TYPE_PCI_HOST_BRIDGE, .instance_size = sizeof(TyphoonState), - .class_init = typhoon_pcihost_class_init, }; static void typhoon_iommu_memory_region_class_init(ObjectClass *klass,
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/alpha/typhoon.c | 13 ------------- 1 file changed, 13 deletions(-)