| Message ID | 20181001182249.129565-28-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 3ae192c2a4d52a755031e93fa6cc3a31ba90f29f |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Various fixes and improvements | expand |
Unfortunately the test was not included in the original implementation.
Add one.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
tools/binman/ftest.py | 7 +++++++
tools/binman/test/100_intel_refcode.dts | 14 ++++++++++++++
2 files changed, 21 insertions(+)
create mode 100644 tools/binman/test/100_intel_refcode.dts
Applied to u-boot-dm
On Mon, Oct 01, 2018 at 12:22:31PM -0600, Simon Glass wrote: > Unfortunately the test was not included in the original implementation. > Add one. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Signed-off-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py index 167f56dd060..e77fce5a26f 100644 --- a/tools/binman/ftest.py +++ b/tools/binman/ftest.py @@ -60,6 +60,7 @@ VBLOCK_DATA = 'vblk' FILES_DATA = ("sorry I'm late\nOh, don't bother apologising, I'm " + "sorry you're alive\n") COMPRESS_DATA = 'data to compress' +REFCODE_DATA = 'refcode' class TestFunctional(unittest.TestCase): @@ -115,6 +116,7 @@ class TestFunctional(unittest.TestCase): TestFunctional._MakeInputFile('ecrw.bin', CROS_EC_RW_DATA) TestFunctional._MakeInputDir('devkeys') TestFunctional._MakeInputFile('bmpblk.bin', BMPBLK_DATA) + TestFunctional._MakeInputFile('refcode.bin', REFCODE_DATA) # ELF file with a '_dt_ucode_base_size' symbol with open(self.TestFile('u_boot_ucode_ptr')) as fd: @@ -1764,6 +1766,11 @@ class TestFunctional(unittest.TestCase): <none> 00000003 00000004 u-boot-align ''', map_data) + def testPacRefCode(self): + """Test that an image with an Intel Reference code binary works""" + data = self._DoReadFile('100_intel_refcode.dts') + self.assertEqual(REFCODE_DATA, data[:len(REFCODE_DATA)]) + if __name__ == "__main__": unittest.main() diff --git a/tools/binman/test/100_intel_refcode.dts b/tools/binman/test/100_intel_refcode.dts new file mode 100644 index 00000000000..0a1a0270e5f --- /dev/null +++ b/tools/binman/test/100_intel_refcode.dts @@ -0,0 +1,14 @@ +/dts-v1/; + +/ { + #address-cells = <1>; + #size-cells = <1>; + + binman { + size = <16>; + + intel-refcode { + filename = "refcode.bin"; + }; + }; +};
Unfortunately the test was not included in the original implementation. Add one. Signed-off-by: Simon Glass <sjg@chromium.org> --- tools/binman/ftest.py | 7 +++++++ tools/binman/test/100_intel_refcode.dts | 14 ++++++++++++++ 2 files changed, 21 insertions(+) create mode 100644 tools/binman/test/100_intel_refcode.dts