diff mbox series

scripts/device-crash-test: Remove entries for serial devices

Message ID 1538403190-27146-1-git-send-email-thuth@redhat.com
State New
Headers show
Series scripts/device-crash-test: Remove entries for serial devices | expand

Commit Message

Thomas Huth Oct. 1, 2018, 2:13 p.m. UTC 
The problem with the various serial devices has been fixed a while
ago in commit 47c4f85a0c27888e12af827471cfef87deb49821 ("hw/char/serial:
Allow disconnected chardevs") already, so we can remove these entries
from the "ignore" list in the device-crash-test script now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 scripts/device-crash-test | 5 -----
 1 file changed, 5 deletions(-)

Comments

Eduardo Habkost Oct. 1, 2018, 3:50 p.m. UTC | #1 
On Mon, Oct 01, 2018 at 04:13:10PM +0200, Thomas Huth wrote:
> The problem with the various serial devices has been fixed a while
> ago in commit 47c4f85a0c27888e12af827471cfef87deb49821 ("hw/char/serial:
> Allow disconnected chardevs") already, so we can remove these entries
> from the "ignore" list in the device-crash-test script now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, queued on python-next.
diff mbox series

Patch

diff --git a/scripts/device-crash-test b/scripts/device-crash-test
index e6c233e..3422475 100755
--- a/scripts/device-crash-test
+++ b/scripts/device-crash-test
@@ -99,7 +99,6 @@  ERROR_WHITELIST = [
     {'device':'isa-ipmi-bt', 'expected':True},             # IPMI device requires a bmc attribute to be set
     {'device':'isa-ipmi-kcs', 'expected':True},            # IPMI device requires a bmc attribute to be set
     {'device':'isa-parallel', 'expected':True},            # Can't create serial device, empty char device
-    {'device':'isa-serial', 'expected':True},              # Can't create serial device, empty char device
     {'device':'ivshmem', 'expected':True},                 # You must specify either 'shm' or 'chardev'
     {'device':'ivshmem-doorbell', 'expected':True},        # You must specify a 'chardev'
     {'device':'ivshmem-plain', 'expected':True},           # You must specify a 'memdev'
@@ -110,9 +109,6 @@  ERROR_WHITELIST = [
     {'device':'pc-dimm', 'expected':True},                 # 'memdev' property is not set
     {'device':'pci-bridge', 'expected':True},              # Bridge chassis not specified. Each bridge is required to be assigned a unique chassis id > 0.
     {'device':'pci-bridge-seat', 'expected':True},         # Bridge chassis not specified. Each bridge is required to be assigned a unique chassis id > 0.
-    {'device':'pci-serial', 'expected':True},              # Can't create serial device, empty char device
-    {'device':'pci-serial-2x', 'expected':True},           # Can't create serial device, empty char device
-    {'device':'pci-serial-4x', 'expected':True},           # Can't create serial device, empty char device
     {'device':'pxa2xx-dma', 'expected':True},              # channels value invalid
     {'device':'pxb', 'expected':True},                     # Bridge chassis not specified. Each bridge is required to be assigned a unique chassis id > 0.
     {'device':'scsi-block', 'expected':True},              # drive property not set
@@ -218,7 +214,6 @@  ERROR_WHITELIST = [
     {'exitcode':-6, 'log':r"Object .* is not an instance of type generic-pc-machine", 'loglevel':logging.ERROR},
     {'exitcode':-6, 'log':r"Object .* is not an instance of type e500-ccsr", 'loglevel':logging.ERROR},
     {'exitcode':-6, 'log':r"vmstate_register_with_alias_id: Assertion `!se->compat \|\| se->instance_id == 0' failed", 'loglevel':logging.ERROR},
-    {'exitcode':-11, 'device':'isa-serial', 'loglevel':logging.ERROR, 'expected':True},
 
     # everything else (including SIGABRT and SIGSEGV) will be a fatal error:
     {'exitcode':None, 'fatal':True, 'loglevel':logging.FATAL},