| Message ID | 20181001125952.2676.35168.stgit@ltcalpine2-lp9.aus.stglabs.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/migration: Affinity fix for memory | expand |
On 10/01/2018 05:59 AM, Michael Bringmann wrote: > migration/memory: This patch adds a new pseries hotplug action > for CPU and memory operations, PSERIES_HP_ELOG_ACTION_READD_MULTIPLE. > This is a variant of the READD operation which performs the action > upon multiple instances of the resource at one time. The operation > is to be triggered by device-tree analysis of updates by RTAS events > analyzed by 'migation_store' during post-migration processing. It > will be used for memory updates, initially. > > Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com> > --- > arch/powerpc/include/asm/rtas.h | 1 + > arch/powerpc/mm/drmem.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h > index 71e393c..e510d82 100644 > --- a/arch/powerpc/include/asm/rtas.h > +++ b/arch/powerpc/include/asm/rtas.h > @@ -320,6 +320,7 @@ struct pseries_hp_errorlog { > #define PSERIES_HP_ELOG_ACTION_ADD 1 > #define PSERIES_HP_ELOG_ACTION_REMOVE 2 > #define PSERIES_HP_ELOG_ACTION_READD 3 > +#define PSERIES_HP_ELOG_ACTION_READD_MULTIPLE 4 I'm confused, you have only added a define and not the actual implementation. I really think this should be squashed into your 4th patch where the operation is actually implemented. > > #define PSERIES_HP_ELOG_ID_DRC_NAME 1 > #define PSERIES_HP_ELOG_ID_DRC_INDEX 2 > diff --git a/arch/powerpc/mm/drmem.c b/arch/powerpc/mm/drmem.c > index fd2cae92..2228586 100644 > --- a/arch/powerpc/mm/drmem.c > +++ b/arch/powerpc/mm/drmem.c > @@ -422,6 +422,7 @@ static void init_drmem_v2_lmbs(const __be32 *prop, > > lmb->aa_index = dr_cell.aa_index; > lmb->flags = dr_cell.flags; > + lmb->internal_flags = 0; And this should have been squashed into the previous patch where you added the internal_flags field to the lmb struct. -Tyrel > } > } > } >
On 10/02/2018 04:03 PM, Tyrel Datwyler wrote: > On 10/01/2018 05:59 AM, Michael Bringmann wrote: >> migration/memory: This patch adds a new pseries hotplug action >> for CPU and memory operations, PSERIES_HP_ELOG_ACTION_READD_MULTIPLE. >> This is a variant of the READD operation which performs the action >> upon multiple instances of the resource at one time. The operation >> is to be triggered by device-tree analysis of updates by RTAS events >> analyzed by 'migation_store' during post-migration processing. It >> will be used for memory updates, initially. >> >> Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com> >> --- >> arch/powerpc/include/asm/rtas.h | 1 + >> arch/powerpc/mm/drmem.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h >> index 71e393c..e510d82 100644 >> --- a/arch/powerpc/include/asm/rtas.h >> +++ b/arch/powerpc/include/asm/rtas.h >> @@ -320,6 +320,7 @@ struct pseries_hp_errorlog { >> #define PSERIES_HP_ELOG_ACTION_ADD 1 >> #define PSERIES_HP_ELOG_ACTION_REMOVE 2 >> #define PSERIES_HP_ELOG_ACTION_READD 3 >> +#define PSERIES_HP_ELOG_ACTION_READD_MULTIPLE 4 > > I'm confused, you have only added a define and not the actual implementation. I really think this should be squashed into your 4th patch where the operation is actually implemented. Okay. > >> >> #define PSERIES_HP_ELOG_ID_DRC_NAME 1 >> #define PSERIES_HP_ELOG_ID_DRC_INDEX 2 >> diff --git a/arch/powerpc/mm/drmem.c b/arch/powerpc/mm/drmem.c >> index fd2cae92..2228586 100644 >> --- a/arch/powerpc/mm/drmem.c >> +++ b/arch/powerpc/mm/drmem.c >> @@ -422,6 +422,7 @@ static void init_drmem_v2_lmbs(const __be32 *prop, >> >> lmb->aa_index = dr_cell.aa_index; >> lmb->flags = dr_cell.flags; >> + lmb->internal_flags = 0; > > And this should have been squashed into the previous patch where you added the internal_flags field to the lmb struct. Okay. > > -Tyrel > >> } >> } >> } >> > >
diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h index 71e393c..e510d82 100644 --- a/arch/powerpc/include/asm/rtas.h +++ b/arch/powerpc/include/asm/rtas.h @@ -320,6 +320,7 @@ struct pseries_hp_errorlog { #define PSERIES_HP_ELOG_ACTION_ADD 1 #define PSERIES_HP_ELOG_ACTION_REMOVE 2 #define PSERIES_HP_ELOG_ACTION_READD 3 +#define PSERIES_HP_ELOG_ACTION_READD_MULTIPLE 4 #define PSERIES_HP_ELOG_ID_DRC_NAME 1 #define PSERIES_HP_ELOG_ID_DRC_INDEX 2 diff --git a/arch/powerpc/mm/drmem.c b/arch/powerpc/mm/drmem.c index fd2cae92..2228586 100644 --- a/arch/powerpc/mm/drmem.c +++ b/arch/powerpc/mm/drmem.c @@ -422,6 +422,7 @@ static void init_drmem_v2_lmbs(const __be32 *prop, lmb->aa_index = dr_cell.aa_index; lmb->flags = dr_cell.flags; + lmb->internal_flags = 0; } } }
migration/memory: This patch adds a new pseries hotplug action for CPU and memory operations, PSERIES_HP_ELOG_ACTION_READD_MULTIPLE. This is a variant of the READD operation which performs the action upon multiple instances of the resource at one time. The operation is to be triggered by device-tree analysis of updates by RTAS events analyzed by 'migation_store' during post-migration processing. It will be used for memory updates, initially. Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com> --- arch/powerpc/include/asm/rtas.h | 1 + arch/powerpc/mm/drmem.c | 1 + 2 files changed, 2 insertions(+)