| Message ID | 20181001102928.20533-2-vsementsov@virtuozzo.com |
|---|---|
| State | New |
| Headers | show |
| Series | fleecing-hook driver for backup | expand |
On 10/1/18 5:29 AM, Vladimir Sementsov-Ogievskiy wrote: > It is needed for use the bitmaps in backup. "disabled" means that > bitmap is not auto set by writes. Let's allow changing bitmap for other > uses. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > --- > block/dirty-bitmap.c | 2 -- > 1 file changed, 2 deletions(-) Looks like this duplicates John's series: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00406.html > > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index 89c11111ae..65d2e92ec3 100644 > --- a/block/dirty-bitmap.c > +++ b/block/dirty-bitmap.c > @@ -532,7 +532,6 @@ int64_t bdrv_dirty_iter_next(BdrvDirtyBitmapIter *iter) > void bdrv_set_dirty_bitmap_locked(BdrvDirtyBitmap *bitmap, > int64_t offset, int64_t bytes) > { > - assert(bdrv_dirty_bitmap_enabled(bitmap)); > assert(!bdrv_dirty_bitmap_readonly(bitmap)); > hbitmap_set(bitmap->bitmap, offset, bytes); > } > @@ -549,7 +548,6 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, > void bdrv_reset_dirty_bitmap_locked(BdrvDirtyBitmap *bitmap, > int64_t offset, int64_t bytes) > { > - assert(bdrv_dirty_bitmap_enabled(bitmap)); > assert(!bdrv_dirty_bitmap_readonly(bitmap)); > hbitmap_reset(bitmap->bitmap, offset, bytes); > } >
03.10.2018 17:23, Eric Blake wrote: > On 10/1/18 5:29 AM, Vladimir Sementsov-Ogievskiy wrote: >> It is needed for use the bitmaps in backup. "disabled" means that >> bitmap is not auto set by writes. Let's allow changing bitmap for other >> uses. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> >> --- >> block/dirty-bitmap.c | 2 -- >> 1 file changed, 2 deletions(-) > > Looks like this duplicates John's series: > https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00406.html No. But it relates. > >> >> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c >> index 89c11111ae..65d2e92ec3 100644 >> --- a/block/dirty-bitmap.c >> +++ b/block/dirty-bitmap.c >> @@ -532,7 +532,6 @@ int64_t bdrv_dirty_iter_next(BdrvDirtyBitmapIter >> *iter) >> void bdrv_set_dirty_bitmap_locked(BdrvDirtyBitmap *bitmap, >> int64_t offset, int64_t bytes) >> { >> - assert(bdrv_dirty_bitmap_enabled(bitmap)); >> assert(!bdrv_dirty_bitmap_readonly(bitmap)); >> hbitmap_set(bitmap->bitmap, offset, bytes); >> } >> @@ -549,7 +548,6 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, >> void bdrv_reset_dirty_bitmap_locked(BdrvDirtyBitmap *bitmap, >> int64_t offset, int64_t bytes) >> { >> - assert(bdrv_dirty_bitmap_enabled(bitmap)); >> assert(!bdrv_dirty_bitmap_readonly(bitmap)); >> hbitmap_reset(bitmap->bitmap, offset, bytes); >> } >> >
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 89c11111ae..65d2e92ec3 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitmap.c @@ -532,7 +532,6 @@ int64_t bdrv_dirty_iter_next(BdrvDirtyBitmapIter *iter) void bdrv_set_dirty_bitmap_locked(BdrvDirtyBitmap *bitmap, int64_t offset, int64_t bytes) { - assert(bdrv_dirty_bitmap_enabled(bitmap)); assert(!bdrv_dirty_bitmap_readonly(bitmap)); hbitmap_set(bitmap->bitmap, offset, bytes); } @@ -549,7 +548,6 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, void bdrv_reset_dirty_bitmap_locked(BdrvDirtyBitmap *bitmap, int64_t offset, int64_t bytes) { - assert(bdrv_dirty_bitmap_enabled(bitmap)); assert(!bdrv_dirty_bitmap_readonly(bitmap)); hbitmap_reset(bitmap->bitmap, offset, bytes); }
It is needed for use the bitmaps in backup. "disabled" means that bitmap is not auto set by writes. Let's allow changing bitmap for other uses. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- block/dirty-bitmap.c | 2 -- 1 file changed, 2 deletions(-)