Patchwork Remove dependency of all-target-libobjc on maybe-all-target-libiberty

login
register
mail settings
Submitter Nicola Pero
Date May 27, 2011, 4:10 p.m.
Message ID <FC2BF322-8AA7-4889-9469-91FD35161FDD@meta-innovation.com>
Download mbox | patch
Permalink /patch/97702/
State New
Headers show

Comments

Nicola Pero - May 27, 2011, 4:10 p.m.
This patch removes the (maybe) dependency of libobjc from target libiberty from
the makefiles.

I don't know of any reasons why libobjc would need target libiberty; I also looked around
and couldn't spot anything.  Most other target libraries don't depend on libiberty; I'm
not sure why libobjc would need to.  I think the dependency is bogus, probably exists
for historical reasons and the fact that nobody reviewed that piece of code for a long
time, and should go away. :-)

It wouldn't matter much, but I saw that some people are keen to remove the target libiberty
completely, and I wouldn't want them to spend time trying to figure out why libobjc needs
it.  It doesn't. ;-)

Ok to commit ?

Thanks

Patch

Index: Makefile.in
===================================================================
--- Makefile.in (revision 174141)
+++ Makefile.in (working copy)
@@ -43412,7 +43412,6 @@ 
all-target-libjava: maybe-all-target-boehm-gc
all-target-libjava: maybe-all-target-libffi
configure-target-libobjc: maybe-configure-target-boehm-gc
-all-target-libobjc: maybe-all-target-libiberty
all-target-libobjc: maybe-all-target-boehm-gc
all-target-libstdc++-v3: maybe-all-target-libiberty
configure-target-libstdc++-v3: maybe-configure-target-libgomp
Index: ChangeLog
===================================================================
--- ChangeLog   (revision 174141)
+++ ChangeLog   (working copy)
@@ -1,3 +1,8 @@ 
+2011-05-27  Nicola Pero  <nicola.pero@meta-innovation.com>
+
+       * Makefile.in (all-target-libobjc): Do not depend on
+       maybe-all-target-libiberty.
+
2011-05-11  Paul Pluzhnikov  <ppluzhnikov@google.com>

    * MAINTAINERS (Write After Approval): Add myself.