Patchwork qemu-iotest: test 005, don't run on raw

login
register
mail settings
Submitter Feiran Zheng
Date May 27, 2011, 10:45 a.m.
Message ID <BANLkTi=dbwGOBCy2YtOx-bZ5V+R1Y5msPg@mail.gmail.com>
Download mbox | patch
Permalink /patch/97670/
State New
Headers show

Comments

Feiran Zheng - May 27, 2011, 10:45 a.m.
Patch on qemu-iotest.

005, test of creating 5TB images, not practical on raw format, so not run on it.

Signed-off-by: Fam Zheng <famcool@gmail.com>
---
 005 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Christoph Hellwig - May 27, 2011, 10:47 a.m.
On Fri, May 27, 2011 at 06:45:03PM +0800, Feiran Zheng wrote:
> Patch on qemu-iotest.
> 
> 005, test of creating 5TB images, not practical on raw format, so not run on it.

It's perfectly fine on raw, just try it.
Feiran Zheng - May 27, 2011, 10:48 a.m.
Does this mean one must have that large fs space?

On Fri, May 27, 2011 at 6:47 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Fri, May 27, 2011 at 06:45:03PM +0800, Feiran Zheng wrote:
>> Patch on qemu-iotest.
>>
>> 005, test of creating 5TB images, not practical on raw format, so not run on it.
>
> It's perfectly fine on raw, just try it.
>
>
Christoph Hellwig - May 27, 2011, 10:58 a.m.
On Fri, May 27, 2011 at 06:48:49PM +0800, Feiran Zheng wrote:
> Does this mean one must have that large fs space?

No.

Patch

diff --git a/005 b/005
index 74537db..e086b6f 100755
--- a/005
+++ b/005
@@ -46,7 +46,7 @@  _supported_proto generic
 _supported_os Linux

 # vpc is limited to 127GB, so we can't test it here
-if [ "$IMGFMT" = "vpc" ]; then
+if [ "$IMGFMT" = "vpc" ] || [ "$IMGFMT" = "raw" ]; then
     _notrun "image format $IMGFMT does not support large image sizes"
 fi