From patchwork Fri May 27 06:20:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilles Chanteperdrix X-Patchwork-Id: 97656 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id B95C8B6F86 for ; Fri, 27 May 2011 16:20:32 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 843D02809C; Fri, 27 May 2011 08:20:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JKe1q1VD7kjV; Fri, 27 May 2011 08:20:30 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B9C8128096; Fri, 27 May 2011 08:20:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D424328096 for ; Fri, 27 May 2011 08:20:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hjb05Uk0T-QD for ; Fri, 27 May 2011 08:20:24 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from xenomai.org (xenomai.org [88.191.95.136]) by theia.denx.de (Postfix) with ESMTPS id 06F4D28095 for ; Fri, 27 May 2011 08:20:22 +0200 (CEST) Received: from men13-3-82-231-18-196.fbx.proxad.net ([82.231.18.196] helo=hephaistos) by xenomai.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1QPqPE-0003K3-Vm; Fri, 27 May 2011 08:20:21 +0200 Received: from localhost ([127.0.0.1]) by hephaistos with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1QPqPD-0003ZW-Pj; Fri, 27 May 2011 08:20:19 +0200 Message-ID: <4DDF42A2.1040402@xenomai.org> Date: Fri, 27 May 2011 08:20:18 +0200 From: Gilles Chanteperdrix Organization: Xenomai User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.24) Gecko/20100329 Lightning/0.8 Icedove/2.0.0.14 Mnenhy/0.7.6.666 MIME-Version: 1.0 To: Peter Meerwald References: In-Reply-To: X-Enigmail-Version: 1.0.1 Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] omap4 EHCI support and SMSC95xx support on panda X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de On 05/26/2011 10:52 PM, Peter Meerwald wrote: > Hello, > > I am trying to get tftp working on the pandaboard; I am testing Simon's v6 > patch series and Gilles EHCI patches > > doc/README.sub claims that the SMSC driver supports usbethaddr, I do not > see this > > smsc95xx_init_mac_address() fails to get the hwaddr from eeprom and then > it should do > if (eth_getenv_enetaddr_by_index("usbeth", 0, eth->enetaddr)) { > debug("MAC address read from usbethaddr\n"); > return 0; > } > which is missing? > > > this is what I get after fixing the usbethaddr issue -- any ideas? Hi Peter, A few details I forgot to post it on this list: in order to get EHCI working on Panda, I had to add the following patch on top of Simon's patches: } From the traces you show, I am not sure this is what you are missing, though. The other "detail", is that I used the latest version of X-loader git, it may enable some clocks that previous versions did not enable. I would like to rebase the patches on the SPL patches posted recently. Regards. diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index 4d8dde0..97f2729 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -873,6 +873,7 @@ int smsc95xx_eth_get_info(struct usb_device *dev, struct ueth_data *ss, eth->send = smsc95xx_send; eth->recv = smsc95xx_recv; eth->halt = smsc95xx_halt; + eth->write_hwaddr = smsc95xx_write_hwaddr; eth->priv = ss; return 1;