From patchwork Fri Sep 28 14:41:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniy Paltsev X-Patchwork-Id: 976347 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=synopsys.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fr5z8TkR"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="bHetcruL"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=synopsys.com header.i=@synopsys.com header.b="KCoVJYwI"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42MDsr4kLqz9s3x for ; Sat, 29 Sep 2018 00:42:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=LFcb5KwxMV/+Oo7YYNhO+pqhOYYOrStFdFBGj5qtBrQ=; b=fr5 z8TkRCceAhxjfNUeVqGYjgub4yDqlk1x0LJFQu/yfYfon5hNgLaK9K38em/nISuIkmm4ghxxwxtKb EkMkPOXtX5qzv7OP8CN4QKV8ayO2nshj61j2c/UY0c6XOwgrsXzK/9wG/+oWx+qRkj10CVwmCKwDF 57o6MxsL0qMepdDU4Dmb+ZK2+97tHFr5Er2cF0y3erua0eemlrjeTKdfZLjH8WETP+iOPgHNfpQYW Ak5uGb/JWN7VcNC5pwxk240N6rKJYYEE+qFsH5gQiv1YY06+T7e5lc5zrwZZmgIIjhhVEHLF/PGoO 2JAUDjFRckr0ERYv3RuF4jr98/GNJ0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5tyE-0002JL-ON; Fri, 28 Sep 2018 14:42:18 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5txo-00027N-Di for linux-snps-arc@bombadil.infradead.org; Fri, 28 Sep 2018 14:41:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DSCPXJsE+yMmaKQrA5xIWsRS8dw+6vMRYU1mJ2axpzg=; b=bHetcruL2tq2gLfSvdCr6goT4 27K603BDyUeOT3zA7PfgepwW/w1Pql3d6ppfXav1KdZXqikjZ+dC/v1VrrvtwhK+awRPSERENT+s+ 3Z2PZundn2byXcy2B9EIuUsWmNou3r2K9h1rpmteCm0jetAWsJGxBrUe3K8M9yjthMRcngdqyMpmg FMSKTY83KI269xgbUcMIliaMySImgDIdVHTYXexrSZ8L0tYKp0gAdlH5jobOwuCHPdGdBY7GD1gVb 6m9ilxosHHB/w8zrPgH5RRbn0Lzk2OVXfBjfoSVRCYfeWMD69GW/KP1qp12blzTiIbNiXR3JeL4Uj MFt1y3nfQ==; Received: from smtprelay2.synopsys.com ([198.182.60.111] helo=smtprelay.synopsys.com) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5txl-00089X-0M for linux-snps-arc@lists.infradead.org; Fri, 28 Sep 2018 14:41:49 +0000 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id A0F0B10C004C; Fri, 28 Sep 2018 07:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1538145694; bh=4IerRvNCRoBUloaYVlCmS3x8cTKmn1sVeG2yKTlk2tQ=; h=From:To:Cc:Subject:Date:From; b=KCoVJYwIScgvWftCNEy/r5ft9v96znLbLfVEl0RoqNsjVTg8HO0jheYy79fcch1XF YnCC1zLWC3G7G947xTieTOUIqKcHdz/jMfyIcK1FQ/7lFsZa3VOacGRNPgEPxnkSw+ MSVQDdo9odkuslewlxeMzv/PFMUA+1/Wzw5aVqsYOv0jTPBMod+c6G3sjn/7tmtnve jyzGKHc/Ph+sjBdKXryroSXiuJguGjnWdem1GPST1eEHexOpV7lGIXwbU2Q3UZqVH2 9O20WQQX95FbmBKBcyb9jZ9DYgRSIdpqwDk6gxAYOaCbiQ9+8Jbk6n5G7aUfK8P3ot MrxPLTqkdiU1w== Received: from paltsev-e7480.internal.synopsys.com (paltsev-e7480.internal.synopsys.com [10.121.3.38]) by mailhost.synopsys.com (Postfix) with ESMTP id 9CAF35578; Fri, 28 Sep 2018 07:41:29 -0700 (PDT) From: Eugeniy Paltsev To: dri-devel@lists.freedesktop.org Subject: [PATCH] DRM: UDL: get rid of useless vblank initialization Date: Fri, 28 Sep 2018 17:41:26 +0300 Message-Id: <20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com> X-Mailer: git-send-email 2.14.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180928_104149_171300_82206517 X-CRM114-Status: UNSURE ( 8.61 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on merlin.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [198.182.60.111 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Gustavo Padovan , Alexey Brodkin , Maarten Lankhorst , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Eugeniy Paltsev , =?utf-8?q?St=C3=A9pha?= =?utf-8?q?ne_Marchesin?= , linux-snps-arc@lists.infradead.org, Sean Paul MIME-Version: 1.0 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org UDL doesn't support vblank functionality so we don't need to initialize vblank here (we are able to send page flip completion events even without vblank initialization) Moreover current drm_vblank_init call with num_crtcs > 0 causes sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every time. This breaks userspace apps (for example weston) which relies on timestamp value. Cc: stable@vger.kernel.org Signed-off-by: Eugeniy Paltsev Reviewed-by: Daniel Vetter --- drivers/gpu/drm/udl/udl_main.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c index f455f095a146..1b014d92855b 100644 --- a/drivers/gpu/drm/udl/udl_main.c +++ b/drivers/gpu/drm/udl/udl_main.c @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags) if (ret) goto err; - ret = drm_vblank_init(dev, 1); - if (ret) - goto err_fb; - drm_kms_helper_poll_init(dev); return 0; -err_fb: - udl_fbdev_cleanup(dev); + err: if (udl->urbs.count) udl_free_urb_list(dev);