Patchwork target-ppc: Fix compilation error with --enable-debug

login
register
mail settings
Submitter Peter Maydell
Date May 26, 2011, 6:05 p.m.
Message ID <1306433153-3671-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/97605/
State New
Headers show

Comments

Peter Maydell - May 26, 2011, 6:05 p.m.
The PPC helper functions booke206_tlbflush and booke_setpid both
take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
to avoid a compilation failure when compiling in debug mode.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-ppc/translate_init.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Stefan Weil - May 26, 2011, 6:28 p.m.
Am 26.05.2011 20:05, schrieb Peter Maydell:
> The PPC helper functions booke206_tlbflush and booke_setpid both
> take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
> to avoid a compilation failure when compiling in debug mode.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target-ppc/translate_init.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>

See http://patchwork.ozlabs.org/patch/96665/

It's a waste of time if build fixes take more than 3 days to get committed.

The typical process - several days until the maintainer accepts it, more
days until there is a pull request, even more days until it is pulled -
is good enough for new features, but too slow for bug fixes, especially
when they fix broken builds.

Cheers,
Stefan W.
Peter Maydell - May 26, 2011, 6:31 p.m.
On 26 May 2011 19:28, Stefan Weil <weil@mail.berlios.de> wrote:
> Am 26.05.2011 20:05, schrieb Peter Maydell:
>> The PPC helper functions booke206_tlbflush and booke_setpid both
>> take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
>> to avoid a compilation failure when compiling in debug mode.

> See http://patchwork.ozlabs.org/patch/96665/

Oops; I did try searching my mail for a fix, but obviously failed
to use the right search term.

-- PMM
Alexander Graf - May 26, 2011, 9:32 p.m.
Am 26.05.2011 um 20:28 schrieb Stefan Weil <weil@mail.berlios.de>:

> Am 26.05.2011 20:05, schrieb Peter Maydell:
>> The PPC helper functions booke206_tlbflush and booke_setpid both
>> take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
>> to avoid a compilation failure when compiling in debug mode.
>> 
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> target-ppc/translate_init.c | 8 ++++----
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>> 
> 
> See http://patchwork.ozlabs.org/patch/96665/
> 
> It's a waste of time if build fixes take more than 3 days to get committed.
> 
> The typical process - several days until the maintainer accepts it, more
> days until there is a pull request, even more days until it is pulled -
> is good enough for new features, but too slow for bug fixes, especially
> when they fix broken builds.

I agree, but I think the solution to the problem is to not break builds. I'm currently spending all day setting up kvm-autotest for automated regression testing and am eagerly waiting on Stefan to get the buildbot stuff rolling on submaintainer trees.

With those two things in place, we should be a lot safer.


Alex

>

Patch

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index b511afa..d11532c 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -1367,16 +1367,16 @@  static void spr_write_e500_l1csr0 (void *opaque, int sprn, int gprn)
 
 static void spr_write_booke206_mmucsr0 (void *opaque, int sprn, int gprn)
 {
-    TCGv t0 = tcg_const_i32(sprn);
+    TCGv_i32 t0 = tcg_const_i32(sprn);
     gen_helper_booke206_tlbflush(t0);
-    tcg_temp_free(t0);
+    tcg_temp_free_i32(t0);
 }
 
 static void spr_write_booke_pid (void *opaque, int sprn, int gprn)
 {
-    TCGv t0 = tcg_const_i32(sprn);
+    TCGv_i32 t0 = tcg_const_i32(sprn);
     gen_helper_booke_setpid(t0, cpu_gpr[gprn]);
-    tcg_temp_free(t0);
+    tcg_temp_free_i32(t0);
 }
 #endif