| Message ID | 1306427323.7510.2.camel@lb-tlvb-dmitry |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2011-05-26 at 09:28 -0700, Dmitry Kravkov wrote: > --- > net/sctp/bind_addr.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > It was easier to fix it like commit 1231f0baa547a541a7481119323b7f964dda4788 does, than to disable it in kernel config :) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
This has been fixed for days. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>-----Original Message----- >From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On >Behalf Of David Miller >Sent: Thursday, May 26, 2011 10:39 AM >To: dmitry@broadcom.com >Cc: netdev@vger.kernel.org; difrost.kernel@gmail.com >Subject: Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free > > >This has been fixed for days. Fixed in net-2.6, yes, but not yet in net-next-2.6 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Allan, Bruce W" <bruce.w.allan@intel.com> Date: Thu, 26 May 2011 11:40:34 -0700 >>-----Original Message----- >>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On >>Behalf Of David Miller >>Sent: Thursday, May 26, 2011 10:39 AM >>To: dmitry@broadcom.com >>Cc: netdev@vger.kernel.org; difrost.kernel@gmail.com >>Subject: Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free >> >> >>This has been fixed for days. > > Fixed in net-2.6, yes, but not yet in net-next-2.6 net-next-2.6 is not active and is just a dummy tree for Stephen Rothwell to pull into -next You should never be referencing or using net-next-2.6 during the merge window when new features changes are not being accepted. Only net-2.6 is active during this time. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2011-05-26 at 11:44 -0700, David Miller wrote: > From: "Allan, Bruce W" <bruce.w.allan@intel.com> > Date: Thu, 26 May 2011 11:40:34 -0700 > > >>-----Original Message----- > >>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On > >>Behalf Of David Miller > >>Sent: Thursday, May 26, 2011 10:39 AM > >>To: dmitry@broadcom.com > >>Cc: netdev@vger.kernel.org; difrost.kernel@gmail.com > >>Subject: Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free > >> > >> > >>This has been fixed for days. > > > > Fixed in net-2.6, yes, but not yet in net-next-2.6 > > net-next-2.6 is not active and is just a dummy tree for Stephen > Rothwell to pull into -next > > You should never be referencing or using net-next-2.6 during the > merge window when new features changes are not being accepted. > Only net-2.6 is active during this time. > Hmm, so how similar will be net-2.6 and net-next-2.6 when re-opened? You apply a lot of fixes during this time... And yes, i've hit the compilation error in net-next since i'm using it as basis for future features submit -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Dmitry Kravkov" <dmitry@broadcom.com> Date: Thu, 26 May 2011 22:07:01 +0300 > On Thu, 2011-05-26 at 11:44 -0700, David Miller wrote: >> From: "Allan, Bruce W" <bruce.w.allan@intel.com> >> Date: Thu, 26 May 2011 11:40:34 -0700 >> >> >>-----Original Message----- >> >>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On >> >>Behalf Of David Miller >> >>Sent: Thursday, May 26, 2011 10:39 AM >> >>To: dmitry@broadcom.com >> >>Cc: netdev@vger.kernel.org; difrost.kernel@gmail.com >> >>Subject: Re: [PATCH] sctp compilation failed due to lack of sctp_local_addr_free >> >> >> >> >> >>This has been fixed for days. >> > >> > Fixed in net-2.6, yes, but not yet in net-next-2.6 >> >> net-next-2.6 is not active and is just a dummy tree for Stephen >> Rothwell to pull into -next >> >> You should never be referencing or using net-next-2.6 during the >> merge window when new features changes are not being accepted. >> Only net-2.6 is active during this time. >> > Hmm, so how similar will be net-2.6 and net-next-2.6 when re-opened? > You apply a lot of fixes during this time... When it opens up I just update net-next-2.6 to whatever is in net-2.6 at the time. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sctp/bind_addr.c b/net/sctp/bind_addr.c index 6338413..83e3011 100644 --- a/net/sctp/bind_addr.c +++ b/net/sctp/bind_addr.c @@ -145,7 +145,7 @@ static void sctp_bind_addr_clean(struct sctp_bind_addr *bp) /* Empty the bind address list. */ list_for_each_entry_safe(addr, temp, &bp->address_list, list) { list_del_rcu(&addr->list); - call_rcu(&addr->rcu, sctp_local_addr_free); + kfree_rcu(addr, rcu); SCTP_DBG_OBJCNT_DEC(addr); } }