Message ID | 20180927064651.3118-1-andrew@aj.id.au |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | [linux,dev-4.18] arm: dts: aspeed: Use ColdFire FSI offload on Witherspoon | expand |
> On Sep 27, 2018, at 2:46 AM, Andrew Jeffery <andrew@aj.id.au> wrote: > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Acked-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
On Fri, 28 Sep 2018 at 01:58, Brad Bishop <bradleyb@fuzziesquirrel.com> wrote: > > > > > On Sep 27, 2018, at 2:46 AM, Andrew Jeffery <andrew@aj.id.au> wrote: > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > Acked-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Thanks. Can you also submit this upstream? If I merge this into the openbmc kernel tree and bump meta-aspeed, does witherspoon have the appropriate bits in place to still work? Cheers, Joel
On Mon, 22 Oct 2018, at 08:55, Joel Stanley wrote: > On Fri, 28 Sep 2018 at 01:58, Brad Bishop <bradleyb@fuzziesquirrel.com> wrote: > > > > > > > > > On Sep 27, 2018, at 2:46 AM, Andrew Jeffery <andrew@aj.id.au> wrote: > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > > Acked-by: Brad Bishop <bradleyb@fuzziesquirrel.com> > > Thanks. Can you also submit this upstream? > > If I merge this into the openbmc kernel tree and bump meta-aspeed, > does witherspoon have the appropriate bits in place to still work? No yet, you NAK'ed my dodgy patch for the Witherspoon rootfs. I need to sort out how to do it properly. > > Cheers, > > Joel
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts index f4739ec8051b..b8184c8283d1 100644 --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts @@ -33,6 +33,11 @@ compatible = "shared-dma-pool"; reusable; }; + + coldfire_memory: codefire_memory@9ef00000 { + reg = <0x9ef00000 0x00100000>; + no-map; + }; }; gpio-keys { @@ -157,10 +162,13 @@ }; fsi: gpio-fsi { - compatible = "fsi-master-gpio", "fsi-master"; + compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master"; #address-cells = <2>; #size-cells = <0>; - no-gpio-delays; + + memory-region = <&coldfire_memory>; + aspeed,sram = <&sram>; + aspeed,cvic = <&cvic>; clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>; data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)