| Message ID | 20180926144317.26139-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] pinctrl: intel: Fix a spelling typo in kernel documentation | expand |
On Wed, Sep 26, 2018 at 05:43:17PM +0300, Andy Shevchenko wrote: > The parameter 'community' had been spelled incorrectly. > Fix it here. > > As a side effect it satisfies static checkers that issue > the following warnings: > > drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Function parameter or member 'community' not described in 'intel_gpio_to_pin' > drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Excess function parameter 'commmunity' description in 'intel_gpio_to_pin' > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Wed, Sep 26, 2018 at 4:43 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > The parameter 'community' had been spelled incorrectly. > Fix it here. > > As a side effect it satisfies static checkers that issue > the following warnings: > > drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Function parameter or member 'community' not described in 'intel_gpio_to_pin' > drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Excess function parameter 'commmunity' description in 'intel_gpio_to_pin' > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch does not apply on devel, I guess rebase and resend. There is just too much Intel stuff coming in right now, things start clashing. Right now I have some merge conflicts between fixes and devel that I need to sort out by merging in -rc6 after the weekend (I hope that will solve things)... Andy if this persists, would you be willing to start collecting patches for Intel on a branch and send me pull requests instead? This is what we did for Renesas when it started to happen too much there. Yours, Linus Walleij
On Fri, Sep 28, 2018 at 09:25:00AM +0200, Linus Walleij wrote: > On Wed, Sep 26, 2018 at 4:43 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > The parameter 'community' had been spelled incorrectly. > > Fix it here. > > > > As a side effect it satisfies static checkers that issue > > the following warnings: > > > > drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Function parameter or member 'community' not described in 'intel_gpio_to_pin' > > drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Excess function parameter 'commmunity' description in 'intel_gpio_to_pin' > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Patch does not apply on devel, I guess rebase and resend. Strange. Here is the same comment as per the other series... > There is just too much Intel stuff coming in right now, things > start clashing. Sadly I tend to agree with this. > Right now I have some merge conflicts between fixes and > devel that I need to sort out by merging in -rc6 after the weekend > (I hope that will solve things)... > > Andy if this persists, would you be willing to start collecting > patches for Intel on a branch and send me pull requests instead? > This is what we did for Renesas when it started to happen too > much there. We discussed this with Mika and decide to follow your suggestion, for the next (v4.21) cycle we would establish a tree (either on kernel.org or infradead.org) and will do PR's for Intel GPIO and pin control stuff. I hope this will unload you with our pile of slight mess.
On Mon, Oct 1, 2018 at 8:00 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Fri, Sep 28, 2018 at 09:25:00AM +0200, Linus Walleij wrote: > > On Wed, Sep 26, 2018 at 4:43 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > The parameter 'community' had been spelled incorrectly. > > > Fix it here. > > > > > > As a side effect it satisfies static checkers that issue > > > the following warnings: > > > > > > drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Function parameter or member 'community' not described in 'intel_gpio_to_pin' > > > drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Excess function parameter 'commmunity' description in 'intel_gpio_to_pin' > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > Patch does not apply on devel, I guess rebase and resend. > > Strange. Here is the same comment as per the other series... Probably my fault. Applied now. > > Andy if this persists, would you be willing to start collecting > > patches for Intel on a branch and send me pull requests instead? > > This is what we did for Renesas when it started to happen too > > much there. > > We discussed this with Mika and decide to follow your suggestion, for the next > (v4.21) cycle we would establish a tree (either on kernel.org or infradead.org) > and will do PR's for Intel GPIO and pin control stuff. I hope this will unload > you with our pile of slight mess. OK that would be great :) Hopefully it will also make it smoother and quicker for your changes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 32f40a193398..09c3cf40297c 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -754,7 +754,7 @@ static const struct pinctrl_desc intel_pinctrl_desc = { * intel_gpio_to_pin() - Translate from GPIO offset to pin number * @pctrl: Pinctrl structure * @offset: GPIO offset from gpiolib - * @commmunity: Community is filled here if not %NULL + * @community: Community is filled here if not %NULL * @padgrp: Pad group is filled here if not %NULL * * When coming through gpiolib irqchip, the GPIO offset is not
The parameter 'community' had been spelled incorrectly. Fix it here. As a side effect it satisfies static checkers that issue the following warnings: drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Function parameter or member 'community' not described in 'intel_gpio_to_pin' drivers/pinctrl/intel/pinctrl-intel.c:845: warning: Excess function parameter 'commmunity' description in 'intel_gpio_to_pin' Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)