Patchwork ARM: mxs_defconfig: Remove locking debug config options

login
register
mail settings
Submitter Shawn Guo
Date May 26, 2011, 6:26 a.m.
Message ID <1306391203-29338-1-git-send-email-shawn.guo@linaro.org>
Download mbox | patch
Permalink /patch/97500/
State New
Headers show

Comments

Shawn Guo - May 26, 2011, 6:26 a.m.
The amba-pl011 driver assumes that clk_enable/disable are atomic, but
currently it's not the case on mxs.  There are lock debug warnings
seen when serial console does power management.

The patch removes locking debug config options to get rid of the
warnings.  They can be turned on later when new clock framework sorts
the locking thing out.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 arch/arm/configs/mxs_defconfig |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Uwe Kleine-König - May 26, 2011, noon
On Thu, May 26, 2011 at 02:26:43PM +0800, Shawn Guo wrote:
> The amba-pl011 driver assumes that clk_enable/disable are atomic, but
> currently it's not the case on mxs.  There are lock debug warnings
> seen when serial console does power management.
> 
> The patch removes locking debug config options to get rid of the
> warnings.  They can be turned on later when new clock framework sorts
> the locking thing out.
I'd keep the debug messages enabled. Just because you disable them the
problem isn't gone. This way it's a bit more certain that it gets fixed
...

Best regards
Uwe
Shawn Guo - May 27, 2011, 8:19 a.m.
On Thu, May 26, 2011 at 02:00:55PM +0200, Uwe Kleine-König wrote:
> On Thu, May 26, 2011 at 02:26:43PM +0800, Shawn Guo wrote:
> > The amba-pl011 driver assumes that clk_enable/disable are atomic, but
> > currently it's not the case on mxs.  There are lock debug warnings
> > seen when serial console does power management.
> > 
> > The patch removes locking debug config options to get rid of the
> > warnings.  They can be turned on later when new clock framework sorts
> > the locking thing out.
> I'd keep the debug messages enabled. Just because you disable them the
> problem isn't gone. This way it's a bit more certain that it gets fixed
> ...
> 
This is a well known problem.  Migrating to new clock framework is on
top of my TODO list, and I will do once it comes.  Before that, all
we can do is looking at the warning message every single time we boot
the kernel.  It is not helping anything but getting valuable debugging
message invisible in the flooding lock warnings.

Patch

diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
index db2cb7d..f9a54a6 100644
--- a/arch/arm/configs/mxs_defconfig
+++ b/arch/arm/configs/mxs_defconfig
@@ -116,8 +116,6 @@  CONFIG_DEBUG_KERNEL=y
 CONFIG_LOCKUP_DETECTOR=y
 CONFIG_DETECT_HUNG_TASK=y
 CONFIG_TIMER_STATS=y
-CONFIG_PROVE_LOCKING=y
-CONFIG_DEBUG_SPINLOCK_SLEEP=y
 CONFIG_DEBUG_INFO=y
 CONFIG_SYSCTL_SYSCALL_CHECK=y
 CONFIG_BLK_DEV_IO_TRACE=y