Patchwork [1/2] jbd2: fix a bug of leaking jh->b_jcount

login
register
mail settings
Submitter dingdinghua
Date May 26, 2011, 2:28 a.m.
Message ID <1306376902-13308-1-git-send-email-dingdinghua@nrchpc.ac.cn>
Download mbox | patch
Permalink /patch/97485/
State Accepted
Headers show

Comments

dingdinghua - May 26, 2011, 2:28 a.m.
jbd2_journal_get_create_access should drop jh->b_jcount in error
handling path

Signed-off-by: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
---
 fs/jbd2/transaction.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Theodore Ts'o - May 26, 2011, 3:16 p.m.
On Thu, May 26, 2011 at 10:28:22AM +0800, Ding Dinghua wrote:
> jbd2_journal_get_create_access should drop jh->b_jcount in error
> handling path
> 
> Signed-off-by: Ding Dinghua <dingdinghua@nrchpc.ac.cn>

Thanks, merged into the ext4 tree.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 05fa77a..d66672a 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -921,8 +921,8 @@  int jbd2_journal_get_create_access(handle_t *handle, struct buffer_head *bh)
 	 */
 	JBUFFER_TRACE(jh, "cancelling revoke");
 	jbd2_journal_cancel_revoke(handle, jh);
-	jbd2_journal_put_journal_head(jh);
 out:
+	jbd2_journal_put_journal_head(jh);
 	return err;
 }