| Message ID | 20180924142536.27801-2-alexandre.belloni@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] rtc: armada38x: fix possible race condition | expand |
Hi Alexandre, On lun., sept. 24 2018, Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > The RTC is a 32bit seconds counter. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> I checked that with a 64bits userspace setting the date further than 2106 doesn't wrap silently anymore. Tested-by: Gregory CLEMENT <gregory.clement@bootlin.com> Thanks, Gregory > --- > drivers/rtc/rtc-armada38x.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c > index b74338d6dde6..d0278ad0a7f9 100644 > --- a/drivers/rtc/rtc-armada38x.c > +++ b/drivers/rtc/rtc-armada38x.c > @@ -577,6 +577,8 @@ static __init int armada38x_rtc_probe(struct platform_device *pdev) > /* Update RTC-MBUS bridge timing parameters */ > rtc->data->update_mbus_timing(rtc); > > + rtc->rtc_dev->range_max = U32_MAX; > + > ret = rtc_register_device(rtc->rtc_dev); > if (ret) > dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret); > -- > 2.19.0 >
diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c index b74338d6dde6..d0278ad0a7f9 100644 --- a/drivers/rtc/rtc-armada38x.c +++ b/drivers/rtc/rtc-armada38x.c @@ -577,6 +577,8 @@ static __init int armada38x_rtc_probe(struct platform_device *pdev) /* Update RTC-MBUS bridge timing parameters */ rtc->data->update_mbus_timing(rtc); + rtc->rtc_dev->range_max = U32_MAX; + ret = rtc_register_device(rtc->rtc_dev); if (ret) dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
The RTC is a 32bit seconds counter. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> --- drivers/rtc/rtc-armada38x.c | 2 ++ 1 file changed, 2 insertions(+)