| Message ID | alpine.SOC.1.00.1105251836550.16961@math.ut.ee |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, May 25, 2011 at 08:43:47AM -0700, Meelis Roos wrote: > This patch adds the PCI ID of Fujitsu 1000base-SX NIC to tg3 driver. > Tested to detect the card, MAC and serdes, not tested with link at the > moment since I have no fiber switch here. I did not add new constants to > the pci_ids.h header file since these constants are used only here. > > Signed-off-by: Meelis Roos <mroos@linux.ee> > > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c > index 7a5daef..7b1901e 100644 > --- a/drivers/net/tg3.c > +++ b/drivers/net/tg3.c > @@ -273,6 +273,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = { > {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1003)}, > {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC9100)}, > {PCI_DEVICE(PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_TIGON3)}, > + {PCI_DEVICE(0x10cf, 0x11a2)}, /* Fujitsu 1000base-SX with BCM5703SKHB */ > {} > }; I don't have any problems with the patch, but before we integrate it, can we make sure it passes traffic? I'd hate to add support for a device and later find out it doesn't work. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > This patch adds the PCI ID of Fujitsu 1000base-SX NIC to tg3 driver. > > Tested to detect the card, MAC and serdes, not tested with link at the > > moment since I have no fiber switch here. I did not add new constants to > > the pci_ids.h header file since these constants are used only here. > > > > Signed-off-by: Meelis Roos <mroos@linux.ee> > > > > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c > > index 7a5daef..7b1901e 100644 > > --- a/drivers/net/tg3.c > > +++ b/drivers/net/tg3.c > > @@ -273,6 +273,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = { > > {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1003)}, > > {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC9100)}, > > {PCI_DEVICE(PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_TIGON3)}, > > + {PCI_DEVICE(0x10cf, 0x11a2)}, /* Fujitsu 1000base-SX with BCM5703SKHB */ > > {} > > }; > > I don't have any problems with the patch, but before we integrate it, > can we make sure it passes traffic? I'd hate to add support for a > device and later find out it doesn't work. Checked with direct link to another NIC, link came up. [ 99.067432] tg3 0000:01:0b.0: eth1: Link is up at 1000 Mbps, full duplex [ 99.067662] tg3 0000:01:0b.0: eth1: Flow control is on for TX and on for RX I can also see DHCP requests from one interface on the other with tcpdump, so data gets also through. Seems to work.
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 7a5daef..7b1901e 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -273,6 +273,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = { {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1003)}, {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC9100)}, {PCI_DEVICE(PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_TIGON3)}, + {PCI_DEVICE(0x10cf, 0x11a2)}, /* Fujitsu 1000base-SX with BCM5703SKHB */ {} };
This patch adds the PCI ID of Fujitsu 1000base-SX NIC to tg3 driver. Tested to detect the card, MAC and serdes, not tested with link at the moment since I have no fiber switch here. I did not add new constants to the pci_ids.h header file since these constants are used only here. Signed-off-by: Meelis Roos <mroos@linux.ee>