[U-Boot,07/15] test: Simplify the PATH setup

Message ID	20180923224727.204542-8-sjg@chromium.org
State	Superseded
Delegated to:	Simon Glass
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> Date: Sun, 23 Sep 2018 16:47:19 -0600 In-Reply-To: <20180923224727.204542-1-sjg@chromium.org> Message-Id: <20180923224727.204542-8-sjg@chromium.org> Mime-Version: 1.0 References: <20180923224727.204542-1-sjg@chromium.org> From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Tom Rini <trini@konsulko.com>, Stephen Warren <swarren@nvidia.com> Subject: [U-Boot] [PATCH 07/15] test: Simplify the PATH setup Precedence: list Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	test: Various test refinements and improvements \| expand [U-Boot,00/15] test: Various test refinements and improvements [U-Boot,01/15] sandbox: Unprotect DATA regions in bus tests [U-Boot,02/15] patman: Handle unicode in _ProjectConfigParser tests [U-Boot,03/15] test/py: Fix unicode handling for log filtering [U-Boot,04/15] buildman: Make the toolchain test more forgiving [U-Boot,05/15] binman: Reorder tests to put helper functions first [U-Boot,06/15] Makefile: Add a 'check' target for make [U-Boot,07/15] test: Simplify the PATH setup [U-Boot,08/15] test: Print the name of each test before running it [U-Boot,09/15] test: Tidy up comments and variable name [U-Boot,10/15] binman: Add a default path to libfdt.py [U-Boot,11/15] binman: Fix up removal of temporary directories [U-Boot,12/15] binman: Separate out testSplBssPad() [U-Boot,13/15] buildman: dtoc: Suppress unwanted output from test [U-Boot,14/15] tools: Set an initial value for indir [U-Boot,15/15] patman: Don't clear progress in tout unless it was used

Message ID

20180923224727.204542-8-sjg@chromium.org

State

Superseded

Delegated to:

Simon Glass

Headers

Date: Sun, 23 Sep 2018 16:47:19 -0600
In-Reply-To: <20180923224727.204542-1-sjg@chromium.org>
Message-Id: <20180923224727.204542-8-sjg@chromium.org>
Mime-Version: 1.0
References: <20180923224727.204542-1-sjg@chromium.org>
From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Stephen Warren <swarren@nvidia.com>
Subject: [U-Boot] [PATCH 07/15] test: Simplify the PATH setup
Precedence: list
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

test: Various test refinements and improvements | expand

Commit Message

Simon Glass Sept. 23, 2018, 10:47 p.m. UTC

Use 'export' to avoid repeating the path setup for each command.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 test/run | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/test/run b/test/run
index d77a1c371b4..6b73813f9bc 100755
--- a/test/run
+++ b/test/run
@@ -16,23 +16,23 @@  run_test ./test/py/test.py --bd sandbox_spl --build -k test_ofplatdata.py
 # Run tests for the flat DT version of sandbox
 ./test/py/test.py --bd sandbox_flattree --build
 
+# Set up a path to dtc (device-tree compiler) and libfdt.py, a library it
+# provides and which is built by the sandbox_spl config.
 DTC_DIR=build-sandbox_spl/scripts/dtc
+export PYTHONPATH=${DTC_DIR}/pylibfdt
+export DTC=${DTC_DIR}/dtc
 
-PYTHONPATH=${DTC_DIR}/pylibfdt DTC=${DTC_DIR}/dtc run_test \
-	./tools/binman/binman -t
+run_test ./tools/binman/binman -t
 run_test ./tools/patman/patman --test
 run_test ./tools/buildman/buildman -t
-PYTHONPATH=${DTC_DIR}/pylibfdt DTC=${DTC_DIR}/dtc run_test ./tools/dtoc/dtoc -t
+run_test ./tools/dtoc/dtoc -t
 
 # This needs you to set up Python test coverage tools.
 # To enable Python test coverage on Debian-type distributions (e.g. Ubuntu):
 #   $ sudo apt-get install python-pytest python-coverage
-PYTHONPATH=${DTC_DIR}/pylibfdt DTC=${DTC_DIR}/dtc run_test \
-	./tools/binman/binman -T
-PYTHONPATH=${DTC_DIR}/pylibfdt DTC=${DTC_DIR}/dtc run_test \
-	./tools/dtoc/dtoc -T
-PYTHONPATH=${DTC_DIR}/pylibfdt DTC=${DTC_DIR}/dtc run_test \
-	./tools/dtoc/test_fdt -T
+run_test ./tools/binman/binman -T
+run_test ./tools/dtoc/dtoc -T
+run_test ./tools/dtoc/test_fdt -T
 
 if [ $result == 0 ]; then
 	echo "Tests passed!"

[U-Boot,07/15] test: Simplify the PATH setup

Commit Message

Patch