From patchwork Wed May 25 12:21:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 97367 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A62E4B6F84 for ; Thu, 26 May 2011 01:26:18 +1000 (EST) Received: from localhost ([::1]:44093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPFyR-0004CA-Gw for incoming@patchwork.ozlabs.org; Wed, 25 May 2011 11:26:15 -0400 Received: from eggs.gnu.org ([140.186.70.92]:52416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPFyD-0004Bs-Fa for qemu-devel@nongnu.org; Wed, 25 May 2011 11:26:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPFyC-0006ub-D3 for qemu-devel@nongnu.org; Wed, 25 May 2011 11:26:01 -0400 Received: from oxygen-new.pond.sub.org ([78.46.104.156]:36441 helo=oxygen.pond.sub.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPFyC-0006rS-7f for qemu-devel@nongnu.org; Wed, 25 May 2011 11:26:00 -0400 Received: from oxygen-old.pond.sub.org (oxygen.pond.sub.org [IPv6:2a01:4f8:130:9021::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "oxygen.pond.sub.org", Issuer "CAcert Class 3 Root" (verified OK)) by oxygen.pond.sub.org (Postfix) with ESMTPS id 923F5A2466 for ; Wed, 25 May 2011 14:21:15 +0200 (CEST) Received: from blackfin.pond.sub.org (p5B32BEFC.dip.t-dialin.net [91.50.190.252]) by oxygen-old.pond.sub.org (Postfix) with ESMTPA id 6BEF4277187 for ; Wed, 25 May 2011 14:21:15 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 500) id DB549288; Wed, 25 May 2011 14:21:14 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 25 May 2011 14:21:12 +0200 Message-Id: <1306326074-22737-4-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1306326074-22737-1-git-send-email-armbru@redhat.com> References: <1306326074-22737-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 78.46.104.156 Cc: amit.shah@redhat.com Subject: [Qemu-devel] [PATCH 3/5] virtio-serial: Drop useless property is_console X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org All you could ever achieve with it is break stuff, so removing it should be safe. Signed-off-by: Markus Armbruster --- hw/virtio-console.c | 2 -- hw/virtio-serial.h | 3 --- 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 50b85f8..180ac0a 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -91,7 +91,6 @@ static int virtconsole_initfn(VirtIOSerialPort *port) { VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port); - port->is_console_dummy = true; return generic_port_init(vcon, port); } @@ -117,7 +116,6 @@ static VirtIOSerialPortInfo virtconsole_info = { .init = virtconsole_initfn, .exit = virtconsole_exitfn, .qdev.props = (Property[]) { - DEFINE_PROP_UINT8("is_console", VirtConsole, port.is_console_dummy, 1), DEFINE_PROP_UINT32("nr", VirtConsole, port.id, VIRTIO_CONSOLE_BAD_ID), DEFINE_PROP_CHR("chardev", VirtConsole, chr), DEFINE_PROP_STRING("name", VirtConsole, port.name), diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h index c0d1717..acf049d 100644 --- a/hw/virtio-serial.h +++ b/hw/virtio-serial.h @@ -119,9 +119,6 @@ struct VirtIOSerialPort { uint32_t iov_idx; uint64_t iov_offset; - /* For property backward compatibility, not used otherwise */ - uint8_t is_console_dummy; - /* Is the corresponding guest device open? */ bool guest_connected; /* Is this device open for IO on the host? */