Patchwork [3/5] virtio-serial: Drop useless property is_console

login
register
mail settings
Submitter Markus Armbruster
Date May 25, 2011, 12:21 p.m.
Message ID <1306326074-22737-4-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/97367/
State New
Headers show

Comments

Markus Armbruster - May 25, 2011, 12:21 p.m.
All you could ever achieve with it is break stuff, so removing it
should be safe.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/virtio-console.c |    2 --
 hw/virtio-serial.h  |    3 ---
 2 files changed, 0 insertions(+), 5 deletions(-)

Patch

diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 50b85f8..180ac0a 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -91,7 +91,6 @@  static int virtconsole_initfn(VirtIOSerialPort *port)
 {
     VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
 
-    port->is_console_dummy = true;
     return generic_port_init(vcon, port);
 }
 
@@ -117,7 +116,6 @@  static VirtIOSerialPortInfo virtconsole_info = {
     .init          = virtconsole_initfn,
     .exit          = virtconsole_exitfn,
     .qdev.props = (Property[]) {
-        DEFINE_PROP_UINT8("is_console", VirtConsole, port.is_console_dummy, 1),
         DEFINE_PROP_UINT32("nr", VirtConsole, port.id, VIRTIO_CONSOLE_BAD_ID),
         DEFINE_PROP_CHR("chardev", VirtConsole, chr),
         DEFINE_PROP_STRING("name", VirtConsole, port.name),
diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h
index c0d1717..acf049d 100644
--- a/hw/virtio-serial.h
+++ b/hw/virtio-serial.h
@@ -119,9 +119,6 @@  struct VirtIOSerialPort {
     uint32_t iov_idx;
     uint64_t iov_offset;
 
-    /* For property backward compatibility, not used otherwise */
-    uint8_t is_console_dummy;
-
     /* Is the corresponding guest device open? */
     bool guest_connected;
     /* Is this device open for IO on the host? */