| Message ID | 20180922193631.14369-4-asafka7@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/4] python-pycryptodomex: new package | expand |
Hello, On Sat, 22 Sep 2018 22:36:31 +0300, Asaf Kahlon wrote: > Update dependencies. > License was renamed to LICENSE.rst (no content changed). > Add hash for license. > > Fixes: > http://autobuild.buildroot.org/results/9b3/9b3bcd761aa35d9fdf4acc05258cc87e8c36fb14/ > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> This looks good, but we need to solve the python-cryptodomex licensing question before this patch can be applied. > -PYTHON_PYSNMP_VERSION = 4.3.3 > +PYTHON_PYSNMP_VERSION = 4.4.6 > PYTHON_PYSNMP_SOURCE = pysnmp-$(PYTHON_PYSNMP_VERSION).tar.gz > -PYTHON_PYSNMP_SITE = https://pypi.python.org/packages/47/b5/c65b9b6fcc36d3f4caca30d3314920f1ca75f5ceecc1f6ae2538ede24511 > +PYTHON_PYSNMP_SITE = https://files.pythonhosted.org/packages/8b/66/96a49bf1d64ad1e005a8455644523b7e09663a405eb20a4599fb219e4c95 > PYTHON_PYSNMP_SETUP_TYPE = setuptools > > PYTHON_PYSNMP_LICENSE = BSD-3-Clause > -PYTHON_PYSNMP_LICENSE_FILES = LICENSE.txt > - > -PYTHON_PYSNMP_DEPENDENCIES = python-pyasn python-pycrypto So these were build time dependencies, and now there are no build time dependencies anymore ? Or was it a bug to list them as build time dependencies ? Best regards, Thomas
Hello, On Tue, Oct 9, 2018 at 10:37 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Sat, 22 Sep 2018 22:36:31 +0300, Asaf Kahlon wrote: > > Update dependencies. > > License was renamed to LICENSE.rst (no content changed). > > Add hash for license. > > > > Fixes: > > http://autobuild.buildroot.org/results/9b3/9b3bcd761aa35d9fdf4acc05258cc87e8c36fb14/ > > > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > > This looks good, but we need to solve the python-cryptodomex licensing > question before this patch can be applied. > > > > -PYTHON_PYSNMP_VERSION = 4.3.3 > > +PYTHON_PYSNMP_VERSION = 4.4.6 > > PYTHON_PYSNMP_SOURCE = pysnmp-$(PYTHON_PYSNMP_VERSION).tar.gz > > -PYTHON_PYSNMP_SITE = https://pypi.python.org/packages/47/b5/c65b9b6fcc36d3f4caca30d3314920f1ca75f5ceecc1f6ae2538ede24511 > > +PYTHON_PYSNMP_SITE = https://files.pythonhosted.org/packages/8b/66/96a49bf1d64ad1e005a8455644523b7e09663a405eb20a4599fb219e4c95 > > PYTHON_PYSNMP_SETUP_TYPE = setuptools > > > > PYTHON_PYSNMP_LICENSE = BSD-3-Clause > > -PYTHON_PYSNMP_LICENSE_FILES = LICENSE.txt > > - > > -PYTHON_PYSNMP_DEPENDENCIES = python-pyasn python-pycrypto > > So these were build time dependencies, and now there are no build time > dependencies anymore ? Or was it a bug to list them as build time > dependencies ? > These packages were not needed as runtime dependencies at all. When updating the package dependencies, I also validated that python-pysnmp can be built without them. > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
Hello, On Tue, 9 Oct 2018 22:54:06 +0300, Asaf Kahlon wrote: > > > -PYTHON_PYSNMP_VERSION = 4.3.3 > > > +PYTHON_PYSNMP_VERSION = 4.4.6 > > > PYTHON_PYSNMP_SOURCE = pysnmp-$(PYTHON_PYSNMP_VERSION).tar.gz > > > -PYTHON_PYSNMP_SITE = https://pypi.python.org/packages/47/b5/c65b9b6fcc36d3f4caca30d3314920f1ca75f5ceecc1f6ae2538ede24511 > > > +PYTHON_PYSNMP_SITE = https://files.pythonhosted.org/packages/8b/66/96a49bf1d64ad1e005a8455644523b7e09663a405eb20a4599fb219e4c95 > > > PYTHON_PYSNMP_SETUP_TYPE = setuptools > > > > > > PYTHON_PYSNMP_LICENSE = BSD-3-Clause > > > -PYTHON_PYSNMP_LICENSE_FILES = LICENSE.txt > > > - > > > -PYTHON_PYSNMP_DEPENDENCIES = python-pyasn python-pycrypto > > > > So these were build time dependencies, and now there are no build time > > dependencies anymore ? Or was it a bug to list them as build time > > dependencies ? > > > These packages were not needed as runtime dependencies at all. As *runtime* dependencies, or *build time* dependencies? Thomas
On Tue, Oct 9, 2018, 23:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > Hello, > > On Tue, 9 Oct 2018 22:54:06 +0300, Asaf Kahlon wrote: > > > > > -PYTHON_PYSNMP_VERSION = 4.3.3 > > > > +PYTHON_PYSNMP_VERSION = 4.4.6 > > > > PYTHON_PYSNMP_SOURCE = pysnmp-$(PYTHON_PYSNMP_VERSION).tar.gz > > > > -PYTHON_PYSNMP_SITE = > https://pypi.python.org/packages/47/b5/c65b9b6fcc36d3f4caca30d3314920f1ca75f5ceecc1f6ae2538ede24511 > > > > +PYTHON_PYSNMP_SITE = > https://files.pythonhosted.org/packages/8b/66/96a49bf1d64ad1e005a8455644523b7e09663a405eb20a4599fb219e4c95 > > > > PYTHON_PYSNMP_SETUP_TYPE = setuptools > > > > > > > > PYTHON_PYSNMP_LICENSE = BSD-3-Clause > > > > -PYTHON_PYSNMP_LICENSE_FILES = LICENSE.txt > > > > - > > > > -PYTHON_PYSNMP_DEPENDENCIES = python-pyasn python-pycrypto > > > > > > So these were build time dependencies, and now there are no build time > > > dependencies anymore ? Or was it a bug to list them as build time > > > dependencies ? > > > > > These packages were not needed as runtime dependencies at all. > > As *runtime* dependencies, or *build time* dependencies? > Oh sorry, they are not needed as build time dependencies, of course. > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 9, 2018, 23:00 Thomas Petazzoni <<a href="mailto:thomas.petazzoni@bootlin.com">thomas.petazzoni@bootlin.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br> <br> On Tue, 9 Oct 2018 22:54:06 +0300, Asaf Kahlon wrote:<br> <br> > > > -PYTHON_PYSNMP_VERSION = 4.3.3<br> > > > +PYTHON_PYSNMP_VERSION = 4.4.6<br> > > > PYTHON_PYSNMP_SOURCE = pysnmp-$(PYTHON_PYSNMP_VERSION).tar.gz<br> > > > -PYTHON_PYSNMP_SITE = <a href="https://pypi.python.org/packages/47/b5/c65b9b6fcc36d3f4caca30d3314920f1ca75f5ceecc1f6ae2538ede24511" rel="noreferrer noreferrer" target="_blank">https://pypi.python.org/packages/47/b5/c65b9b6fcc36d3f4caca30d3314920f1ca75f5ceecc1f6ae2538ede24511</a><br> > > > +PYTHON_PYSNMP_SITE = <a href="https://files.pythonhosted.org/packages/8b/66/96a49bf1d64ad1e005a8455644523b7e09663a405eb20a4599fb219e4c95" rel="noreferrer noreferrer" target="_blank">https://files.pythonhosted.org/packages/8b/66/96a49bf1d64ad1e005a8455644523b7e09663a405eb20a4599fb219e4c95</a><br> > > > PYTHON_PYSNMP_SETUP_TYPE = setuptools<br> > > ><br> > > > PYTHON_PYSNMP_LICENSE = BSD-3-Clause<br> > > > -PYTHON_PYSNMP_LICENSE_FILES = LICENSE.txt<br> > > > -<br> > > > -PYTHON_PYSNMP_DEPENDENCIES = python-pyasn python-pycrypto <br> > ><br> > > So these were build time dependencies, and now there are no build time<br> > > dependencies anymore ? Or was it a bug to list them as build time<br> > > dependencies ?<br> > > <br> > These packages were not needed as runtime dependencies at all.<br> <br> As *runtime* dependencies, or *build time* dependencies?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Oh sorry, they are not needed as build time dependencies, of course.</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> Thomas<br> -- <br> Thomas Petazzoni, CTO, Bootlin<br> Embedded Linux and Kernel engineering<br> <a href="https://bootlin.com" rel="noreferrer noreferrer" target="_blank">https://bootlin.com</a><br> </blockquote></div></div></div>
Hello, On Sat, 22 Sep 2018 22:36:31 +0300, Asaf Kahlon wrote: > Update dependencies. > License was renamed to LICENSE.rst (no content changed). > Add hash for license. > > Fixes: > http://autobuild.buildroot.org/results/9b3/9b3bcd761aa35d9fdf4acc05258cc87e8c36fb14/ > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > --- > package/python-pysnmp/Config.in | 9 +++------ > package/python-pysnmp/python-pysnmp.hash | 8 +++++--- > package/python-pysnmp/python-pysnmp.mk | 8 +++----- > 3 files changed, 11 insertions(+), 14 deletions(-) Applied to master, thanks. Hopefully this is the last package that was causing issues with Python 3.7.0. In any case, thanks a lot for all your work in relation to the Python 3.7.0 update, it was much appreciated. Thanks, Thomas
diff --git a/package/python-pysnmp/Config.in b/package/python-pysnmp/Config.in index c7cdf3892d..a034b16852 100644 --- a/package/python-pysnmp/Config.in +++ b/package/python-pysnmp/Config.in @@ -1,13 +1,10 @@ config BR2_PACKAGE_PYTHON_PYSNMP bool "python-pysnmp" - depends on BR2_INSTALL_LIBSTDCPP # pyasn - select BR2_PACKAGE_PYTHON_PYASN - select BR2_PACKAGE_PYTHON_PYCRYPTO + select BR2_PACKAGE_PYTHON_PYSMI # runtime + select BR2_PACKAGE_PYTHON_PYCRYPTODOMEX # runtime + select BR2_PACKAGE_PYTHON_PYASN1 # runtime help PySNMP is a cross-platform, pure-Python SNMP engine implementation. http://pysnmp.sf.net - -comment "python-pysnmp needs a toolchain w/ C++" - depends on !BR2_INSTALL_LIBSTDCPP diff --git a/package/python-pysnmp/python-pysnmp.hash b/package/python-pysnmp/python-pysnmp.hash index 7ecbf4c480..bb5fc24834 100644 --- a/package/python-pysnmp/python-pysnmp.hash +++ b/package/python-pysnmp/python-pysnmp.hash @@ -1,3 +1,5 @@ -# md5 from https://pypi.python.org/pypi/pysnmp/json, sha256 locally computed -md5 cc0838cdf3f2d34539f478942f648384 pysnmp-4.3.3.tar.gz -sha256 c837d35cbb2c1e067b7b8ed752d962481ef8d7ff11e4cdd8bfb0840c4a786318 pysnmp-4.3.3.tar.gz +# md5, sha256 from https://pypi.org/pypi/pysnmp/json +md5 9eaed18907d9b15828f138471b187e8f pysnmp-4.4.6.tar.gz +sha256 e34ffa0dce5f69adabd478ff76c3e1b08e32ebb0767df8b178d0704f4a1ac406 pysnmp-4.4.6.tar.gz +# Locally computed sha256 checksums +sha256 4781cdf5b05a40b8c36f2e71e248dac621762bc8e8482fa5fddab5053e2cdace LICENSE.rst diff --git a/package/python-pysnmp/python-pysnmp.mk b/package/python-pysnmp/python-pysnmp.mk index 2721ba8a7b..0a916119df 100644 --- a/package/python-pysnmp/python-pysnmp.mk +++ b/package/python-pysnmp/python-pysnmp.mk @@ -4,14 +4,12 @@ # ################################################################################ -PYTHON_PYSNMP_VERSION = 4.3.3 +PYTHON_PYSNMP_VERSION = 4.4.6 PYTHON_PYSNMP_SOURCE = pysnmp-$(PYTHON_PYSNMP_VERSION).tar.gz -PYTHON_PYSNMP_SITE = https://pypi.python.org/packages/47/b5/c65b9b6fcc36d3f4caca30d3314920f1ca75f5ceecc1f6ae2538ede24511 +PYTHON_PYSNMP_SITE = https://files.pythonhosted.org/packages/8b/66/96a49bf1d64ad1e005a8455644523b7e09663a405eb20a4599fb219e4c95 PYTHON_PYSNMP_SETUP_TYPE = setuptools PYTHON_PYSNMP_LICENSE = BSD-3-Clause -PYTHON_PYSNMP_LICENSE_FILES = LICENSE.txt - -PYTHON_PYSNMP_DEPENDENCIES = python-pyasn python-pycrypto +PYTHON_PYSNMP_LICENSE_FILES = LICENSE.rst $(eval $(python-package))
Update dependencies. License was renamed to LICENSE.rst (no content changed). Add hash for license. Fixes: http://autobuild.buildroot.org/results/9b3/9b3bcd761aa35d9fdf4acc05258cc87e8c36fb14/ Signed-off-by: Asaf Kahlon <asafka7@gmail.com> --- package/python-pysnmp/Config.in | 9 +++------ package/python-pysnmp/python-pysnmp.hash | 8 +++++--- package/python-pysnmp/python-pysnmp.mk | 8 +++----- 3 files changed, 11 insertions(+), 14 deletions(-)