diff mbox series

[4/4] ARM: dts: r8a77470: Add I2C4 support

Message ID 1537551421-4259-5-git-send-email-fabrizio.castro@bp.renesas.com
State Not Applicable
Headers show
Series Add RZ/G1C and RZ/G1N I2C related support | expand

Commit Message

Fabrizio Castro Sept. 21, 2018, 5:37 p.m. UTC 
Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
device tree.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm/boot/dts/r8a77470.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Wolfram Sang Sept. 22, 2018, 6:39 p.m. UTC | #1 
On Fri, Sep 21, 2018 at 06:37:01PM +0100, Fabrizio Castro wrote:
> Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> device tree.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Looks sane to me

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Simon Horman Sept. 24, 2018, 9:04 a.m. UTC | #2 
On Sat, Sep 22, 2018 at 08:39:29PM +0200, Wolfram Sang wrote:
> On Fri, Sep 21, 2018 at 06:37:01PM +0100, Fabrizio Castro wrote:
> > Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> > device tree.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> 
> Looks sane to me
> 
> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Likewise, but I'd like some feedback on my comment on patch 1/4
before applying this.
Geert Uytterhoeven Sept. 24, 2018, 9:58 a.m. UTC | #3 
On Fri, Sep 21, 2018 at 7:37 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> device tree.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index 9e7f86d..9ec78d3 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -237,6 +237,20 @@ 
 			reg = <0 0xe6300000 0 0x20000>;
 		};
 
+		i2c4: i2c@e6520000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a77470",
+				     "renesas,rcar-gen2-i2c";
+			reg = <0 0xe6520000 0 0x40>;
+			interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 927>;
+			power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+			resets = <&cpg 927>;
+			i2c-scl-internal-delay-ns = <6>;
+			status = "disabled";
+		};
+
 		dmac0: dma-controller@e6700000 {
 			compatible = "renesas,dmac-r8a77470",
 				     "renesas,rcar-dmac";