diff mbox series

witherspoon: Rename shared slot fixup function

Message ID 20180921024230.3191-1-oohall@gmail.com
State Accepted
Headers show
Series witherspoon: Rename shared slot fixup function | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied
snowpatch_ozlabs/make_check success Test make_check on branch master

Commit Message

Oliver O'Halloran Sept. 21, 2018, 2:42 a.m. UTC 
Rename and set it as a pre_pci_fixup platform function. The indirect
call doesn't make a whole of of sense IMO.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
 platforms/astbmc/witherspoon.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Stewart Smith Sept. 27, 2018, 7:14 a.m. UTC | #1 
"Oliver O'Halloran" <oohall@gmail.com> writes:
> Rename and set it as a pre_pci_fixup platform function. The indirect
> call doesn't make a whole of of sense IMO.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
>  platforms/astbmc/witherspoon.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

Thanks, merged to master as of 1355c312c3082841eae58726cd0c44ed760dde97
diff mbox series

Patch

diff --git a/platforms/astbmc/witherspoon.c b/platforms/astbmc/witherspoon.c
index de087045542c..0b5590671da6 100644
--- a/platforms/astbmc/witherspoon.c
+++ b/platforms/astbmc/witherspoon.c
@@ -142,7 +142,7 @@  static void phb4_activate_shared_slot_witherspoon(struct proc_chip *chip)
 	prlog(PR_INFO, "Shared PCI slot activated\n");
 }
 
-static void phb4_pre_pci_fixup_witherspoon(void)
+static void witherspoon_shared_slot_fixup(void)
 {
 	struct pci_slot *slot0, *slot1;
 	struct proc_chip *chip0, *chip1;
@@ -204,11 +204,6 @@  static void phb4_pre_pci_fixup_witherspoon(void)
 	}
 }
 
-static void witherspoon_pre_pci_fixup(void)
-{
-	phb4_pre_pci_fixup_witherspoon();
-}
-
 static void set_link_details(struct npu2 *npu, uint32_t link_index,
 			     uint32_t brick_index, enum npu2_dev_type type)
 {
@@ -356,7 +351,7 @@  DECLARE_PLATFORM(witherspoon) = {
 	.name			= "Witherspoon",
 	.probe			= witherspoon_probe,
 	.init			= astbmc_init,
-	.pre_pci_fixup		= witherspoon_pre_pci_fixup,
+	.pre_pci_fixup		= witherspoon_shared_slot_fixup,
 	.start_preload_resource	= flash_start_preload_resource,
 	.resource_loaded	= flash_resource_loaded,
 	.bmc			= &astbmc_openbmc,