| Message ID | 1537449899-9576-13-git-send-email-matthew.weber@rockwellcollins.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [01/14] support/scripts/pkg-stats: URL checking support | expand |
Hello, On Thu, 20 Sep 2018 08:24:58 -0500, Matt Weber wrote: > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> > --- > package/alljoyn-base/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/alljoyn-base/Config.in b/package/alljoyn-base/Config.in > index 8556d66..c89cb20 100644 > --- a/package/alljoyn-base/Config.in > +++ b/package/alljoyn-base/Config.in > @@ -17,7 +17,7 @@ config BR2_PACKAGE_ALLJOYN_BASE > devices, providing a set of interfaces for different devices > to interact and interoperate with one another. > > - https://allseenalliance.org > + https://github.com/alljoyn/alljoyn.github.com/wiki For PATCH 13/14 (this one) and PATCH 14/14, I'd like something a bit better: - The .mk files still use a mirror of allseenalliance at kernel.org, it should be changed to use the Github location instead. - You changed alljoyn-base and alljoyn-tcl-base, but not alljoyn-tcl - The commit title should be "update upstream URL" - The commit log should contain some details, at least explaining that allseenalliance.org is dead, and that the project was moved to Github, etc. Thanks, Thomas
Thomas/Fabrice, On Thu, Sep 20, 2018 at 3:05 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Thu, 20 Sep 2018 08:24:58 -0500, Matt Weber wrote: > > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> > > --- > > package/alljoyn-base/Config.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/package/alljoyn-base/Config.in b/package/alljoyn-base/Config.in > > index 8556d66..c89cb20 100644 > > --- a/package/alljoyn-base/Config.in > > +++ b/package/alljoyn-base/Config.in > > @@ -17,7 +17,7 @@ config BR2_PACKAGE_ALLJOYN_BASE > > devices, providing a set of interfaces for different devices > > to interact and interoperate with one another. > > > > - https://allseenalliance.org > > + https://github.com/alljoyn/alljoyn.github.com/wiki > > For PATCH 13/14 (this one) and PATCH 14/14, I'd like something a bit > better: > > - The .mk files still use a mirror of allseenalliance at kernel.org, > it should be changed to use the Github location instead. I don't have a good use case to runtime test making this change. I can make it an verified the build is still good. > > - You changed alljoyn-base and alljoyn-tcl-base, but not alljoyn-tcl I'll have to check, my script may have a bug. My grep is coming back showing I missed the plain alljoyn too. alljoyn-base https://github.com/alljoyn/alljoyn.github.com/wiki alljoyn https://allseenalliance.org alljoyn-tcl-base https://github.com/alljoyn/alljoyn.github.com/wiki alljoyn-tcl https://allseenalliance.org > > - The commit title should be "update upstream URL" Noted. > > - The commit log should contain some details, at least explaining that > allseenalliance.org is dead, and that the project was moved to > Github, etc. Sure, I'm not to familiar with this one but I can at least state that. Matt
Hello, On Thu, 20 Sep 2018 15:44:54 -0500, Matthew Weber wrote: > > - The .mk files still use a mirror of allseenalliance at kernel.org, > > it should be changed to use the Github location instead. > > I don't have a good use case to runtime test making this change. I > can make it an verified the build is still good. I think we should try to keep using the same versions (we use 16.04, and I saw it was available on Github as well), and preferably try to diff the source code between the old upstream and the new upstream. If the code is reasonably similar, then build testing should be sufficient. Thomas
diff --git a/package/alljoyn-base/Config.in b/package/alljoyn-base/Config.in index 8556d66..c89cb20 100644 --- a/package/alljoyn-base/Config.in +++ b/package/alljoyn-base/Config.in @@ -17,7 +17,7 @@ config BR2_PACKAGE_ALLJOYN_BASE devices, providing a set of interfaces for different devices to interact and interoperate with one another. - https://allseenalliance.org + https://github.com/alljoyn/alljoyn.github.com/wiki if BR2_PACKAGE_ALLJOYN_BASE
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> --- package/alljoyn-base/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)