| Message ID | 1537449899-9576-10-git-send-email-matthew.weber@rockwellcollins.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [01/14] support/scripts/pkg-stats: URL checking support | expand |
Hello, On Thu, 20 Sep 2018 08:24:55 -0500, Matt Weber wrote: > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> > --- > package/glibc/Config.in | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/glibc/Config.in b/package/glibc/Config.in > index 57a2e83..63dd0f4 100644 > --- a/package/glibc/Config.in > +++ b/package/glibc/Config.in > @@ -5,5 +5,6 @@ config BR2_PACKAGE_GLIBC > default y > select BR2_PACKAGE_LINUX_HEADERS > select BR2_TOOLCHAIN_HAS_SSP > - > + help > + https://www.gnu.org/software/libc/ This option is a blind option, so having a help text is not very useful... Thomas
Thomas, On Thu, Sep 20, 2018 at 2:30 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Thu, 20 Sep 2018 08:24:55 -0500, Matt Weber wrote: > > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> > > --- > > package/glibc/Config.in | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/package/glibc/Config.in b/package/glibc/Config.in > > index 57a2e83..63dd0f4 100644 > > --- a/package/glibc/Config.in > > +++ b/package/glibc/Config.in > > @@ -5,5 +5,6 @@ config BR2_PACKAGE_GLIBC > > default y > > select BR2_PACKAGE_LINUX_HEADERS > > select BR2_TOOLCHAIN_HAS_SSP > > - > > + help > > + https://www.gnu.org/software/libc/ > > This option is a blind option, so having a help text is not very > useful... I had been looking at verifying and updating all packages which could end-up with content on target to have a valid URL. This allows auto-generation of CPE XML update requests which need product site urls. Matt
Hello, On Thu, 20 Sep 2018 15:05:46 -0500, Matthew Weber wrote: > > This option is a blind option, so having a help text is not very > > useful... > > I had been looking at verifying and updating all packages which could > end-up with content on target to have a valid URL. This allows > auto-generation of CPE XML update requests which need product site > urls. Then perhaps this should be explained in the commit log, specifically for glibc. But are you sure your approach is the right one ? Today only target packages have a Config.in file. What are you going to do for host packages ? You don't care because they are host packages and supposedly not relevant for security issues on the target ? Thomas
Thomas, On Thu, Sep 20, 2018 at 3:17 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Thu, 20 Sep 2018 15:05:46 -0500, Matthew Weber wrote: > > > > This option is a blind option, so having a help text is not very > > > useful... > > > > I had been looking at verifying and updating all packages which could > > end-up with content on target to have a valid URL. This allows > > auto-generation of CPE XML update requests which need product site > > urls. > > Then perhaps this should be explained in the commit log, specifically > for glibc. > Yes, agree. > But are you sure your approach is the right one ? Today only target > packages have a Config.in file. What are you going to do for host > packages ? Currently the xml generation was a best effort and the cpe reporting was only done against target CPE so far..... Glad to discuss suggestions for a better way vs hand updating the xml with this URL info. > You don't care because they are host packages and supposedly > not relevant for security issues on the target ? I know better then to say that host packages don't matter :-) We took the most accessible path first and that was to get good coverage on target packages. Maybe a good topic for next month? I should have an updated CPE patchset out in the next week. Matt
diff --git a/package/glibc/Config.in b/package/glibc/Config.in index 57a2e83..63dd0f4 100644 --- a/package/glibc/Config.in +++ b/package/glibc/Config.in @@ -5,5 +5,6 @@ config BR2_PACKAGE_GLIBC default y select BR2_PACKAGE_LINUX_HEADERS select BR2_TOOLCHAIN_HAS_SSP - + help + https://www.gnu.org/software/libc/ endif
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> --- package/glibc/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)