| Message ID | 1537449899-9576-2-git-send-email-matthew.weber@rockwellcollins.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [01/14] support/scripts/pkg-stats: URL checking support | expand |
Hello, On Thu, 20 Sep 2018 08:24:47 -0500, Matt Weber wrote: > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> > --- > boot/at91bootstrap/Config.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/boot/at91bootstrap/Config.in b/boot/at91bootstrap/Config.in > index 0f6430f..3d649b1 100644 > --- a/boot/at91bootstrap/Config.in > +++ b/boot/at91bootstrap/Config.in > @@ -10,6 +10,8 @@ config BR2_TARGET_AT91BOOTSTRAP > - Physical media algorithm such as DataFlash, NandFlash, NOR > Flash... > > + https://www.at91.com/linux4sam/bin/view/Linux4SAM/LegacyAT91Bootstrap Actually, this one should use: https://www.at91.com/linux4sam/bin/view/Linux4SAM/LegacyAT91Bootstrap which you have used for at91dataflashboot, but at91dataflashboot is a different thing, which no longer has any upstream location. Perhaps your script should support a way of specifying "yeah, there is no upstream location" in an explicit way. Best regards, Thomas
On Thu, Sep 20, 2018 at 3:13 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Thu, 20 Sep 2018 08:24:47 -0500, Matt Weber wrote: > > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> > > --- > > boot/at91bootstrap/Config.in | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/boot/at91bootstrap/Config.in b/boot/at91bootstrap/Config.in > > index 0f6430f..3d649b1 100644 > > --- a/boot/at91bootstrap/Config.in > > +++ b/boot/at91bootstrap/Config.in > > @@ -10,6 +10,8 @@ config BR2_TARGET_AT91BOOTSTRAP > > - Physical media algorithm such as DataFlash, NandFlash, NOR > > Flash... > > > > + https://www.at91.com/linux4sam/bin/view/Linux4SAM/LegacyAT91Bootstrap > > Actually, this one should use: > > https://www.at91.com/linux4sam/bin/view/Linux4SAM/LegacyAT91Bootstrap > Ok so this patch is ok then and for the at91dataflashboot I found it mentioned on the same legacy page but it definitely is a weak reference. > which you have used for at91dataflashboot, but at91dataflashboot is a > different thing, which no longer has any upstream location. > > Perhaps your script should support a way of specifying "yeah, there is > no upstream location" in an explicit way. Is that maybe a string we put in the end of the help section? "No Upstream URL" Matt
Hello, On Thu, 20 Sep 2018 15:35:14 -0500, Matthew Weber wrote: > > > diff --git a/boot/at91bootstrap/Config.in b/boot/at91bootstrap/Config.in > > > index 0f6430f..3d649b1 100644 > > > --- a/boot/at91bootstrap/Config.in > > > +++ b/boot/at91bootstrap/Config.in > > > @@ -10,6 +10,8 @@ config BR2_TARGET_AT91BOOTSTRAP > > > - Physical media algorithm such as DataFlash, NandFlash, NOR > > > Flash... > > > > > > + https://www.at91.com/linux4sam/bin/view/Linux4SAM/LegacyAT91Bootstrap > > > > Actually, this one should use: > > > > https://www.at91.com/linux4sam/bin/view/Linux4SAM/LegacyAT91Bootstrap > > > > Ok so this patch is ok then Ah, yes, my bad, sorry :-/ > and for the at91dataflashboot I found it mentioned on the same legacy > page but it definitely is a weak reference. I sent an e-mail to Atmel^WMicrochip people about at91dataflashboot, we'll see what they have to say. > > Perhaps your script should support a way of specifying "yeah, there > > is no upstream location" in an explicit way. > > Is that maybe a string we put in the end of the help section? "No > Upstream URL" Yes, I was thinking about something like that. Thomas
diff --git a/boot/at91bootstrap/Config.in b/boot/at91bootstrap/Config.in index 0f6430f..3d649b1 100644 --- a/boot/at91bootstrap/Config.in +++ b/boot/at91bootstrap/Config.in @@ -10,6 +10,8 @@ config BR2_TARGET_AT91BOOTSTRAP - Physical media algorithm such as DataFlash, NandFlash, NOR Flash... + https://www.at91.com/linux4sam/bin/view/Linux4SAM/LegacyAT91Bootstrap + if BR2_TARGET_AT91BOOTSTRAP config BR2_TARGET_AT91BOOTSTRAP_CUSTOM_PATCH_DIR
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> --- boot/at91bootstrap/Config.in | 2 ++ 1 file changed, 2 insertions(+)