diff mbox series

smc: generic netlink family should be __ro_after_init

Message ID 20180920072730.17584-1-johannes@sipsolutions.net
State Accepted, archived
Delegated to: David Miller
Headers show
Series smc: generic netlink family should be __ro_after_init | expand

Commit Message

Johannes Berg Sept. 20, 2018, 7:27 a.m. UTC 
From: Johannes Berg <johannes.berg@intel.com>

The generic netlink family is only initialized during module init,
so it should be __ro_after_init like all other generic netlink
families.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 net/smc/smc_pnet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Sept. 20, 2018, 2:50 p.m. UTC | #1 
From: Johannes Berg <johannes@sipsolutions.net>
Date: Thu, 20 Sep 2018 09:27:30 +0200

> From: Johannes Berg <johannes.berg@intel.com>
> 
> The generic netlink family is only initialized during module init,
> so it should be __ro_after_init like all other generic netlink
> families.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Looks good, applied.
diff mbox series

Patch

diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c
index 01c6ce042a1c..7cb3e4f07c10 100644
--- a/net/smc/smc_pnet.c
+++ b/net/smc/smc_pnet.c
@@ -461,7 +461,7 @@  static const struct genl_ops smc_pnet_ops[] = {
 };
 
 /* SMC_PNETID family definition */
-static struct genl_family smc_pnet_nl_family = {
+static struct genl_family smc_pnet_nl_family __ro_after_init = {
 	.hdrsize = 0,
 	.name = SMCR_GENL_FAMILY_NAME,
 	.version = SMCR_GENL_FAMILY_VERSION,