| Message ID | 1537408565-22315-1-git-send-email-zhongjiang@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: toshiba: remove a redundant local variable 'index_specified' | expand |
From: zhong jiang <zhongjiang@huawei.com> Date: Thu, 20 Sep 2018 09:56:05 +0800 > The local variable 'index_specified' is never used after being assigned. > hence it should be redundant adn can be removed. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Applied.
On 9/20/2018 4:56 AM, zhong jiang wrote: > The local variable 'index_specified' is never used after being assigned. > hence it should be redundant adn can be removed. s/adn/and/. > Signed-off-by: zhong jiang <zhongjiang@huawei.com> [...] MBR, Sergei
On 2018/9/20 18:23, Sergei Shtylyov wrote: > On 9/20/2018 4:56 AM, zhong jiang wrote: > >> The local variable 'index_specified' is never used after being assigned. >> hence it should be redundant adn can be removed. > > s/adn/and/. > Spelling mistake. Thanks, checkpatch.pl can not find this. :-[ . I will be appreaciated that David help me correct that. Sincerely, zhong jiang >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> > [...] > > MBR, Sergei > > >
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c index 302079e..00ab417 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c @@ -1094,7 +1094,7 @@ static int gelic_wl_get_encode(struct net_device *netdev, struct gelic_wl_info *wl = port_wl(netdev_priv(netdev)); struct iw_point *enc = &data->encoding; unsigned long irqflag; - unsigned int key_index, index_specified; + unsigned int key_index; int ret = 0; pr_debug("%s: <-\n", __func__); @@ -1105,13 +1105,10 @@ static int gelic_wl_get_encode(struct net_device *netdev, return -EINVAL; spin_lock_irqsave(&wl->lock, irqflag); - if (key_index) { - index_specified = 1; + if (key_index) key_index--; - } else { - index_specified = 0; + else key_index = wl->current_key; - } if (wl->group_cipher_method == GELIC_WL_CIPHER_WEP) { switch (wl->auth_method) {
The local variable 'index_specified' is never used after being assigned. hence it should be redundant adn can be removed. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)