From patchwork Wed Sep 19 22:46:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 971979 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-95972-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="pWJpqmWK"; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="aaQDwkUE"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42Fw2t5FTPz9sBj for ; Thu, 20 Sep 2018 08:46:46 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id; q=dns; s= default; b=v1Z69RSvXPN91cBw7r8gVgXkw06HadDhs+BGbf1Irju7JgKWD2smy 4iCfpVlMrK4E8Ib9/nIEqn7oRkasov/55n6LYeseT0k5o4/S4dSin2pqFAixQ/RJ mjkl2FZVQXhhph/51Cx9e3FyhqBwtBgYVjanJzdUfaNZ6mOZ2RQinw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id; s=default; bh=rFsCAVbxyM5+adVkwzzSRGI78qE=; b=pWJpqmWKtzek8h6qEMOb4kbCu6v8 j+T4Zfalfz1VlfpL31QoHSmoOYNEpuM8XBfHRr916fdk8Y4SJbr4CORx1MehQkB9 C7TT7xA91pgssoyxMtOlpBtnTGUkNhLm7P1O5Q86jugxOK1Jip/3oTjpMd17QWVA cOQ/9Gd9eYYV6U4= Received: (qmail 90028 invoked by alias); 19 Sep 2018 22:46:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 90016 invoked by uid 89); 19 Sep 2018 22:46:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS, UNSUBSCRIBE_BODY, URIBL_DBL_ABUSE_MALW autolearn=ham version=3.3.2 spammy=HX-Received:sk:36-v6mr, name1, 1735, HX-Received:127 X-HELO: mail-pl1-f182.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=kskhq7ShE2AVG1GPSnBdm6fwXdD6L81sl6aPd91NH/8=; b=aaQDwkUE3dzXFWJoMEj5u/Z5jYDum/7LDBzSpZqSTics7oycJIPkGb9b3JZ5VoPjU9 dxf9C1sNo0FHvsOJw+sfNnYco/fEGAIyAIg5p3MrnRoo5NXInPbVCtpy1FdPRwaEgtVM hq8Bfsd4c8DkRwUE+cHJ1jd413mMX8R0N1JC4= From: adhemerval.zanella@linaro.org To: libc-alpha@sourceware.org Cc: Adhemerval Zanella Subject: [PATCH 1/2] Use libsupport for tst-spawn.c Date: Wed, 19 Sep 2018 15:46:23 -0700 Message-Id: <20180919224624.3920-1-adhemerval.zanella@linaro.org> From: Adhemerval Zanella No function changes is done. Checked on x86_64-linux-gnu. * posix/tst-spawn.c (do_prepare, handle_restart, do_test): Use libsupport. --- ChangeLog | 5 ++ posix/tst-spawn.c | 212 ++++++++++++++++++++-------------------------- 2 files changed, 95 insertions(+), 122 deletions(-) diff --git a/posix/tst-spawn.c b/posix/tst-spawn.c index 7c785c430c..638ba1ba55 100644 --- a/posix/tst-spawn.c +++ b/posix/tst-spawn.c @@ -17,35 +17,25 @@ License along with the GNU C Library; if not, see . */ +#include +#include #include #include #include #include #include #include -#include #include #include #include - +#include /* Nonzero if the program gets called via `exec'. */ static int restart; - #define CMDLINE_OPTIONS \ { "restart", no_argument, &restart, 1 }, -/* Prototype for our test function. */ -extern void do_prepare (int argc, char *argv[]); -extern int do_test (int argc, char *argv[]); - -/* We have a preparation function. */ -#define PREPARE do_prepare - -#include "../test-skeleton.c" - - /* Name of the temporary files. */ static char *name1; static char *name2; @@ -63,20 +53,18 @@ static const char fd3string[] = "This file will be opened"; /* We have a preparation function. */ -void +static void do_prepare (int argc, char *argv[]) { /* We must not open any files in the restart case. */ if (restart) return; - temp_fd1 = create_temp_file ("spawn", &name1); - temp_fd2 = create_temp_file ("spawn", &name2); - temp_fd3 = create_temp_file ("spawn", &name3); - if (temp_fd1 < 0 || temp_fd2 < 0 || temp_fd3 < 0) - exit (1); + TEST_VERIFY_EXIT ((temp_fd1 = create_temp_file ("spawn", &name1)) != -1); + TEST_VERIFY_EXIT ((temp_fd2 = create_temp_file ("spawn", &name2)) != -1); + TEST_VERIFY_EXIT ((temp_fd3 = create_temp_file ("spawn", &name3)) != -1); } - +#define PREPARE do_prepare static int handle_restart (const char *fd1s, const char *fd2s, const char *fd3s, @@ -95,64 +83,44 @@ handle_restart (const char *fd1s, const char *fd2s, const char *fd3s, fd4 = atol (fd4s); /* Sanity check. */ - if (fd1 == fd2) - error (EXIT_FAILURE, 0, "value of fd1 and fd2 is the same"); - if (fd1 == fd3) - error (EXIT_FAILURE, 0, "value of fd1 and fd3 is the same"); - if (fd1 == fd4) - error (EXIT_FAILURE, 0, "value of fd1 and fd4 is the same"); - if (fd2 == fd3) - error (EXIT_FAILURE, 0, "value of fd2 and fd3 is the same"); - if (fd2 == fd4) - error (EXIT_FAILURE, 0, "value of fd2 and fd4 is the same"); - if (fd3 == fd4) - error (EXIT_FAILURE, 0, "value of fd3 and fd4 is the same"); + TEST_VERIFY_EXIT (fd1 != fd2); + TEST_VERIFY_EXIT (fd1 != fd3); + TEST_VERIFY_EXIT (fd1 != fd4); + TEST_VERIFY_EXIT (fd2 != fd3); + TEST_VERIFY_EXIT (fd2 != fd4); + TEST_VERIFY_EXIT (fd3 != fd4); /* First the easy part: read from the file descriptor which is supposed to be open. */ - if (lseek (fd2, 0, SEEK_CUR) != strlen (fd2string)) - error (EXIT_FAILURE, errno, "file 2 not in right position"); + TEST_VERIFY_EXIT (lseek (fd2, 0, SEEK_CUR) == strlen (fd2string)); /* The duped descriptor must have the same position. */ - if (lseek (fd4, 0, SEEK_CUR) != strlen (fd2string)) - error (EXIT_FAILURE, errno, "file 4 not in right position"); - if (lseek (fd2, 0, SEEK_SET) != 0) - error (EXIT_FAILURE, 0, "cannot reset position in file 2"); - if (lseek (fd4, 0, SEEK_CUR) != 0) - error (EXIT_FAILURE, errno, "file 4 not set back, too"); - if (read (fd2, buf, sizeof buf) != strlen (fd2string)) - error (EXIT_FAILURE, 0, "cannot read file 2"); - if (memcmp (fd2string, buf, strlen (fd2string)) != 0) - error (EXIT_FAILURE, 0, "file 2 does not match"); + TEST_VERIFY_EXIT (lseek (fd4, 0, SEEK_CUR) == strlen (fd2string)); + TEST_VERIFY_EXIT (lseek (fd2, 0, SEEK_SET) == 0); + TEST_VERIFY_EXIT (lseek (fd4, 0, SEEK_CUR) == 0); + TEST_VERIFY_EXIT (read (fd2, buf, sizeof buf) == strlen (fd2string)); + TEST_VERIFY_EXIT (memcmp (fd2string, buf, strlen (fd2string)) == 0); /* Now read from the third file. */ - if (read (fd3, buf, sizeof buf) != strlen (fd3string)) - error (EXIT_FAILURE, 0, "cannot read file 3"); - if (memcmp (fd3string, buf, strlen (fd3string)) != 0) - error (EXIT_FAILURE, 0, "file 3 does not match"); + TEST_VERIFY_EXIT (read (fd3, buf, sizeof buf) == strlen (fd3string)); + TEST_VERIFY_EXIT (memcmp (fd3string, buf, strlen (fd3string)) == 0); /* Try to write to the file. This should not be allowed. */ - if (write (fd3, "boo!", 4) != -1 || errno != EBADF) - error (EXIT_FAILURE, 0, "file 3 is writable"); + TEST_VERIFY_EXIT (write (fd3, "boo!", 4) == -1 && errno == EBADF); /* Now try to read the first file. First make sure it is not opened. */ - if (lseek (fd1, 0, SEEK_CUR) != (off_t) -1 || errno != EBADF) - error (EXIT_FAILURE, 0, "file 1 (%d) is not closed", fd1); + TEST_VERIFY_EXIT (lseek (fd1, 0, SEEK_CUR) == (off_t) -1 + && errno == EBADF); /* Now open the file and read it. */ - fd1 = open (name, O_RDONLY); - if (fd1 == -1) - error (EXIT_FAILURE, errno, - "cannot open first file \"%s\" for verification", name); + TEST_VERIFY_EXIT ((fd1 = open (name, O_RDONLY)) != -1); - if (read (fd1, buf, sizeof buf) != strlen (fd1string)) - error (EXIT_FAILURE, errno, "cannot read file 1"); - if (memcmp (fd1string, buf, strlen (fd1string)) != 0) - error (EXIT_FAILURE, 0, "file 1 does not match"); + TEST_VERIFY_EXIT (read (fd1, buf, sizeof buf) == strlen (fd1string)); + TEST_VERIFY_EXIT (memcmp (fd1string, buf, strlen (fd1string)) == 0); return 0; } -int +static int do_test (int argc, char *argv[]) { pid_t pid; @@ -181,7 +149,7 @@ do_test (int argc, char *argv[]) + the name of the closed descriptor */ if (argc != (restart ? 6 : 2) && argc != (restart ? 6 : 5)) - error (EXIT_FAILURE, 0, "wrong number of arguments (%d)", argc); + FAIL_EXIT1 ("wrong number of arguments (%d)", argc); if (restart) return handle_restart (argv[1], argv[2], argv[3], argv[4], argv[5]); @@ -189,66 +157,63 @@ do_test (int argc, char *argv[]) /* Prepare the test. We are creating two files: one which file descriptor will be marked with FD_CLOEXEC, another which is not. */ - /* Write something in the files. */ - if (write (temp_fd1, fd1string, strlen (fd1string)) != strlen (fd1string)) - error (EXIT_FAILURE, errno, "cannot write to first file"); - if (write (temp_fd2, fd2string, strlen (fd2string)) != strlen (fd2string)) - error (EXIT_FAILURE, errno, "cannot write to second file"); - if (write (temp_fd3, fd3string, strlen (fd3string)) != strlen (fd3string)) - error (EXIT_FAILURE, errno, "cannot write to third file"); - - /* Close the third file. It'll be opened by `spawn'. */ - close (temp_fd3); - - /* Tell `spawn' what to do. */ - if (posix_spawn_file_actions_init (&actions) != 0) - error (EXIT_FAILURE, errno, "posix_spawn_file_actions_init"); - /* Close `temp_fd1'. */ - if (posix_spawn_file_actions_addclose (&actions, temp_fd1) != 0) - error (EXIT_FAILURE, errno, "posix_spawn_file_actions_addclose"); - /* We want to open the third file. */ - name3_copy = strdup (name3); - if (name3_copy == NULL) - error (EXIT_FAILURE, errno, "strdup"); - if (posix_spawn_file_actions_addopen (&actions, temp_fd3, name3_copy, - O_RDONLY, 0666) != 0) - error (EXIT_FAILURE, errno, "posix_spawn_file_actions_addopen"); - /* Overwrite the name to check that a copy has been made. */ - memset (name3_copy, 'X', strlen (name3_copy)); - - /* We dup the second descriptor. */ - fd4 = MAX (2, MAX (temp_fd1, MAX (temp_fd2, temp_fd3))) + 1; - if (posix_spawn_file_actions_adddup2 (&actions, temp_fd2, fd4) != 0) - error (EXIT_FAILURE, errno, "posix_spawn_file_actions_adddup2"); - - /* Now spawn the process. */ - snprintf (fd1name, sizeof fd1name, "%d", temp_fd1); - snprintf (fd2name, sizeof fd2name, "%d", temp_fd2); - snprintf (fd3name, sizeof fd3name, "%d", temp_fd3); - snprintf (fd4name, sizeof fd4name, "%d", fd4); - - for (i = 0; i < (argc == (restart ? 6 : 5) ? 4 : 1); i++) - spargv[i] = argv[i + 1]; - spargv[i++] = (char *) "--direct"; - spargv[i++] = (char *) "--restart"; - spargv[i++] = fd1name; - spargv[i++] = fd2name; - spargv[i++] = fd3name; - spargv[i++] = fd4name; - spargv[i++] = name1; - spargv[i] = NULL; - - if (posix_spawn (&pid, argv[1], &actions, NULL, spargv, environ) != 0) - error (EXIT_FAILURE, errno, "posix_spawn"); - - /* Same test but with a NULL pid argument. */ - if (posix_spawn (NULL, argv[1], &actions, NULL, spargv, environ) != 0) - error (EXIT_FAILURE, errno, "posix_spawn"); - - /* Cleanup. */ - if (posix_spawn_file_actions_destroy (&actions) != 0) - error (EXIT_FAILURE, errno, "posix_spawn_file_actions_destroy"); - free (name3_copy); + /* Write something in the files. */ + TEST_VERIFY_EXIT (write (temp_fd1, fd1string, strlen (fd1string)) + == strlen (fd1string)); + TEST_VERIFY_EXIT (write (temp_fd2, fd2string, strlen (fd2string)) + == strlen (fd2string)); + TEST_VERIFY_EXIT (write (temp_fd3, fd3string, strlen (fd3string)) + == strlen (fd3string)); + + /* Close the third file. It'll be opened by `spawn'. */ + close (temp_fd3); + + /* Tell `spawn' what to do. */ + TEST_VERIFY_EXIT (posix_spawn_file_actions_init (&actions) == 0); + /* Close `temp_fd1'. */ + TEST_VERIFY_EXIT (posix_spawn_file_actions_addclose (&actions, temp_fd1) + == 0); + /* We want to open the third file. */ + TEST_VERIFY_EXIT ((name3_copy = strdup (name3)) != NULL); + TEST_VERIFY_EXIT (posix_spawn_file_actions_addopen (&actions, temp_fd3, + name3_copy, + O_RDONLY, 0666) + == 0); + /* Overwrite the name to check that a copy has been made. */ + memset (name3_copy, 'X', strlen (name3_copy)); + + /* We dup the second descriptor. */ + fd4 = MAX (2, MAX (temp_fd1, MAX (temp_fd2, temp_fd3))) + 1; + TEST_VERIFY_EXIT (posix_spawn_file_actions_adddup2 (&actions, temp_fd2, + fd4) == 0); + + /* Now spawn the process. */ + snprintf (fd1name, sizeof fd1name, "%d", temp_fd1); + snprintf (fd2name, sizeof fd2name, "%d", temp_fd2); + snprintf (fd3name, sizeof fd3name, "%d", temp_fd3); + snprintf (fd4name, sizeof fd4name, "%d", fd4); + + for (i = 0; i < (argc == (restart ? 6 : 5) ? 4 : 1); i++) + spargv[i] = argv[i + 1]; + spargv[i++] = (char *) "--direct"; + spargv[i++] = (char *) "--restart"; + spargv[i++] = fd1name; + spargv[i++] = fd2name; + spargv[i++] = fd3name; + spargv[i++] = fd4name; + spargv[i++] = name1; + spargv[i] = NULL; + + TEST_VERIFY_EXIT (posix_spawn (&pid, argv[1], &actions, NULL, spargv, + environ) == 0); + + /* Same test but with a NULL pid argument. */ + TEST_VERIFY_EXIT (posix_spawn (NULL, argv[1], &actions, NULL, spargv, + environ) == 0); + + /* Cleanup. */ + TEST_VERIFY_EXIT (posix_spawn_file_actions_destroy (&actions) == 0); + free (name3_copy); /* Wait for the children. */ TEST_VERIFY (xwaitpid (pid, &status, 0) == pid); @@ -263,3 +228,6 @@ do_test (int argc, char *argv[]) return 0; } + +#define TEST_FUNCTION_ARGV do_test +#include