diff mbox series

[U-Boot,v1,03/13] dts: db410c: add alias for USB

Message ID 20180919182821.19575-4-ramon.fried@gmail.com
State Superseded
Delegated to: Tom Rini
Headers show
Series Introduce fastboot support for dragonboard410c | expand

Commit Message

Ramon Fried Sept. 19, 2018, 6:28 p.m. UTC
Alias is required so req-seq will be filled.

Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
---

 arch/arm/dts/dragonboard410c.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Peter Robinson Sept. 19, 2018, 7:28 p.m. UTC | #1
This should go into a -u-boot.dtsi file so that the
dragonboard410c.dts can be synced from the linux kernel without
change.

Peter

On Wed, Sep 19, 2018 at 7:31 PM Ramon Fried <ramon.fried@gmail.com> wrote:
>
> Alias is required so req-seq will be filled.
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
> ---
>
>  arch/arm/dts/dragonboard410c.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/dragonboard410c.dts b/arch/arm/dts/dragonboard410c.dts
> index f4f7c350ec..75f28300b7 100644
> --- a/arch/arm/dts/dragonboard410c.dts
> +++ b/arch/arm/dts/dragonboard410c.dts
> @@ -18,6 +18,10 @@
>         #address-cells = <0x2>;
>         #size-cells = <0x2>;
>
> +       aliases {
> +               usb0 = "/soc/ehci@78d9000";
> +       };
> +
>         memory {
>                 device_type = "memory";
>                 reg = <0 0x80000000 0 0x3da00000>;
> --
> 2.18.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Ramon Fried Sept. 19, 2018, 7:32 p.m. UTC | #2
On Wed, Sep 19, 2018 at 10:28 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> This should go into a -u-boot.dtsi file so that the
> dragonboard410c.dts can be synced from the linux kernel without
> change.
>
Hi Peter.
I thought that -u-boot.dtsi is only for u-boot specific stuff,
The alias is not specific to u-boot AFAIK.
I'll look how other boards handle that.
Thanks,
Ramon.
> Peter
>
> On Wed, Sep 19, 2018 at 7:31 PM Ramon Fried <ramon.fried@gmail.com> wrote:
> >
> > Alias is required so req-seq will be filled.
> >
> > Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
> > ---
> >
> >  arch/arm/dts/dragonboard410c.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/dts/dragonboard410c.dts b/arch/arm/dts/dragonboard410c.dts
> > index f4f7c350ec..75f28300b7 100644
> > --- a/arch/arm/dts/dragonboard410c.dts
> > +++ b/arch/arm/dts/dragonboard410c.dts
> > @@ -18,6 +18,10 @@
> >         #address-cells = <0x2>;
> >         #size-cells = <0x2>;
> >
> > +       aliases {
> > +               usb0 = "/soc/ehci@78d9000";
> > +       };
> > +
> >         memory {
> >                 device_type = "memory";
> >                 reg = <0 0x80000000 0 0x3da00000>;
> > --
> > 2.18.0
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
Peter Robinson Sept. 19, 2018, 8:03 p.m. UTC | #3
> > This should go into a -u-boot.dtsi file so that the
> > dragonboard410c.dts can be synced from the linux kernel without
> > change.
> >
> Hi Peter.
> I thought that -u-boot.dtsi is only for u-boot specific stuff,
> The alias is not specific to u-boot AFAIK.

Yes, I did wonder if some of these changes should also into linux.

Peter

> I'll look how other boards handle that.
> Thanks,
> Ramon.
> > Peter
> >
> > On Wed, Sep 19, 2018 at 7:31 PM Ramon Fried <ramon.fried@gmail.com> wrote:
> > >
> > > Alias is required so req-seq will be filled.
> > >
> > > Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
> > > ---
> > >
> > >  arch/arm/dts/dragonboard410c.dts | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/arch/arm/dts/dragonboard410c.dts b/arch/arm/dts/dragonboard410c.dts
> > > index f4f7c350ec..75f28300b7 100644
> > > --- a/arch/arm/dts/dragonboard410c.dts
> > > +++ b/arch/arm/dts/dragonboard410c.dts
> > > @@ -18,6 +18,10 @@
> > >         #address-cells = <0x2>;
> > >         #size-cells = <0x2>;
> > >
> > > +       aliases {
> > > +               usb0 = "/soc/ehci@78d9000";
> > > +       };
> > > +
> > >         memory {
> > >                 device_type = "memory";
> > >                 reg = <0 0x80000000 0 0x3da00000>;
> > > --
> > > 2.18.0
> > >
> > > _______________________________________________
> > > U-Boot mailing list
> > > U-Boot@lists.denx.de
> > > https://lists.denx.de/listinfo/u-boot
diff mbox series

Patch

diff --git a/arch/arm/dts/dragonboard410c.dts b/arch/arm/dts/dragonboard410c.dts
index f4f7c350ec..75f28300b7 100644
--- a/arch/arm/dts/dragonboard410c.dts
+++ b/arch/arm/dts/dragonboard410c.dts
@@ -18,6 +18,10 @@ 
 	#address-cells = <0x2>;
 	#size-cells = <0x2>;
 
+	aliases {
+		usb0 = "/soc/ehci@78d9000";
+	};
+
 	memory {
 		device_type = "memory";
 		reg = <0 0x80000000 0 0x3da00000>;