Patchwork [v2,2/9] target-mips/gdbstub: remove old CONFIG_SOFTFLOAT #ifndef

login
register
mail settings
Submitter Aurelien Jarno
Date May 23, 2011, 9:42 p.m.
Message ID <1306186971-9528-3-git-send-email-aurelien@aurel32.net>
Download mbox | patch
Permalink /patch/97081/
State New
Headers show

Comments

Aurelien Jarno - May 23, 2011, 9:42 p.m.
target-mips has been switched to softfloat only long ago, but
a #ifndef CONFIG_SOFTFLOAT has been forgotten. Remove it.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 gdbstub.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
Peter Maydell - May 23, 2011, 10:09 p.m.
On 23 May 2011 22:42, Aurelien Jarno <aurelien@aurel32.net> wrote:
> target-mips has been switched to softfloat only long ago, but
> a #ifndef CONFIG_SOFTFLOAT has been forgotten. Remove it.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Andreas Färber - May 29, 2011, 11:01 a.m.
Am 23.05.2011 um 23:42 schrieb Aurelien Jarno:

> target-mips has been switched to softfloat only long ago, but
> a #ifndef CONFIG_SOFTFLOAT has been forgotten. Remove it.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Reviewed-by: Andreas Färber <andreas.faerber@web.de>

> ---
> gdbstub.c |    4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index ae856f9..b9ae30d 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1105,10 +1105,6 @@ static int cpu_gdb_write_register(CPUState  
> *env, uint8_t *mem_buf, int n)
>             env->active_fpu.fcr31 = tmp & 0xFF83FFFF;
>             /* set rounding mode */
>             RESTORE_ROUNDING_MODE;
> -#ifndef CONFIG_SOFTFLOAT
> -            /* no floating point exception for native float */
> -            SET_FP_ENABLE(env->active_fpu.fcr31, 0);
> -#endif
>             break;
>         case 71: env->active_fpu.fcr0 = tmp; break;
>         }
> -- 
> 1.7.5.1

Patch

diff --git a/gdbstub.c b/gdbstub.c
index ae856f9..b9ae30d 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1105,10 +1105,6 @@  static int cpu_gdb_write_register(CPUState *env, uint8_t *mem_buf, int n)
             env->active_fpu.fcr31 = tmp & 0xFF83FFFF;
             /* set rounding mode */
             RESTORE_ROUNDING_MODE;
-#ifndef CONFIG_SOFTFLOAT
-            /* no floating point exception for native float */
-            SET_FP_ENABLE(env->active_fpu.fcr31, 0);
-#endif
             break;
         case 71: env->active_fpu.fcr0 = tmp; break;
         }