| Message ID | 20180917163609.30457-4-phil.edworthy@renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | Renesas R9A06G032 PINCTRL Driver | expand |
On Mon, Sep 17, 2018 at 05:36:09PM +0100, Phil Edworthy wrote: > This provides a pinctrl driver for the Renesas R9A06G032 SoC > > Based on a patch originally written by Michel Pollet at Renesas. > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> Thanks Phil, I will defer this patch pending acceptance of the bindings. Please continue to repost this patch with updates to the bindings or otherwise ping me once they have been accepted. > --- > v3: > - No changes. > v2: > - Add "renesas,rzn1-pinctrl" compatible fallback string > - Register size corrected. > --- > arch/arm/boot/dts/r9a06g032.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi > index eaf94976ed6d..2322268bc862 100644 > --- a/arch/arm/boot/dts/r9a06g032.dtsi > +++ b/arch/arm/boot/dts/r9a06g032.dtsi > @@ -165,6 +165,14 @@ > status = "disabled"; > }; > > + pinctrl: pin-controller@40067000 { > + compatible = "renesas,r9a06g032-pinctrl", "renesas,rzn1-pinctrl"; > + reg = <0x40067000 0x1000>, <0x51000000 0x480>; > + clocks = <&sysctrl R9A06G032_HCLK_PINCONFIG>; > + clock-names = "bus"; > + status = "okay"; > + }; > + > gic: gic@44101000 { > compatible = "arm,cortex-a7-gic", "arm,gic-400"; > interrupt-controller; > -- > 2.17.1 >
Hi Simon, On 19 September 2018 10:15 Simon Horman wrote: > On Mon, Sep 17, 2018 at 05:36:09PM +0100, Phil Edworthy wrote: > > This provides a pinctrl driver for the Renesas R9A06G032 SoC > > > > Based on a patch originally written by Michel Pollet at Renesas. > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > Thanks Phil, I will defer this patch pending acceptance of the bindings. > Please continue to repost this patch with updates to the bindings or > otherwise ping me once they have been accepted. Thanks, however I will send a new version of this patch to remove the clock-names prop as it is not needed. Thanks Phil > > --- > > v3: > > - No changes. > > v2: > > - Add "renesas,rzn1-pinctrl" compatible fallback string > > - Register size corrected. > > --- > > arch/arm/boot/dts/r9a06g032.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r9a06g032.dtsi > > b/arch/arm/boot/dts/r9a06g032.dtsi > > index eaf94976ed6d..2322268bc862 100644 > > --- a/arch/arm/boot/dts/r9a06g032.dtsi > > +++ b/arch/arm/boot/dts/r9a06g032.dtsi > > @@ -165,6 +165,14 @@ > > status = "disabled"; > > }; > > > > + pinctrl: pin-controller@40067000 { > > + compatible = "renesas,r9a06g032-pinctrl", > "renesas,rzn1-pinctrl"; > > + reg = <0x40067000 0x1000>, <0x51000000 0x480>; > > + clocks = <&sysctrl R9A06G032_HCLK_PINCONFIG>; > > + clock-names = "bus"; > > + status = "okay"; > > + }; > > + > > gic: gic@44101000 { > > compatible = "arm,cortex-a7-gic", "arm,gic-400"; > > interrupt-controller; > > -- > > 2.17.1 > >
Hi Phil, On Wed, Sep 19, 2018 at 11:18 AM Phil Edworthy <phil.edworthy@renesas.com> wrote: > On 19 September 2018 10:15 Simon Horman wrote: > > On Mon, Sep 17, 2018 at 05:36:09PM +0100, Phil Edworthy wrote: > > > This provides a pinctrl driver for the Renesas R9A06G032 SoC > > > > > > Based on a patch originally written by Michel Pollet at Renesas. > > > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > > > Thanks Phil, I will defer this patch pending acceptance of the bindings. > > Please continue to repost this patch with updates to the bindings or > > otherwise ping me once they have been accepted. > Thanks, however I will send a new version of this patch to remove the > clock-names prop as it is not needed. I haven't reviewed the bindings patch yet, but it's a good idea to have clock-names, even for a single clock. It makes life easier if the same module is reused or enhanced in a later SoC, with more clock inputs. Gr{oetje,eeting}s, Geert
On Wed, Sep 19, 2018 at 09:18:41AM +0000, Phil Edworthy wrote: > Hi Simon, > > On 19 September 2018 10:15 Simon Horman wrote: > > On Mon, Sep 17, 2018 at 05:36:09PM +0100, Phil Edworthy wrote: > > > This provides a pinctrl driver for the Renesas R9A06G032 SoC > > > > > > Based on a patch originally written by Michel Pollet at Renesas. > > > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > > > Thanks Phil, I will defer this patch pending acceptance of the bindings. > > Please continue to repost this patch with updates to the bindings or > > otherwise ping me once they have been accepted. > Thanks, however I will send a new version of this patch to remove the > clock-names prop as it is not needed. Thanks, sounds good.
Hi Geert, On 19 September 2018 10:24 Geert Uytterhoeven wrote: > On Wed, Sep 19, 2018 at 11:18 AM Phil Edworthy wrote: > > On 19 September 2018 10:15 Simon Horman wrote: > > > On Mon, Sep 17, 2018 at 05:36:09PM +0100, Phil Edworthy wrote: > > > > This provides a pinctrl driver for the Renesas R9A06G032 SoC > > > > > > > > Based on a patch originally written by Michel Pollet at Renesas. > > > > > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > > > > > Thanks Phil, I will defer this patch pending acceptance of the bindings. > > > Please continue to repost this patch with updates to the bindings or > > > otherwise ping me once they have been accepted. > > Thanks, however I will send a new version of this patch to remove the > > clock-names prop as it is not needed. > > I haven't reviewed the bindings patch yet, but it's a good idea to have > clock-names, even for a single clock. > It makes life easier if the same module is reused or enhanced in a later SoC, > with more clock inputs. Ok, I'll put it back :) I should be able to get a new version out today so you may want to delay your review until then. Thanks Phil
diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi index eaf94976ed6d..2322268bc862 100644 --- a/arch/arm/boot/dts/r9a06g032.dtsi +++ b/arch/arm/boot/dts/r9a06g032.dtsi @@ -165,6 +165,14 @@ status = "disabled"; }; + pinctrl: pin-controller@40067000 { + compatible = "renesas,r9a06g032-pinctrl", "renesas,rzn1-pinctrl"; + reg = <0x40067000 0x1000>, <0x51000000 0x480>; + clocks = <&sysctrl R9A06G032_HCLK_PINCONFIG>; + clock-names = "bus"; + status = "okay"; + }; + gic: gic@44101000 { compatible = "arm,cortex-a7-gic", "arm,gic-400"; interrupt-controller;
This provides a pinctrl driver for the Renesas R9A06G032 SoC Based on a patch originally written by Michel Pollet at Renesas. Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> --- v3: - No changes. v2: - Add "renesas,rzn1-pinctrl" compatible fallback string - Register size corrected. --- arch/arm/boot/dts/r9a06g032.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)