mfd: arizona: Correct link for sound binding document
diff mbox series

Message ID 20180917153322.29206-1-ckeepax@opensource.cirrus.com
State Accepted
Headers show
Series
  • mfd: arizona: Correct link for sound binding document
Related show

Commit Message

Charles Keepax Sept. 17, 2018, 3:33 p.m. UTC
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
 Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring Sept. 26, 2018, 10:39 p.m. UTC | #1
On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

Rob
Lee Jones Sept. 28, 2018, 5:46 a.m. UTC | #2
On Wed, 26 Sep 2018, Rob Herring wrote:

> On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied.

Probably won't do any harm in this instance, but it's usually better
for MFD binding changes to go through the MFD tree to avoid
merge-conflicts.
Rob Herring Sept. 28, 2018, 4 p.m. UTC | #3
On Fri, Sep 28, 2018 at 12:46 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Wed, 26 Sep 2018, Rob Herring wrote:
>
> > On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > > ---
> > >  Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Applied.
>
> Probably won't do any harm in this instance, but it's usually better
> for MFD binding changes to go through the MFD tree to avoid
> merge-conflicts.

It had been sitting there for a while, so I picked it up. Plus if we
have conflicts within a binding (other than tree wide clean ups I do),
that's not a good sign that the binding is changing.

Rob
Lee Jones Oct. 9, 2018, 6:55 a.m. UTC | #4
On Fri, 28 Sep 2018, Rob Herring wrote:

> On Fri, Sep 28, 2018 at 12:46 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Wed, 26 Sep 2018, Rob Herring wrote:
> >
> > > On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> > > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Applied.
> >
> > Probably won't do any harm in this instance, but it's usually better
> > for MFD binding changes to go through the MFD tree to avoid
> > merge-conflicts.
> 
> It had been sitting there for a while, so I picked it up. Plus if we

A little over a week is not 'a while'. :)

> have conflicts within a binding (other than tree wide clean ups I do),
> that's not a good sign that the binding is changing.

Not sure I understand this.
Rob Herring Oct. 31, 2018, 3:38 p.m. UTC | #5
On Tue, Oct 9, 2018 at 1:55 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 28 Sep 2018, Rob Herring wrote:
>
> > On Fri, Sep 28, 2018 at 12:46 AM Lee Jones <lee.jones@linaro.org> wrote:
> > >
> > > On Wed, 26 Sep 2018, Rob Herring wrote:
> > >
> > > > On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> > > > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > Applied.
> > >
> > > Probably won't do any harm in this instance, but it's usually better
> > > for MFD binding changes to go through the MFD tree to avoid
> > > merge-conflicts.
> >
> > It had been sitting there for a while, so I picked it up. Plus if we
>
> A little over a week is not 'a while'. :)

You're right. Probably should have waited 2 weeks. Developers
shouldn't have to wait longer than that for a response (according to
the chief penguin).

> > have conflicts within a binding (other than tree wide clean ups I do),
> > that's not a good sign that the binding is changing.
>
> Not sure I understand this.

If there are multiple sets of changes to a single binding within 1
release cycle (more than 1 really IMO), then that is a problem in and
of itself. We may want drivers enhanced feature by feature, but I
don't want bindings to. Bindings shouldn't be evolving. Maybe
sometimes different people add different things, but then they need to
work out the dependencies and conflicts, not you or me.

Rob

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index 9b62831fdf3e..148ef621a5e5 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -76,7 +76,7 @@  Deprecated properties:
 Also see child specific device properties:
   Regulator - ../regulator/arizona-regulator.txt
   Extcon    - ../extcon/extcon-arizona.txt
-  Sound     - ../sound/arizona.txt
+  Sound     - ../sound/wlf,arizona.txt
 
 Example: