diff mbox series

[xenial/linux-meta-azure-edge] UBUNTU: Add header build dependency

Message ID 20180917091859.25362-1-marcelo.cerri@canonical.com
State New
Headers show
Series [xenial/linux-meta-azure-edge] UBUNTU: Add header build dependency | expand

Commit Message

Marcelo Henrique Cerri Sept. 17, 2018, 9:18 a.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1792891

Add a build dependency on linux-headers package to ensure the
azure-edge meta package is not promoted to -proposed if the target
kernel package is not ready. That's only an issue when pointing the
meta package to xenial/linux-azure, instead of
xenial/linux-azure-edge, because they are not handled by the same
tracking bug in that case.

Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
---
 debian/control.common | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Kleber Sacilotto de Souza Sept. 17, 2018, 9:25 a.m. UTC | #1
On 09/17/18 11:18, Marcelo Henrique Cerri wrote:
> BugLink: http://bugs.launchpad.net/bugs/1792891
> 
> Add a build dependency on linux-headers package to ensure the
> azure-edge meta package is not promoted to -proposed if the target
> kernel package is not ready. That's only an issue when pointing the
> meta package to xenial/linux-azure, instead of
> xenial/linux-azure-edge, because they are not handled by the same
> tracking bug in that case.
> 
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  debian/control.common | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/debian/control.common b/debian/control.common
> index 9ecd6bd1d876..b1c66f33eff1 100644
> --- a/debian/control.common
> +++ b/debian/control.common
> @@ -4,5 +4,7 @@ Priority: optional
>  Maintainer: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>
>  Standards-Version: 3.6.1
>  Build-Depends: dpkg (>= 1.13.19), debhelper (>= 5), gawk
> +Build-Depends-Arch:
> + linux-azure-headers-@kernel-abi-version@,
> + linux-headers-@kernel-abi-version@-azure,
>  Vcs-Git: git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-azure azure-edge
> -
>
Colin Ian King Sept. 25, 2018, 1:06 p.m. UTC | #2
On 17/09/18 10:18, Marcelo Henrique Cerri wrote:
> BugLink: http://bugs.launchpad.net/bugs/1792891
> 
> Add a build dependency on linux-headers package to ensure the
> azure-edge meta package is not promoted to -proposed if the target
> kernel package is not ready. That's only an issue when pointing the
> meta package to xenial/linux-azure, instead of
> xenial/linux-azure-edge, because they are not handled by the same
> tracking bug in that case.
> 
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
>  debian/control.common | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/debian/control.common b/debian/control.common
> index 9ecd6bd1d876..b1c66f33eff1 100644
> --- a/debian/control.common
> +++ b/debian/control.common
> @@ -4,5 +4,7 @@ Priority: optional
>  Maintainer: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>
>  Standards-Version: 3.6.1
>  Build-Depends: dpkg (>= 1.13.19), debhelper (>= 5), gawk
> +Build-Depends-Arch:
> + linux-azure-headers-@kernel-abi-version@,
> + linux-headers-@kernel-abi-version@-azure,
>  Vcs-Git: git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-azure azure-edge
> -
> 
Makes sense.

Acked-by: Colin Ian King <colin.king@canonical.com>
Kleber Sacilotto de Souza Oct. 2, 2018, 9:40 a.m. UTC | #3
On 09/17/18 11:18, Marcelo Henrique Cerri wrote:
> BugLink: http://bugs.launchpad.net/bugs/1792891
> 
> Add a build dependency on linux-headers package to ensure the
> azure-edge meta package is not promoted to -proposed if the target
> kernel package is not ready. That's only an issue when pointing the
> meta package to xenial/linux-azure, instead of
> xenial/linux-azure-edge, because they are not handled by the same
> tracking bug in that case.
> 
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
>  debian/control.common | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/debian/control.common b/debian/control.common
> index 9ecd6bd1d876..b1c66f33eff1 100644
> --- a/debian/control.common
> +++ b/debian/control.common
> @@ -4,5 +4,7 @@ Priority: optional
>  Maintainer: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>
>  Standards-Version: 3.6.1
>  Build-Depends: dpkg (>= 1.13.19), debhelper (>= 5), gawk
> +Build-Depends-Arch:
> + linux-azure-headers-@kernel-abi-version@,
> + linux-headers-@kernel-abi-version@-azure,
>  Vcs-Git: git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-azure azure-edge
> -
> 

Applied to xenial/linux-meta-azure/azure-edge branch.

Thanks,
Kleber
diff mbox series

Patch

diff --git a/debian/control.common b/debian/control.common
index 9ecd6bd1d876..b1c66f33eff1 100644
--- a/debian/control.common
+++ b/debian/control.common
@@ -4,5 +4,7 @@  Priority: optional
 Maintainer: Ubuntu Kernel Team <kernel-team@lists.ubuntu.com>
 Standards-Version: 3.6.1
 Build-Depends: dpkg (>= 1.13.19), debhelper (>= 5), gawk
+Build-Depends-Arch:
+ linux-azure-headers-@kernel-abi-version@,
+ linux-headers-@kernel-abi-version@-azure,
 Vcs-Git: git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-meta-azure azure-edge
-