| Message ID | VI1PR0701MB286212BEDE2F77FE1EA1588FE41F0@VI1PR0701MB2862.eurprd07.prod.outlook.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix ms-sysv generator with gcc-4.8 host-g++ | expand |
On Sun, 16 Sep 2018, Bernd Edlinger wrote: > Hi, > > > this prevents test failures when gcc-4.8 is used as host-g++ tool, since this version does > understand -std=c++11 but not -fno-diagnostics-show-line-numbers and -fdiagnostics-color=never. > With slightly newer gcc tools like gcc-5 everything works fine. > > Apparently the following commit added those options to TEST_ALWAYS_FLAGS. > > 2018-08-09 David Malcolm <dmalcolm@redhat.com> > > PR other/84889 > * gcc.dg/plugin/diagnostic-test-show-locus-bw-line-numbers.c: New > test. > * gcc.dg/plugin/diagnostic-test-show-locus-color-line-numbers.c: > New test. > * gcc.dg/plugin/plugin.exp (plugin_test_list): Add the new tests. > * lib/prune.exp: Add -fno-diagnostics-show-line-numbers to > TEST_ALWAYS_FLAGS. > > Work around is not using TEST_ALWAYS_FLAGS in the host tool invocation. > > > Bootstrapped and reg-tested with gcc-4.8 and gcc-5 host tools. > Is it OK for trunk? OK. > > Thanks > Bernd. > >
2018-09-16 Bernd Edlinger <bernd.edlinger@hotmail.de> * gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp: Don't pass TEST_ALWAYS_FLAGS to HOSTCXX. Index: gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp =================================================================== --- gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp (revision 264342) +++ gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp (working copy) @@ -109,7 +109,7 @@ < [file mtime "$src"]) } { # Temporarily switch to the environment for the host compiler. restore_ld_library_path_env_vars - set cxx "$HOSTCXX $HOSTCXXFLAGS $TEST_ALWAYS_FLAGS $warn_flags -std=c++11" + set cxx "$HOSTCXX $HOSTCXXFLAGS $warn_flags -std=c++11" set status [remote_exec host "$cxx -o $generator $src"] set status [lindex $status 0] set_ld_library_path_env_vars
Hi, this prevents test failures when gcc-4.8 is used as host-g++ tool, since this version does understand -std=c++11 but not -fno-diagnostics-show-line-numbers and -fdiagnostics-color=never. With slightly newer gcc tools like gcc-5 everything works fine. Apparently the following commit added those options to TEST_ALWAYS_FLAGS. 2018-08-09 David Malcolm <dmalcolm@redhat.com> PR other/84889 * gcc.dg/plugin/diagnostic-test-show-locus-bw-line-numbers.c: New test. * gcc.dg/plugin/diagnostic-test-show-locus-color-line-numbers.c: New test. * gcc.dg/plugin/plugin.exp (plugin_test_list): Add the new tests. * lib/prune.exp: Add -fno-diagnostics-show-line-numbers to TEST_ALWAYS_FLAGS. Work around is not using TEST_ALWAYS_FLAGS in the host tool invocation. Bootstrapped and reg-tested with gcc-4.8 and gcc-5 host tools. Is it OK for trunk? Thanks Bernd.