Patchwork jbd: Fix comment to match the code in journal_start()

login
register
mail settings
Submitter Eryu Guan
Date May 23, 2011, 4:17 p.m.
Message ID <1306167454-28638-1-git-send-email-guaneryu@gmail.com>
Download mbox | patch
Permalink /patch/97000/
State Not Applicable
Headers show

Comments

Eryu Guan - May 23, 2011, 4:17 p.m.
journal_start returns an ERR_PTR() value rather than NULL on failure.

Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
---
 fs/jbd/transaction.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Jan Kara - May 23, 2011, 10:28 p.m.
On Tue 24-05-11 00:17:34, Eryu Guan wrote:
> journal_start returns an ERR_PTR() value rather than NULL on failure.
> 
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
  Tnanks. Merged.

								Honza
> ---
>  fs/jbd/transaction.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 60d2319..f7ee81a 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -266,7 +266,8 @@ static handle_t *new_handle(int nblocks)
>   * This function is visible to journal users (like ext3fs), so is not
>   * called with the journal already locked.
>   *
> - * Return a pointer to a newly allocated handle, or NULL on failure
> + * Return a pointer to a newly allocated handle, or an ERR_PTR() value
> + * on failure.
>   */
>  handle_t *journal_start(journal_t *journal, int nblocks)
>  {
> -- 
> 1.7.3.4
>

Patch

diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index 60d2319..f7ee81a 100644
--- a/fs/jbd/transaction.c
+++ b/fs/jbd/transaction.c
@@ -266,7 +266,8 @@  static handle_t *new_handle(int nblocks)
  * This function is visible to journal users (like ext3fs), so is not
  * called with the journal already locked.
  *
- * Return a pointer to a newly allocated handle, or NULL on failure
+ * Return a pointer to a newly allocated handle, or an ERR_PTR() value
+ * on failure.
  */
 handle_t *journal_start(journal_t *journal, int nblocks)
 {