Patchwork Fix asix-based cards connecting to 10/100Mbs LAN.

login
register
mail settings
Submitter Pantelis Koukousoulas
Date Nov. 20, 2008, 9:47 a.m.
Message ID <1227174463-18158-1-git-send-email-pktoss@gmail.com>
Download mbox | patch
Permalink /patch/9698/
State Accepted
Delegated to: David Miller
Headers show

Comments

Pantelis Koukousoulas - Nov. 20, 2008, 9:47 a.m.
Add AX_MEDIUM_ENCK also when speed = 10/100Mbps. This allows my belkin
 f5d5055 to work with my 100Mbps switch and with an old 10Mbps ISA card.
 Without this patch, the card is recognized and the interface is brought
 up fine, but no packets actually flow through the interface.

Signed-off-by: Pantelis Koukousoulas <pktoss@gmail.com>
Acked-by: David Hollis <dhollis@davehollis.com>
---
 drivers/net/usb/asix.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
David Miller - Nov. 20, 2008, 9:48 a.m.
From: Pantelis Koukousoulas <pktoss@gmail.com>
Date: Thu, 20 Nov 2008 11:47:43 +0200

> Add AX_MEDIUM_ENCK also when speed = 10/100Mbps. This allows my belkin
>  f5d5055 to work with my 100Mbps switch and with an old 10Mbps ISA card.
>  Without this patch, the card is recognized and the interface is brought
>  up fine, but no packets actually flow through the interface.
> 
> Signed-off-by: Pantelis Koukousoulas <pktoss@gmail.com>
> Acked-by: David Hollis <dhollis@davehollis.com>

Patch applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pantelis Koukousoulas - Nov. 20, 2008, 4:42 p.m.
> Patch applied, thank you.

Thanks for applying :)
Should I expect this for 2.6.28 or 2.6.29 ?

Pantelis
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Nov. 21, 2008, 4:40 a.m.
From: "Pantelis Koukousoulas" <pktoss@gmail.com>
Date: Thu, 20 Nov 2008 18:42:10 +0200

> > Patch applied, thank you.
> 
> Thanks for applying :)
> Should I expect this for 2.6.28 or 2.6.29 ?

It's in Linus's tree already.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Hollis - Nov. 21, 2008, 2:41 p.m.
On Thu, 2008-11-20 at 20:40 -0800, David Miller wrote:
> From: "Pantelis Koukousoulas" <pktoss@gmail.com>
> Date: Thu, 20 Nov 2008 18:42:10 +0200
> 
> > > Patch applied, thank you.
> > 
> > Thanks for applying :)
> > Should I expect this for 2.6.28 or 2.6.29 ?
> 
> It's in Linus's tree already.

Which means that it will be in 2.6.28 final.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index e12cdb4..de57490 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -1102,12 +1102,14 @@  static int ax88178_link_reset(struct usbnet *dev)
 	mode = AX88178_MEDIUM_DEFAULT;
 
 	if (ecmd.speed == SPEED_1000)
-		mode |= AX_MEDIUM_GM | AX_MEDIUM_ENCK;
+		mode |= AX_MEDIUM_GM;
 	else if (ecmd.speed == SPEED_100)
 		mode |= AX_MEDIUM_PS;
 	else
 		mode &= ~(AX_MEDIUM_PS | AX_MEDIUM_GM);
 
+	mode |= AX_MEDIUM_ENCK;
+
 	if (ecmd.duplex == DUPLEX_FULL)
 		mode |= AX_MEDIUM_FD;
 	else