| Message ID | 1536849882-28897-3-git-send-email-stanislav.kholmanskikh@oracle.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [RFC,1/5] Remove the pipes runtest file | expand |
Hi! Can we do this the other way around? I.e. rename the source files to match the syscall name and then patch the cve runtest file to map the cve-* identifiers to the test names?
On 10/02/2018 03:53 PM, Cyril Hrubis wrote: > Hi! > Can we do this the other way around? > > I.e. rename the source files to match the syscall name and then patch > the cve runtest file to map the cve-* identifiers to the test names? > Yes. No objection at all.
On 10/02/2018 03:53 PM, Cyril Hrubis wrote: > Hi! > Can we do this the other way around? > > I.e. rename the source files to match the syscall name and then patch > the cve runtest file to map the cve-* identifiers to the test names? > By the way, should I rename them right into testcases/cve or move to a corresponding directory in testcases/kernel/syscalls? I.e. testcases/cve/cve-2017-6951.c -> testcases/cve/request_key05.c or testcases/cve/cve-2017-6951.c -> testcases/kernel/syscalls/request_key/request_key05.c ? I assume you propose the latter option, correct? Thanks.
Hi! > should I rename them right into testcases/cve or move to a corresponding > directory in testcases/kernel/syscalls? > > I.e. > > testcases/cve/cve-2017-6951.c -> testcases/cve/request_key05.c > > or > > testcases/cve/cve-2017-6951.c -> > testcases/kernel/syscalls/request_key/request_key05.c > > ? > > I assume you propose the latter option, correct? Yes.
diff --git a/runtest/syscalls b/runtest/syscalls index 0d0be77..b68eda7 100644 --- a/runtest/syscalls +++ b/runtest/syscalls @@ -950,8 +950,8 @@ renameat202 renameat202 -i 10 request_key01 request_key01 request_key02 request_key02 request_key03 request_key03 -cve-2017-6951 cve-2017-6951 request_key04 request_key04 +request_key05 cve-2017-6951 rmdir01 rmdir01 rmdir02 rmdir02 @@ -1177,7 +1177,7 @@ setsid01 setsid01 setsockopt01 setsockopt01 setsockopt02 setsockopt02 -cve-2016-4997 cve-2016-4997 +setsockopt03 cve-2016-4997 settimeofday01 settimeofday01 settimeofday02 settimeofday02 @@ -1195,7 +1195,7 @@ setxattr03 setxattr03 shmat01 shmat01 shmat02 shmat02 -cve-2017-5669 cve-2017-5669 +shmat03 cve-2017-5669 shmctl01 shmctl01 shmctl02 shmctl02 @@ -1390,7 +1390,7 @@ umask01 umask01 uname01 uname01 uname02 uname02 uname03 uname03 -cve-2012-0957 cve-2012-0957 +uname04 cve-2012-0957 unlink01 symlink01 -T unlink01 unlink05 unlink05
Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> --- runtest/syscalls | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)