| Message ID | 1536849882-28897-5-git-send-email-stanislav.kholmanskikh@oracle.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [RFC,1/5] Remove the pipes runtest file | expand |
Hi! > runtest/syscalls already defines tests with these ids, but there > they point to different commands. In order to avoid name conflicts > we need to rename tests either in runtest/commands or in runtest/syscalls. > Since the tests in runtest/syscalls are much older, I chose to rename > the tests in runtest/commands. > > Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> > --- > runtest/commands | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/runtest/commands b/runtest/commands > index ee7e9f4..f27d2fa 100644 > --- a/runtest/commands > +++ b/runtest/commands > @@ -37,7 +37,7 @@ which01 which01.sh > lsmod01 lsmod01.sh > insmod01 insmod01.sh > wc01 wc01.sh > -keyctl01 keyctl01.sh > +keyctl_01 keyctl01.sh > gdb01 gdb01.sh > -unshare01 unshare01.sh > -sysctl01 sysctl01.sh > +unshare_01 unshare01.sh > +sysctl_01 sysctl01.sh Hmm, that's a bit hacky. Maybe we should add a _sh suffix to all the testcases in commands so that it's clear that these are shell scripts.
On 10/02/2018 04:03 PM, Cyril Hrubis wrote: > Hi! >> runtest/syscalls already defines tests with these ids, but there >> they point to different commands. In order to avoid name conflicts >> we need to rename tests either in runtest/commands or in runtest/syscalls. >> Since the tests in runtest/syscalls are much older, I chose to rename >> the tests in runtest/commands. >> >> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> >> --- >> runtest/commands | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/runtest/commands b/runtest/commands >> index ee7e9f4..f27d2fa 100644 >> --- a/runtest/commands >> +++ b/runtest/commands >> @@ -37,7 +37,7 @@ which01 which01.sh >> lsmod01 lsmod01.sh >> insmod01 insmod01.sh >> wc01 wc01.sh >> -keyctl01 keyctl01.sh >> +keyctl_01 keyctl01.sh >> gdb01 gdb01.sh >> -unshare01 unshare01.sh >> -sysctl01 sysctl01.sh >> +unshare_01 unshare01.sh >> +sysctl_01 sysctl01.sh > > Hmm, that's a bit hacky. Maybe we should add a _sh suffix to all the > testcases in commands so that it's clear that these are shell scripts. > As if keyctl01 keyctl01.sh was changed to keyctl01_sh keyctl01.sh Correct?
Hi! > As if > > keyctl01 keyctl01.sh > > was changed to > > keyctl01_sh keyctl01.sh > > Correct? Or we can, for the cases where command has the same name as syscall, increment the numbers for the command tests by 50, that should avoid the collisions. So the keyctl01.sh will become keyctl51.sh.
Hi On 10/03/2018 10:42 AM, Cyril Hrubis wrote: > Hi! >> As if >> >> keyctl01 keyctl01.sh >> >> was changed to >> >> keyctl01_sh keyctl01.sh >> >> Correct? > > Or we can, for the cases where command has the same name as syscall, > increment the numbers for the command tests by 50, that should avoid the > collisions. > > So the keyctl01.sh will become keyctl51.sh. > Maybe we better stick to your previous proposal, i.e. adding _sh to the end of a name (in runtest files)? In my opinion, it's more clear and straightforward, i.e. if one has a look at a runtest file, it will take little time to understand why some tests have _sh at the end. Plus it doesn't require renaming of the sh test cases. Shifting the numbering by a big number looks a bit tricky.
Hi! > Maybe we better stick to your previous proposal, i.e. adding _sh to the > end of a name (in runtest files)? In my opinion, it's more clear and > straightforward, i.e. if one has a look at a runtest file, it will take > little time to understand why some tests have _sh at the end. Plus it > doesn't require renaming of the sh test cases. > > Shifting the numbering by a big number looks a bit tricky. Ok.
diff --git a/runtest/commands b/runtest/commands index ee7e9f4..f27d2fa 100644 --- a/runtest/commands +++ b/runtest/commands @@ -37,7 +37,7 @@ which01 which01.sh lsmod01 lsmod01.sh insmod01 insmod01.sh wc01 wc01.sh -keyctl01 keyctl01.sh +keyctl_01 keyctl01.sh gdb01 gdb01.sh -unshare01 unshare01.sh -sysctl01 sysctl01.sh +unshare_01 unshare01.sh +sysctl_01 sysctl01.sh
runtest/syscalls already defines tests with these ids, but there they point to different commands. In order to avoid name conflicts we need to rename tests either in runtest/commands or in runtest/syscalls. Since the tests in runtest/syscalls are much older, I chose to rename the tests in runtest/commands. Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> --- runtest/commands | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)