| Message ID | 20180911170825.17789-4-dmurphy@ti.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | LM3697 dedicated LED driver | expand |
On Tue, Sep 11, 2018 at 12:08:22PM -0500, Dan Murphy wrote: > Add the device tree bindings for the lm3697 > LED driver for backlighting and display. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > > v7 - Fix compatible from 3967 to 3697, and other comments. - https://lore.kernel.org/patchwork/patch/982550/ > > v6 - Fix minor issues - https://lore.kernel.org/patchwork/patch/975387/ > v5 - Fix the comment for the example - https://lore.kernel.org/patchwork/patch/975060/ > v4 - Removed HVLED definition in favor of HVLED place definition - https://lore.kernel.org/patchwork/patch/974812/ > v3 - Updated subject with prefered title - https://lore.kernel.org/patchwork/patch/972337/ > v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/ > > .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++++++++++++++++++ > 1 file changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt Reviewed-by: Rob Herring <robh@kernel.org>
Hi! > > Add the device tree bindings for the lm3697 > > LED driver for backlighting and display. > > > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > > .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++++++++++++++++++ > > 1 file changed, 86 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt > > Reviewed-by: Rob Herring <robh@kernel.org> We already have binding for lm3697 in Documentation/devicetree/bindings/mfd/ti-lmu.txt . Is it good idea to have second one? Pavel
On Mon, Sep 24, 2018 at 1:02 PM Pavel Machek <pavel@ucw.cz> wrote: > > Hi! > > > > Add the device tree bindings for the lm3697 > > > LED driver for backlighting and display. > > > > > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > > > > .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++++++++++++++++++ > > > 1 file changed, 86 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > We already have binding for lm3697 in > Documentation/devicetree/bindings/mfd/ti-lmu.txt . Is it good idea to > have second one? Of course not. Now that you mention it, I do remember seeing some discussion on this. Rob
Rob/Pavel/Jacek On 09/25/2018 02:39 PM, Rob Herring wrote: > On Mon, Sep 24, 2018 at 1:02 PM Pavel Machek <pavel@ucw.cz> wrote: >> >> Hi! >> >>>> Add the device tree bindings for the lm3697 >>>> LED driver for backlighting and display. >>>> >>>> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> >>>> .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++++++++++++++++++ >>>> 1 file changed, 86 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt >>> >>> Reviewed-by: Rob Herring <robh@kernel.org> >> >> We already have binding for lm3697 in >> Documentation/devicetree/bindings/mfd/ti-lmu.txt . Is it good idea to >> have second one? > > Of course not. Now that you mention it, I do remember seeing some > discussion on this. > > Rob > I will be posting a RFC tomorrow with all the changes that shows 3 devices attached to the common code along with extending out the features on the LED drivers themselves. Its not complete or tested code but it should give a basis for discussion. This way I can do some other code while this is being discussed. Dan
diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/Documentation/devicetree/bindings/leds/leds-lm3697.txt new file mode 100644 index 000000000000..85ae075f6677 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt @@ -0,0 +1,86 @@ +* Texas Instruments - LM3697 Highly Efficient White LED Driver + +The LM3697 11-bit LED driver provides high- +performance backlight dimming for 1, 2, or 3 series +LED strings while delivering up to 90% efficiency. + +This device is suitable for display and keypad Lighting + +Required properties: + - compatible: + "ti,lm3697" + - reg : I2C slave address + - #address-cells : 1 + - #size-cells : 0 + +Optional properties: + - enable-gpios : GPIO pin to enable/disable the device + - vled-supply : LED supply + +Required child properties: + - reg : 0 - LED is Controlled by bank A + 1 - LED is Controlled by bank B + - led-sources : Indicates which HVLED string is associated to which + control bank. Each element in the array is associated + with a specific HVLED string. Element 0 is HVLED1, + element 1 is HVLED2 and element 2 HVLED3. + Additional information is contained + in Documentation/devicetree/bindings/leds/common.txt + 0 - HVLED is not active in this control bank + 1 - HVLED string is controlled by this control bank + +Optional child properties: + - label : see Documentation/devicetree/bindings/leds/common.txt + - linux,default-trigger : + see Documentation/devicetree/bindings/leds/common.txt + +Example: + +HVLED string 1 and 3 are controlled by control bank A and HVLED 2 string is +controlled by control bank B. + +led-controller@36 { + compatible = "ti,lm3697"; + reg = <0x36>; + #address-cells = <1>; + #size-cells = <0>; + + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; + vled-supply = <&vbatt>; + + led@0 { + reg = <0>; + led-sources = <1 0 1>; + label = "white:first_backlight_cluster"; + linux,default-trigger = "backlight"; + }; + + led@1 { + reg = <1>; + led-sources = <0 1 0>; + label = "white:second_backlight_cluster"; + linux,default-trigger = "backlight"; + }; +} + +All HVLED strings controlled by control bank A + +led-controller@36 { + compatible = "ti,lm3697"; + reg = <0x36>; + #address-cells = <1>; + #size-cells = <0>; + + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; + vled-supply = <&vbatt>; + + led@0 { + reg = <0>; + led-sources = <1 1 1>; + label = "white:backlight_cluster"; + linux,default-trigger = "backlight"; + }; +} + +For more product information please see the link below: +http://www.ti.com/lit/ds/symlink/lm3697.pdf
Add the device tree bindings for the lm3697 LED driver for backlighting and display. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- v7 - Fix compatible from 3967 to 3697, and other comments. - https://lore.kernel.org/patchwork/patch/982550/ v6 - Fix minor issues - https://lore.kernel.org/patchwork/patch/975387/ v5 - Fix the comment for the example - https://lore.kernel.org/patchwork/patch/975060/ v4 - Removed HVLED definition in favor of HVLED place definition - https://lore.kernel.org/patchwork/patch/974812/ v3 - Updated subject with prefered title - https://lore.kernel.org/patchwork/patch/972337/ v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/ .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt