Patchwork [01/62] mtd: always build partitioning support

login
register
mail settings
Submitter Jamie Iles
Date May 23, 2011, 9:22 a.m.
Message ID <1306142623-24952-2-git-send-email-jamie@jamieiles.com>
Download mbox | patch
Permalink /patch/96844/
State New
Headers show

Comments

Jamie Iles - May 23, 2011, 9:22 a.m.
There are very few situations where MTD partitioning is not required,
and the benefit in code size reduction by making this configurable does
not warrant the level of ifdeffery needed.

Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Artem Bityutskiy <dedekind1@gmail.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 drivers/mtd/Kconfig |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)
Artem Bityutskiy - May 23, 2011, 3:15 p.m.
On Mon, 2011-05-23 at 10:22 +0100, Jamie Iles wrote:
> There are very few situations where MTD partitioning is not required,
> and the benefit in code size reduction by making this configurable does
> not warrant the level of ifdeffery needed.

Amended commit message a bit and pushed to l2-mtd-2.6.git / jamie branch
so far.

Patch

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index b4567c3..8b61b0c 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -1,6 +1,7 @@ 
 menuconfig MTD
 	tristate "Memory Technology Device (MTD) support"
 	depends on HAS_IOMEM
+	select MTD_PARTITIONS
 	help
 	  Memory Technology Devices are flash, RAM and similar chips, often
 	  used for solid state file systems on embedded devices. This option
@@ -34,16 +35,7 @@  config MTD_TESTS
 	  various checks and verifications when loaded.
 
 config MTD_PARTITIONS
-	bool "MTD partitioning support"
-	help
-	  If you have a device which needs to divide its flash chip(s) up
-	  into multiple 'partitions', each of which appears to the user as
-	  a separate MTD device, you require this option to be enabled. If
-	  unsure, say 'Y'.
-
-	  Note, however, that you don't need this option for the DiskOnChip
-	  devices. Partitioning on NFTL 'devices' is a different - that's the
-	  'normal' form of partitioning used on a block device.
+	bool
 
 if MTD_PARTITIONS