Patchwork [-next] ata: PATA_ARASAN_CF depends on DMADEVICES

login
register
mail settings
Submitter Randy Dunlap
Date May 23, 2011, 12:32 a.m.
Message ID <20110522173227.5ba18817.randy.dunlap@oracle.com>
Download mbox | patch
Permalink /patch/96815/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Randy Dunlap - May 23, 2011, 12:32 a.m.
From: Randy Dunlap <randy.dunlap@oracle.com>

Fix kconfig unmet dependency warning:

warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Viresh Kumar <viresh.kumar@st.com>
---
 drivers/ata/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Viresh KUMAR - May 23, 2011, 3:35 a.m.
On 05/23/2011 06:02 AM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix kconfig unmet dependency warning:
> 
> warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Viresh Kumar <viresh.kumar@st.com>
> ---
>  drivers/ata/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20110520.orig/drivers/ata/Kconfig
> +++ linux-next-20110520/drivers/ata/Kconfig
> @@ -313,6 +313,7 @@ config PATA_AMD
>  
>  config PATA_ARASAN_CF
>  	tristate "ARASAN CompactFlash PATA Controller Support"
> +	depends on DMADEVICES
>  	select DMA_ENGINE

Randy,

I think we can also remove this "select DMA_ENGINE" line.

Otherwise, it looks fine.

Acked-by: Viresh Kumar <viresh.kumar@st.com>
Randy Dunlap - May 23, 2011, 4:21 p.m.
On 05/22/11 20:35, viresh kumar wrote:
> On 05/23/2011 06:02 AM, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Fix kconfig unmet dependency warning:
>>
>> warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: Viresh Kumar <viresh.kumar@st.com>
>> ---
>>  drivers/ata/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-next-20110520.orig/drivers/ata/Kconfig
>> +++ linux-next-20110520/drivers/ata/Kconfig
>> @@ -313,6 +313,7 @@ config PATA_AMD
>>  
>>  config PATA_ARASAN_CF
>>  	tristate "ARASAN CompactFlash PATA Controller Support"
>> +	depends on DMADEVICES
>>  	select DMA_ENGINE
> 
> Randy,
> 
> I think we can also remove this "select DMA_ENGINE" line.

In that case, the newly added "depends on" line is not needed either,
since the "select DMA_ENGINE" is what causes the kconfig warning message.


> Otherwise, it looks fine.
> 
> Acked-by: Viresh Kumar <viresh.kumar@st.com>
>
Viresh KUMAR - May 24, 2011, 3:38 a.m.
On 05/23/2011 09:51 PM, Randy Dunlap wrote:
>>> >>  config PATA_ARASAN_CF
>>> >>  	tristate "ARASAN CompactFlash PATA Controller Support"
>>> >> +	depends on DMADEVICES
>>> >>  	select DMA_ENGINE
>> > 
>> > Randy,
>> > 
>> > I think we can also remove this "select DMA_ENGINE" line.
> In that case, the newly added "depends on" line is not needed either,
> since the "select DMA_ENGINE" is what causes the kconfig warning message.
> 

Some sort of dependency must be present as PATA_ARASAN is using DMAENGINE
routines and it will not compile unless DMA_ENGINE is enabled.

So, depends on DMADEVICES will solve all these issues.

Patch

--- linux-next-20110520.orig/drivers/ata/Kconfig
+++ linux-next-20110520/drivers/ata/Kconfig
@@ -313,6 +313,7 @@  config PATA_AMD
 
 config PATA_ARASAN_CF
 	tristate "ARASAN CompactFlash PATA Controller Support"
+	depends on DMADEVICES
 	select DMA_ENGINE
 	help
 	  Say Y here to support the ARASAN CompactFlash PATA controller