From patchwork Mon Sep 10 11:00:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "d. caratti" X-Patchwork-Id: 967969 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LvWT9Usb"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jseGUeJj"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4284qZ3BmHz9s3C for ; Mon, 10 Sep 2018 21:01:46 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=XqIIs8JcauMEFK2qeco8c1aOat/dGgts88G74k2vmvk=; b=LvWT9UsbRATiCK Q4V9j1EgT78L3akldI7CWWc15lGGGU1FFxecUPnFTvPSCq7+rgdgYVh6kj9x2w/chvv/iyPf3uTe+ heuYYjS9J/sJWudX/UKnIOpNTI/i5Vj4zeS+VWoZnaH4WEXdgDQTzL1cVPgvFyAspI6ONh+ViEwk7 wL8E0qeK60M69hRr9TRjoyJi8l6NVT/EwkiiH3rQionuSzqKYAYorNzvOKuCJ8nDWm7wv/9Hm/5Yc PjdGTHymq5HsUyXQmWjqRDxx1d7hcACmdOUmsv8LIvqx8F3IOGzlK2tphV3UuABNPY0fyIJOgoLh/ VDX+D22p+F2Z9qlmTeJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzJwY-0005Y1-Ps; Mon, 10 Sep 2018 11:01:24 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzJwD-0005Wm-Ga for hostap@lists.infradead.org; Mon, 10 Sep 2018 11:01:07 +0000 Received: by mail-wr1-x429.google.com with SMTP id w11-v6so21442608wrc.5 for ; Mon, 10 Sep 2018 04:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=XUnvv9y/g1v0/3GsLtXl1+X+BaVRsgIco2ZMavC6Jog=; b=jseGUeJjw5W21IpuQbQ5nmWV3Lu0VM6EtCV6yj5hNbq6kVb9DQjggx4p74fJ29lSPe gypSjw8KTSNXNZCMC1Mf9Ziud95won6J1tU6Ol7a5cJ4dVU5bLeItgy29vX5vN7YlBh9 9FLg2Tw+LmIvhq6eNLKaE4CkbXLX6+Py5E661g8yJe/j2Mop5d+XCw6zTukz2mgQ79jW MwgfgS2An/MMrltxDknsB2/sXwQvLAa0J9d434LeX6yVAGKeZ5ONfwq6HN1eSaRjXSMa npqS2COY1QI5LSe9hRtIC5ciivvN+Tjd0gPnIDZAJ2dDCQLgCDGGyIwdugHOxxKqnQvn de1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=XUnvv9y/g1v0/3GsLtXl1+X+BaVRsgIco2ZMavC6Jog=; b=ZF9Af6bFxNzNb8b57BNO+CJzZrWdautw+Pciz5AnxLEVRlSdo5InNz1mV8QQ/zC+kU lghyDDlTD6yf16UVq+e59uzfHjmFeVV3FHs6mqb8dT2bjTTXIVdOfcjIgmeLEYbNwA/q L9qJ5AZYwafxjeMChXWXILCLN/Wc8bIr/6iol76wd5TP3dB2iHP6FAIfbF9LQtG1k0o6 CtpgjbQtfAiWA9+I7zKcy+6uhdPktnzX2WhVOP1cyXZwonL8IrmEGjQGt1K42qQLGZ1v Fna0pN2BvqDSCe9CRa+HLD6OQZz9ymcASTwjmUD1+nIySZvHIiR5B79uxLS3qQk1zHdZ hMzA== X-Gm-Message-State: APzg51A1t0O2H+PiWqWLx0T7nI4E6ikuiMZm/QeaIwqcY43/Y+/WTHdC k2UblxH1WiyzpAM+AYXqAyHztAlb X-Google-Smtp-Source: ANB0VdbhZYvHK2p1Ht0GYNitqqsG7hBkEALygvqkLUOs6Qr4GjIVbaGYqeGDy5AW7xMPw30mYRhh7w== X-Received: by 2002:a5d:4250:: with SMTP id s16-v6mr14369913wrr.260.1536577248880; Mon, 10 Sep 2018 04:00:48 -0700 (PDT) Received: from localhost.localdomain.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id k63-v6sm19045858wmd.46.2018.09.10.04.00.47 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Sep 2018 04:00:47 -0700 (PDT) From: Davide Caratti To: hostap@lists.infradead.org Subject: [PATCH] examples: fix shellcheck warnings in wps-ap-cli Date: Mon, 10 Sep 2018 13:00:36 +0200 Message-Id: <0267dd6c5b378fe67e3278aac9c63a6b094f6768.1536577183.git.davide.caratti@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180910_040101_553707_6D1943FF X-CRM114-Status: GOOD ( 11.72 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:429 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (davide.caratti[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org use 'printf' instead of 'echo -n', to suppress the following warning: In POSIX sh, echo flags are undefined. [SC2039] Signed-off-by: Davide Caratti --- wpa_supplicant/examples/wps-ap-cli | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/wpa_supplicant/examples/wps-ap-cli b/wpa_supplicant/examples/wps-ap-cli index cc2cff2eb..15d913ef1 100755 --- a/wpa_supplicant/examples/wps-ap-cli +++ b/wpa_supplicant/examples/wps-ap-cli @@ -14,12 +14,12 @@ pbc() enter_pin() { echo "Enter a PIN from a station to be enrolled to the network." - echo -n "Enrollee PIN: " + printf "Enrollee PIN: " read pin cpin=`$CLI wps_check_pin "$pin" | tail -1` if [ "$cpin" = "FAIL-CHECKSUM" ]; then echo "Checksum digit is not valid" - echo -n "Do you want to use this PIN (y/n)? " + printf "Do you want to use this PIN (y/n)? " read resp case "$resp" in y*) @@ -52,7 +52,7 @@ main_menu() echo "3: Show current configuration" echo "0: Exit wps-ap-cli" - echo -n "Command: " + printf "Command: " read cmd case "$cmd" in