| Message ID | 1536573140-24123-3-git-send-email-yoshihiro.shimoda.uh@renesas.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | usb: renesas_usbhs: add reset_control and multiple clocks management | expand |
On Mon, Sep 10, 2018 at 06:52:19PM +0900, Yoshihiro Shimoda wrote: > R-Car Gen3 needs to enable clocks of both host and peripheral. > Otherwise, other side device cannot work correctly. So, this patch > adds a property of clock-names for R-Car Gen3 as an optional. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index 087140a..dbdb92c 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > @@ -26,7 +26,9 @@ Required properties: > > - reg: Base address and length of the register for the USBHS > - interrupts: Interrupt specifier for the USBHS > - - clocks: A list of phandle + clock specifier pairs > + - clocks: A list of phandle + clock specifier pairs. In case of > + "renesas,rcar-gen3-usbhs" compatible device, first clock should be > + peripheral and second one should be host. This should have said how many clocks. That's still not clear except for "renesas,rcar-gen3-usbhs". Rob
Hi Rob, > From: Rob Herring, Sent: Tuesday, September 11, 2018 3:27 AM > > On Mon, Sep 10, 2018 at 06:52:19PM +0900, Yoshihiro Shimoda wrote: > > R-Car Gen3 needs to enable clocks of both host and peripheral. > > Otherwise, other side device cannot work correctly. So, this patch > > adds a property of clock-names for R-Car Gen3 as an optional. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > > index 087140a..dbdb92c 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > > @@ -26,7 +26,9 @@ Required properties: > > > > - reg: Base address and length of the register for the USBHS > > - interrupts: Interrupt specifier for the USBHS > > - - clocks: A list of phandle + clock specifier pairs > > + - clocks: A list of phandle + clock specifier pairs. In case of > > + "renesas,rcar-gen3-usbhs" compatible device, first clock should be > > + peripheral and second one should be host. > > This should have said how many clocks. That's still not clear except for > "renesas,rcar-gen3-usbhs". Thank you for your comments! I'll revise it. Best regards, Yoshihiro Shimoda > Rob
diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index 087140a..dbdb92c 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -26,7 +26,9 @@ Required properties: - reg: Base address and length of the register for the USBHS - interrupts: Interrupt specifier for the USBHS - - clocks: A list of phandle + clock specifier pairs + - clocks: A list of phandle + clock specifier pairs. In case of + "renesas,rcar-gen3-usbhs" compatible device, first clock should be + peripheral and second one should be host. Optional properties: - renesas,buswait: Integer to use BUSWAIT register
R-Car Gen3 needs to enable clocks of both host and peripheral. Otherwise, other side device cannot work correctly. So, this patch adds a property of clock-names for R-Car Gen3 as an optional. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)