| Message ID | 20180908175903.4561-1-asafka7@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] libminiupnpc: fix hash for license file | expand |
Hello, On Sat, 8 Sep 2018 20:59:03 +0300, Asaf Kahlon wrote: > Fixes: > http://autobuild.buildroot.org/results/51d/51dde9a1a7f60899a1befa24af379d204acb0d22/ > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> What are the changes between the previous and new license files ? Thanks, Thomas
They just replaced the year 2015 with 2016... On Sat, Sep 8, 2018 at 10:36 PM Thomas Petazzoni < thomas.petazzoni@bootlin.com> wrote: > Hello, > > On Sat, 8 Sep 2018 20:59:03 +0300, Asaf Kahlon wrote: > > Fixes: > > > http://autobuild.buildroot.org/results/51d/51dde9a1a7f60899a1befa24af379d204acb0d22/ > > > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > > What are the changes between the previous and new license files ? > > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > <div dir="ltr">They just replaced the year 2015 with 2016...</div><br><div class="gmail_quote"><div dir="ltr">On Sat, Sep 8, 2018 at 10:36 PM Thomas Petazzoni <<a href="mailto:thomas.petazzoni@bootlin.com">thomas.petazzoni@bootlin.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br> <br> On Sat, 8 Sep 2018 20:59:03 +0300, Asaf Kahlon wrote:<br> > Fixes:<br> > <a href="http://autobuild.buildroot.org/results/51d/51dde9a1a7f60899a1befa24af379d204acb0d22/" rel="noreferrer" target="_blank">http://autobuild.buildroot.org/results/51d/51dde9a1a7f60899a1befa24af379d204acb0d22/</a><br> > <br> > Signed-off-by: Asaf Kahlon <<a href="mailto:asafka7@gmail.com" target="_blank">asafka7@gmail.com</a>><br> <br> What are the changes between the previous and new license files ?<br> <br> Thanks,<br> <br> Thomas<br> -- <br> Thomas Petazzoni, CTO, Bootlin<br> Embedded Linux and Kernel engineering<br> <a href="https://bootlin.com" rel="noreferrer" target="_blank">https://bootlin.com</a><br> </blockquote></div>
Hello,
On Sat, 8 Sep 2018 22:43:12 +0300, Asaf Kahlon wrote:
> They just replaced the year 2015 with 2016...
This should be mentioned in the commit log, so that we know that
someone has verified what the changes were. That's the whole point of
having hashes for license files: detecting when the license file
contents are changed. So if we just blindly update the hash, it
completely defeats the purpose of having those hashes.
Thanks,
Thomas
diff --git a/package/libminiupnpc/libminiupnpc.hash b/package/libminiupnpc/libminiupnpc.hash index b35e7f045d..556d8cc45a 100644 --- a/package/libminiupnpc/libminiupnpc.hash +++ b/package/libminiupnpc/libminiupnpc.hash @@ -1,3 +1,3 @@ # Locally computed sha256 e19fb5e01ea5a707e2a8cb96f537fbd9f3a913d53d804a3265e3aeab3d2064c6 miniupnpc-2.1.tar.gz -sha256 4025f2214fa46ad40c156605b83d66e8faf45823e67eb3337af3869716e6d7dd LICENSE +sha256 e2df21b3d4b1a84a0ac31d808a3ff330fdf3602e0839a526d3df2fcfba287ac4 LICENSE
Fixes: http://autobuild.buildroot.org/results/51d/51dde9a1a7f60899a1befa24af379d204acb0d22/ Signed-off-by: Asaf Kahlon <asafka7@gmail.com> --- package/libminiupnpc/libminiupnpc.hash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)