| Message ID | 20180907173918.1169-1-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] vswitch.xml: Better explain vlan-limit. | expand |
On Fri, Sep 07, 2018 at 10:39:18AM -0700, Ben Pfaff wrote: > CC: Eric Garver <e@erig.me> > Requested-by: Jerry Lilijun <jerry.lilijun@huawei.com> > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > vswitchd/vswitch.xml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > index e318151f0ce9..f05f616feed6 100644 > --- a/vswitchd/vswitch.xml > +++ b/vswitchd/vswitch.xml > @@ -493,11 +493,11 @@ > e.g. a packet with more 802.1q headers will match Ethernet type > 0x8100. > </p> > + > <p> > - Value <code>0</code> means unlimited. The actual number of supported > - VLAN headers is the smallest of <code>vlan-limit</code>, the number > - of VLANs supported by Open vSwitch userspace (currently 2), and the > - number supported by the datapath. > + Open vSwitch userspace currently supports at most 2 VLANs, and each > + datapath has its own limit. If <code>vlan-limit</code> is nonzero, > + it acts as a further limit. > </p> > > <p> > -- > 2.16.1 I think the simpler explanation helps. Thanks Ben! Acked-by: Eric Garver <e@erig.me>
On Fri, Sep 07, 2018 at 01:49:03PM -0400, Eric Garver wrote: > On Fri, Sep 07, 2018 at 10:39:18AM -0700, Ben Pfaff wrote: > > CC: Eric Garver <e@erig.me> > > Requested-by: Jerry Lilijun <jerry.lilijun@huawei.com> > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > vswitchd/vswitch.xml | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > > index e318151f0ce9..f05f616feed6 100644 > > --- a/vswitchd/vswitch.xml > > +++ b/vswitchd/vswitch.xml > > @@ -493,11 +493,11 @@ > > e.g. a packet with more 802.1q headers will match Ethernet type > > 0x8100. > > </p> > > + > > <p> > > - Value <code>0</code> means unlimited. The actual number of supported > > - VLAN headers is the smallest of <code>vlan-limit</code>, the number > > - of VLANs supported by Open vSwitch userspace (currently 2), and the > > - number supported by the datapath. > > + Open vSwitch userspace currently supports at most 2 VLANs, and each > > + datapath has its own limit. If <code>vlan-limit</code> is nonzero, > > + it acts as a further limit. > > </p> > > > > <p> > > -- > > 2.16.1 > > I think the simpler explanation helps. Thanks Ben! > > Acked-by: Eric Garver <e@erig.me> Thanks, applied to master.
That’s more clear to me. thanks. 发件人： Ben Pfaff 收件人： Eric Garver<eric@garver.life<mailto:eric@garver.life>>;dev<dev@openvswitch.org<mailto:dev@openvswitch.org>>;Lilijun (Jerry, Cloud Networking)<jerry.lilijun@huawei.com<mailto:jerry.lilijun@huawei.com>> 主题： Re: [PATCH] vswitch.xml: Better explain vlan-limit. 时间： 2018-09-08 01:59:34 On Fri, Sep 07, 2018 at 01:49:03PM -0400, Eric Garver wrote: > On Fri, Sep 07, 2018 at 10:39:18AM -0700, Ben Pfaff wrote: > > CC: Eric Garver <e@erig.me> > > Requested-by: Jerry Lilijun <jerry.lilijun@huawei.com> > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > vswitchd/vswitch.xml | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > > index e318151f0ce9..f05f616feed6 100644 > > --- a/vswitchd/vswitch.xml > > +++ b/vswitchd/vswitch.xml > > @@ -493,11 +493,11 @@ > > e.g. a packet with more 802.1q headers will match Ethernet type > > 0x8100. > > </p> > > + > > <p> > > - Value <code>0</code> means unlimited. The actual number of supported > > - VLAN headers is the smallest of <code>vlan-limit</code>, the number > > - of VLANs supported by Open vSwitch userspace (currently 2), and the > > - number supported by the datapath. > > + Open vSwitch userspace currently supports at most 2 VLANs, and each > > + datapath has its own limit. If <code>vlan-limit</code> is nonzero, > > + it acts as a further limit. > > </p> > > > > <p> > > -- > > 2.16.1 > > I think the simpler explanation helps. Thanks Ben! > > Acked-by: Eric Garver <e@erig.me> Thanks, applied to master.
Yes, That's OK, thanks. -----Original Message----- From: Ben Pfaff [mailto:blp@ovn.org] Sent: Saturday, September 08, 2018 1:59 AM To: Eric Garver <eric@garver.life>; dev@openvswitch.org; Lilijun (Jerry, Cloud Networking) <jerry.lilijun@huawei.com> Subject: Re: [PATCH] vswitch.xml: Better explain vlan-limit. On Fri, Sep 07, 2018 at 01:49:03PM -0400, Eric Garver wrote: > On Fri, Sep 07, 2018 at 10:39:18AM -0700, Ben Pfaff wrote: > > CC: Eric Garver <e@erig.me> > > Requested-by: Jerry Lilijun <jerry.lilijun@huawei.com> > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > vswitchd/vswitch.xml | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index > > e318151f0ce9..f05f616feed6 100644 > > --- a/vswitchd/vswitch.xml > > +++ b/vswitchd/vswitch.xml > > @@ -493,11 +493,11 @@ > > e.g. a packet with more 802.1q headers will match Ethernet type > > 0x8100. > > </p> > > + > > <p> > > - Value <code>0</code> means unlimited. The actual number of supported > > - VLAN headers is the smallest of <code>vlan-limit</code>, the number > > - of VLANs supported by Open vSwitch userspace (currently 2), and the > > - number supported by the datapath. > > + Open vSwitch userspace currently supports at most 2 VLANs, and each > > + datapath has its own limit. If <code>vlan-limit</code> is nonzero, > > + it acts as a further limit. > > </p> > > > > <p> > > -- > > 2.16.1 > > I think the simpler explanation helps. Thanks Ben! > > Acked-by: Eric Garver <e@erig.me> Thanks, applied to master.
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index e318151f0ce9..f05f616feed6 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -493,11 +493,11 @@ e.g. a packet with more 802.1q headers will match Ethernet type 0x8100. </p> + <p> - Value <code>0</code> means unlimited. The actual number of supported - VLAN headers is the smallest of <code>vlan-limit</code>, the number - of VLANs supported by Open vSwitch userspace (currently 2), and the - number supported by the datapath. + Open vSwitch userspace currently supports at most 2 VLANs, and each + datapath has its own limit. If <code>vlan-limit</code> is nonzero, + it acts as a further limit. </p> <p>
CC: Eric Garver <e@erig.me> Requested-by: Jerry Lilijun <jerry.lilijun@huawei.com> Signed-off-by: Ben Pfaff <blp@ovn.org> --- vswitchd/vswitch.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)