Message ID | 20180907075948.26917-12-marcandre.lureau@redhat.com |
---|---|
State | New |
Headers | show |
Series | Various qemu command line options help improvements | expand |
On 07/09/2018 09:59, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > backends/hostmem-memfd.c | 9 +++++++++ > backends/hostmem.c | 14 ++++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c > index 1e20fe0ba8..789c8c3f87 100644 > --- a/backends/hostmem-memfd.c > +++ b/backends/hostmem-memfd.c > @@ -144,14 +144,23 @@ memfd_backend_class_init(ObjectClass *oc, void *data) > memfd_backend_get_hugetlb, > memfd_backend_set_hugetlb, > &error_abort); > + object_class_property_set_description(oc, "hugetlb", > + "Use huge pages", > + &error_abort); > object_class_property_add(oc, "hugetlbsize", "int", > memfd_backend_get_hugetlbsize, > memfd_backend_set_hugetlbsize, > NULL, NULL, &error_abort); > + object_class_property_set_description(oc, "hugetlbsize", > + "Huge pages size (ex: 2M, 1G)", > + &error_abort); > object_class_property_add_bool(oc, "seal", > memfd_backend_get_seal, > memfd_backend_set_seal, > &error_abort); > + object_class_property_set_description(oc, "seal", > + "Seal growing & shrinking", > + &error_abort); > } > > static const TypeInfo memfd_backend_info = { > diff --git a/backends/hostmem.c b/backends/hostmem.c > index 4908946cd3..1a89342039 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -397,27 +397,41 @@ host_memory_backend_class_init(ObjectClass *oc, void *data) > object_class_property_add_bool(oc, "merge", > host_memory_backend_get_merge, > host_memory_backend_set_merge, &error_abort); > + object_class_property_set_description(oc, "merge", > + "Mark memory as mergeable", &error_abort); > object_class_property_add_bool(oc, "dump", > host_memory_backend_get_dump, > host_memory_backend_set_dump, &error_abort); > + object_class_property_set_description(oc, "dump", > + "Set to 'off' to exclude from core dump", &error_abort); > object_class_property_add_bool(oc, "prealloc", > host_memory_backend_get_prealloc, > host_memory_backend_set_prealloc, &error_abort); > + object_class_property_set_description(oc, "prealloc", > + "Preallocate memory", &error_abort); > object_class_property_add(oc, "size", "int", > host_memory_backend_get_size, > host_memory_backend_set_size, > NULL, NULL, &error_abort); > + object_class_property_set_description(oc, "size", > + "Size of the memory region (ex: 500M)", &error_abort); > object_class_property_add(oc, "host-nodes", "int", > host_memory_backend_get_host_nodes, > host_memory_backend_set_host_nodes, > NULL, NULL, &error_abort); > + object_class_property_set_description(oc, "host-nodes", > + "Binds memory to the list of NUMA host nodes", &error_abort); > object_class_property_add_enum(oc, "policy", "HostMemPolicy", > &HostMemPolicy_lookup, > host_memory_backend_get_policy, > host_memory_backend_set_policy, &error_abort); > + object_class_property_set_description(oc, "policy", > + "Set the NUMA policy", &error_abort); > object_class_property_add_bool(oc, "share", > host_memory_backend_get_share, host_memory_backend_set_share, > &error_abort); > + object_class_property_set_description(oc, "share", > + "Mark the memory as private to QEMU or shared", &error_abort); > } > > static const TypeInfo host_memory_backend_info = { > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index 1e20fe0ba8..789c8c3f87 100644 --- a/backends/hostmem-memfd.c +++ b/backends/hostmem-memfd.c @@ -144,14 +144,23 @@ memfd_backend_class_init(ObjectClass *oc, void *data) memfd_backend_get_hugetlb, memfd_backend_set_hugetlb, &error_abort); + object_class_property_set_description(oc, "hugetlb", + "Use huge pages", + &error_abort); object_class_property_add(oc, "hugetlbsize", "int", memfd_backend_get_hugetlbsize, memfd_backend_set_hugetlbsize, NULL, NULL, &error_abort); + object_class_property_set_description(oc, "hugetlbsize", + "Huge pages size (ex: 2M, 1G)", + &error_abort); object_class_property_add_bool(oc, "seal", memfd_backend_get_seal, memfd_backend_set_seal, &error_abort); + object_class_property_set_description(oc, "seal", + "Seal growing & shrinking", + &error_abort); } static const TypeInfo memfd_backend_info = { diff --git a/backends/hostmem.c b/backends/hostmem.c index 4908946cd3..1a89342039 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -397,27 +397,41 @@ host_memory_backend_class_init(ObjectClass *oc, void *data) object_class_property_add_bool(oc, "merge", host_memory_backend_get_merge, host_memory_backend_set_merge, &error_abort); + object_class_property_set_description(oc, "merge", + "Mark memory as mergeable", &error_abort); object_class_property_add_bool(oc, "dump", host_memory_backend_get_dump, host_memory_backend_set_dump, &error_abort); + object_class_property_set_description(oc, "dump", + "Set to 'off' to exclude from core dump", &error_abort); object_class_property_add_bool(oc, "prealloc", host_memory_backend_get_prealloc, host_memory_backend_set_prealloc, &error_abort); + object_class_property_set_description(oc, "prealloc", + "Preallocate memory", &error_abort); object_class_property_add(oc, "size", "int", host_memory_backend_get_size, host_memory_backend_set_size, NULL, NULL, &error_abort); + object_class_property_set_description(oc, "size", + "Size of the memory region (ex: 500M)", &error_abort); object_class_property_add(oc, "host-nodes", "int", host_memory_backend_get_host_nodes, host_memory_backend_set_host_nodes, NULL, NULL, &error_abort); + object_class_property_set_description(oc, "host-nodes", + "Binds memory to the list of NUMA host nodes", &error_abort); object_class_property_add_enum(oc, "policy", "HostMemPolicy", &HostMemPolicy_lookup, host_memory_backend_get_policy, host_memory_backend_set_policy, &error_abort); + object_class_property_set_description(oc, "policy", + "Set the NUMA policy", &error_abort); object_class_property_add_bool(oc, "share", host_memory_backend_get_share, host_memory_backend_set_share, &error_abort); + object_class_property_set_description(oc, "share", + "Mark the memory as private to QEMU or shared", &error_abort); } static const TypeInfo host_memory_backend_info = {
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- backends/hostmem-memfd.c | 9 +++++++++ backends/hostmem.c | 14 ++++++++++++++ 2 files changed, 23 insertions(+)