[12/12] fwts-test: apicinstance: fix up incorrect hex values
diff mbox series

Message ID 20180906142001.28381-13-colin.king@canonical.com
State Accepted
Headers show
Series
  • Fix up print format specifiers
Related show

Commit Message

Colin Ian King Sept. 6, 2018, 2:20 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Recent commit "acpi: apicinstance: use correct format specifiers"
fixes the output format of hex value by printing the hex value and
not a decimal value. Fix up the regression tests to reflect this
fix.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fwts-test/apicinstance-0001/apicinstance-0001.log | 4 ++--
 fwts-test/apicinstance-0001/apicinstance-0002.log | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Alex Hung Sept. 6, 2018, 9:40 p.m. UTC | #1
On 2018-09-06 07:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Recent commit "acpi: apicinstance: use correct format specifiers"
> fixes the output format of hex value by printing the hex value and
> not a decimal value. Fix up the regression tests to reflect this
> fix.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   fwts-test/apicinstance-0001/apicinstance-0001.log | 4 ++--
>   fwts-test/apicinstance-0001/apicinstance-0002.log | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fwts-test/apicinstance-0001/apicinstance-0001.log b/fwts-test/apicinstance-0001/apicinstance-0001.log
> index bb8c28c2..ec278964 100644
> --- a/fwts-test/apicinstance-0001/apicinstance-0001.log
> +++ b/fwts-test/apicinstance-0001/apicinstance-0001.log
> @@ -1,8 +1,8 @@
>   apicinstance    apicinstance: Test for single instance of APIC/MADT table.
>   apicinstance    ----------------------------------------------------------
>   apicinstance    Test 1 of 1: Test for single instance of APIC/MADT table.
> -apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x104
> -apicinstance    Found APIC/MADT table APIC @ bf6dff70, length 0x104
> +apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x68
> +apicinstance    Found APIC/MADT table APIC @ bf6dff70, length 0x68
>   apicinstance     (and differs from first APIC/MADT table).
>   apicinstance    FAILED [HIGH] MultipleAPICMADT: Test 1, Found 2 APIC/MADT
>   apicinstance    tables, the kernel expects just one.
> diff --git a/fwts-test/apicinstance-0001/apicinstance-0002.log b/fwts-test/apicinstance-0001/apicinstance-0002.log
> index ff12adf7..5ce9c631 100644
> --- a/fwts-test/apicinstance-0001/apicinstance-0002.log
> +++ b/fwts-test/apicinstance-0001/apicinstance-0002.log
> @@ -1,7 +1,7 @@
>   apicinstance    apicinstance: Test for single instance of APIC/MADT table.
>   apicinstance    ----------------------------------------------------------
>   apicinstance    Test 1 of 1: Test for single instance of APIC/MADT table.
> -apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x104
> +apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x68
>   apicinstance    PASSED: Test 1, Found 1 APIC/MADT table(s), as expected.
>   apicinstance
>   apicinstance    ==========================================================
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Sept. 10, 2018, 4:30 a.m. UTC | #2
On 09/06/2018 10:20 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Recent commit "acpi: apicinstance: use correct format specifiers"
> fixes the output format of hex value by printing the hex value and
> not a decimal value. Fix up the regression tests to reflect this
> fix.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  fwts-test/apicinstance-0001/apicinstance-0001.log | 4 ++--
>  fwts-test/apicinstance-0001/apicinstance-0002.log | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fwts-test/apicinstance-0001/apicinstance-0001.log b/fwts-test/apicinstance-0001/apicinstance-0001.log
> index bb8c28c2..ec278964 100644
> --- a/fwts-test/apicinstance-0001/apicinstance-0001.log
> +++ b/fwts-test/apicinstance-0001/apicinstance-0001.log
> @@ -1,8 +1,8 @@
>  apicinstance    apicinstance: Test for single instance of APIC/MADT table.
>  apicinstance    ----------------------------------------------------------
>  apicinstance    Test 1 of 1: Test for single instance of APIC/MADT table.
> -apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x104
> -apicinstance    Found APIC/MADT table APIC @ bf6dff70, length 0x104
> +apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x68
> +apicinstance    Found APIC/MADT table APIC @ bf6dff70, length 0x68
>  apicinstance     (and differs from first APIC/MADT table).
>  apicinstance    FAILED [HIGH] MultipleAPICMADT: Test 1, Found 2 APIC/MADT
>  apicinstance    tables, the kernel expects just one.
> diff --git a/fwts-test/apicinstance-0001/apicinstance-0002.log b/fwts-test/apicinstance-0001/apicinstance-0002.log
> index ff12adf7..5ce9c631 100644
> --- a/fwts-test/apicinstance-0001/apicinstance-0002.log
> +++ b/fwts-test/apicinstance-0001/apicinstance-0002.log
> @@ -1,7 +1,7 @@
>  apicinstance    apicinstance: Test for single instance of APIC/MADT table.
>  apicinstance    ----------------------------------------------------------
>  apicinstance    Test 1 of 1: Test for single instance of APIC/MADT table.
> -apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x104
> +apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x68
>  apicinstance    PASSED: Test 1, Found 1 APIC/MADT table(s), as expected.
>  apicinstance    
>  apicinstance    ==========================================================
Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch
diff mbox series

diff --git a/fwts-test/apicinstance-0001/apicinstance-0001.log b/fwts-test/apicinstance-0001/apicinstance-0001.log
index bb8c28c2..ec278964 100644
--- a/fwts-test/apicinstance-0001/apicinstance-0001.log
+++ b/fwts-test/apicinstance-0001/apicinstance-0001.log
@@ -1,8 +1,8 @@ 
 apicinstance    apicinstance: Test for single instance of APIC/MADT table.
 apicinstance    ----------------------------------------------------------
 apicinstance    Test 1 of 1: Test for single instance of APIC/MADT table.
-apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x104
-apicinstance    Found APIC/MADT table APIC @ bf6dff70, length 0x104
+apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x68
+apicinstance    Found APIC/MADT table APIC @ bf6dff70, length 0x68
 apicinstance     (and differs from first APIC/MADT table).
 apicinstance    FAILED [HIGH] MultipleAPICMADT: Test 1, Found 2 APIC/MADT
 apicinstance    tables, the kernel expects just one.
diff --git a/fwts-test/apicinstance-0001/apicinstance-0002.log b/fwts-test/apicinstance-0001/apicinstance-0002.log
index ff12adf7..5ce9c631 100644
--- a/fwts-test/apicinstance-0001/apicinstance-0002.log
+++ b/fwts-test/apicinstance-0001/apicinstance-0002.log
@@ -1,7 +1,7 @@ 
 apicinstance    apicinstance: Test for single instance of APIC/MADT table.
 apicinstance    ----------------------------------------------------------
 apicinstance    Test 1 of 1: Test for single instance of APIC/MADT table.
-apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x104
+apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x68
 apicinstance    PASSED: Test 1, Found 1 APIC/MADT table(s), as expected.
 apicinstance    
 apicinstance    ==========================================================