Message ID | 20180906114041.21828-4-sbabic@denx.de |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBCXPLOXJ6IKRBQ5EYTOAKGQED476DAQ@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=googlegroups.com (client-ip=209.85.208.60; helo=mail-ed1-f60.google.com; envelope-from=swupdate+bncbcxploxj6ikrbq5eytoakgqed476daq@googlegroups.com; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b="XdrO1V2G"; dkim-atps=neutral Received: from mail-ed1-f60.google.com (mail-ed1-f60.google.com [209.85.208.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 425dtZ1c3Jz9sBn for <incoming@patchwork.ozlabs.org>; Thu, 6 Sep 2018 21:40:54 +1000 (AEST) Received: by mail-ed1-f60.google.com with SMTP id c16-v6sf3575105edc.21 for <incoming@patchwork.ozlabs.org>; Thu, 06 Sep 2018 04:40:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1536234051; cv=pass; d=google.com; s=arc-20160816; b=YT1JkLsLACvvk069kpR6vbt7a2cWGbrWXcCD4OcfE7ucxpj8pLoeXBiN0pV++E9qyy 2StKkMU/ZrprmwxhRIezX+eJwcZBZiozbwpI+ar+sf0oyL9I+pUPqnQxNJ4qgjQ1aMth VZI2yoEEYQSvobrC4+Fo+kJSkb9XY8BTz0t3sGFI6KAM155d8AbrJHm0iKRVKJ/t9qEr fS/8Ki+XPNrSPlaKJDIkA8Hg00oDx8Myb80B/4szIXFLVvW6tMSIheTWsL/SnLdUao1h 0Otc4wCdmkZTwu3HXsKRjDHfxt+/ussMtwo+ZsfqQhtYyW8tF/tkZJX6SLPl6z/06jGQ sJyw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:mime-version:sender:dkim-signature; bh=yY7msT4RbSTjkXWjXLuroKYTnAKNSExWW9WqpXxfgXA=; b=zt3pqCS/0ZJ7XN0kOxwKVTmRqGjc0syattynTyPgEsVgm5zJUzujmA1lQJj+SfqBUY 7ZCFLtAw8QXKlGZBUbuD73yp3yYjw7ZNIl9glpxWOoNzuuYFbuUUX5gcn8mZdSJ1vrrl SoigF2eIdtYXV9eI6s9x30kD7pTMmc2E6Jc6l7yHxU1pP9nNoOGGtHkVa9FrT6FkshmE 0bSG4zkJHhFmLqjoxXl7TmJsMpi9skubujALOytXaaoC93tpbzralZ83F5vWoC3O44Lg U9lhOXeiLuQz9BrZluym76tMGEQgXw7ALSOJchxHttiql6FItW08p+JtKyCGXxrq6ptw +zQA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=yY7msT4RbSTjkXWjXLuroKYTnAKNSExWW9WqpXxfgXA=; b=XdrO1V2GzBZJ9FrwuYyPkZOY83mI6RM7ixe5j/cFlYFLFICgk8SXFr236lzRw6NmuM 0ktsEaU3GpLz4k/K7qXNGcnXckcOlZJ2S/i6+z0zu74n6j47w41bBjTaQiROVgo9KPPU 2EkYfgqx3nH8ErMmC4Oqv176vXHF6pcG281WwVPCKcI/1PKgFUeFKG9Xz7Jbwm/f9SJ0 znye7Omf1q3oEQlGN7cFfteRjoLoHko10NUYlsUW3uuPehEKKB7/QzQObr8WgNd5euKO +wWQJ7PHuwIncLkZLV/MJbtqNI6fUtHmbKTjRheeLAgQLhE+koHDvS/33ce4gY6PlSPU 8EzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:mime-version:from:to:cc:subject:date :message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=yY7msT4RbSTjkXWjXLuroKYTnAKNSExWW9WqpXxfgXA=; b=Powj1q3LKNeWZUzTLo9XDSdrUnkFdtlZPk734bXclCHYkl29+wfOQpmVO80e2RyIYT dUn2Onb2QtqzNif1MAvdJI2DclR1rO5ovzp2a2yrZ9FAw4Nqa5//sA5ihsdOhO2L8rdV F1ezejP0suthQ4/RKbeo5c8kK4YreCrJijamtKCm5QKbvaLG6ijTg+bL8GpYi9sejKb1 NOZcFWC8ntryPFo/O7XHgvbLiIbtHNHN3QjqOeSYQaz2Eqem5cVvWbmKzOevHYZyx0gn Nf4QxZyD1f+nyH7xnC+LavmznsUIMmbSSVrl5p4/L5z0+oHWvsLQTTX8PgwFRDY08UfC 9cLg== Sender: swupdate@googlegroups.com X-Gm-Message-State: APzg51AEPrZ93T73EICJdcn/MOf+2BQtdHLBVZt+QKWmsgMIC+YrVJri x1zoX5e2RxqRzIkEYonV2tE= X-Google-Smtp-Source: ANB0VdaiRwQAV5oMGaEF1bv4ONIvcZ6ZqRjFeFMiguLgf49zfcj42uGHEzkjzG6u4w7GxluWYDQ+0A== X-Received: by 2002:a50:e807:: with SMTP id e7-v6mr17141edn.7.1536234051629; Thu, 06 Sep 2018 04:40:51 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: swupdate@googlegroups.com Received: by 2002:a50:d716:: with SMTP id t22-v6ls2349966edi.4.gmail; Thu, 06 Sep 2018 04:40:51 -0700 (PDT) X-Received: by 2002:aa7:c415:: with SMTP id j21-v6mr651553edq.3.1536234051067; Thu, 06 Sep 2018 04:40:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536234051; cv=none; d=google.com; s=arc-20160816; b=vqHiRdgnCBCNqDKWH6RfSSMTLwf/BDdaIWsWxi7pFCsjQBem0uOm5bmOjmZlP0ZkhZ +JRNkmkDc3jqc4IVAs5uMCJciXt1JAcNTsJTYHZ9k+4HCqIaWSYclFmpVvHg44KK5saV 5nqPCQ9Yw7AKjJU23Ma11znvgRIq95dQA25gF4TR2Ct6RGma3VgSBbzm1+QenpMUE1tz Urc74OmwQ3UYicoKfHDU3X6RrBVVv4PLGDcnJ0Y0KZ5n2nbHhJdmoUF8h7BMxP6pCDie 4CbLUxhIVmGaJgUMZJN3lGLqQF8a6bBl5yXcw4LlOdl3HiwGygNrsHxgjkSIX3kncON6 7x0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=mhIaylCuMzLK4h9IpovABRYqDCRN9NnHAtJi55bxdM0=; b=UzLcz7LLf5zCoWTNnK5UlCqn4ya20DZE4QSPn8+fgCukj6/owFeYre8ja8EEeRhEgx /NUM5BlkiOGmSlG5iHpviKEDZwby3Vsq4VsuvoY0cf45G/8eeU3vsbAwym9K1Pzzd6v4 CHNHXEYyyvgAYHyGtY8HGXmoHfdcl0ZFiapA8vt3IWJPJgxE19cQ8jveGh728JqcZnee 6s8xA2j2eB5Tsuhu/gyzN4CV8S//AY3BGnod9xbIVfbX2mFBNsfWV7pJCYiHzEmtPdWo uwsDf7j7hFHsZMudQd40WiUr7cIx5wq4IaHE1dQF0pQELvkq9VGTv/BvGPZ4xsJjKav4 tKhA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id y4-v6si188420edh.4.2018.09.06.04.40.51 for <swupdate@googlegroups.com> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Sep 2018 04:40:51 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=212.18.0.9; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 425dtV5t92z1qvfq; Thu, 6 Sep 2018 13:40:50 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 425dtV5nMrz1qrVq; Thu, 6 Sep 2018 13:40:50 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 0LAIpGivdIdj; Thu, 6 Sep 2018 13:40:50 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Thu, 6 Sep 2018 13:40:50 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id B6DC1454035B; Thu, 6 Sep 2018 13:40:49 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([127.0.0.1]) by localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f5xR_75BR49T; Thu, 6 Sep 2018 13:40:47 +0200 (CEST) Received: from papero.fritz.box (papero.fritz.box [192.168.178.132]) by babic.homelinux.org (Postfix) with ESMTP id D2C9045404FF; Thu, 6 Sep 2018 13:40:43 +0200 (CEST) From: Stefano Babic <sbabic@denx.de> To: swupdate@googlegroups.com Cc: Stefano Babic <sbabic@denx.de> Subject: [swupdate] [PATCH 4/9] CONFIG_SURICATTA_STATE_CHOICE_BOOTLOADER not checked for state Date: Thu, 6 Sep 2018 13:40:36 +0200 Message-Id: <20180906114041.21828-4-sbabic@denx.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180906114041.21828-1-sbabic@denx.de> References: <20180906114041.21828-1-sbabic@denx.de> X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
[1/9] Use provided macro for exit()
|
expand
|
diff --git a/suricatta/state.c b/suricatta/state.c index 935475b..36897b8 100644 --- a/suricatta/state.c +++ b/suricatta/state.c @@ -34,36 +34,6 @@ bool is_state_valid(update_state_t state) { return true; } -#ifndef CONFIG_SURICATTA_STATE_CHOICE_BOOTLOADER -/* - * This is just if the state is not stored persistently, that is - * it does not survive after a reboot. - * Save it in a variable and use setter / getter to retrieve it - */ -static int suricatta_state = STATE_NOT_AVAILABLE; -server_op_res_t save_state(char *key, update_state_t value) -{ - (void)key; - suricatta_state = value; - return SERVER_OK; -} - -server_op_res_t read_state(char *key, update_state_t *value) -{ - (void)key; - - *value = suricatta_state; - return SERVER_OK; -} - -server_op_res_t reset_state(char *key) -{ - (void)key; - suricatta_state = STATE_NOT_AVAILABLE; - return SERVER_OK; -} -#else - server_op_res_t save_state(char *key, update_state_t value) { int ret; @@ -104,4 +74,3 @@ server_op_res_t reset_state(char *key) ret = bootloader_env_unset(key); return ret == 0 ? SERVER_OK : SERVER_EERR; } -#endif
state changes are written via the bootloader interface. Because this was done more general as in the past, it is not required a special handle if U-Boot is not chosen. Dropping CONFIG_SURICATTA_STATE_CHOICE_BOOTLOADER corresponds to select CONFIG_BOOTLOADER_NONE in the bootloader menu. Signed-off-by: Stefano Babic <sbabic@denx.de> --- suricatta/state.c | 31 ------------------------------- 1 file changed, 31 deletions(-)