| Message ID | 20180906030235.8186-1-dwesterg@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | Simon Goldschmidt |
| Headers | show |
| Series | [U-Boot,v2,1/2] spl: socfpga: only gen5 devices and arria10 require sfp image | expand |
On 09/06/2018 05:02 AM, Dalon Westergreen wrote: > Only the Cyclone5/Arria5 and Arria10 devices require the sfp > formated image for booting. This path ensures that the file is > only generated for those devices. > > Signed-off-by: Dalon Westergreen <dwesterg@gmail.com> > --- > scripts/Makefile.spl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl > index 252f13826d..76d08fd92b 100644 > --- a/scripts/Makefile.spl > +++ b/scripts/Makefile.spl > @@ -188,7 +188,8 @@ ALL-y += $(obj)/$(BOARD)-spl.bin > endif > > ifdef CONFIG_ARCH_SOCFPGA > -ALL-y += $(obj)/$(SPL_BIN).sfp > +ALL-$(CONFIG_TARGET_SOCFPGA_GEN5) += $(obj)/$(SPL_BIN).sfp > +ALL-$(CONFIG_TARGET_SOCFPGA_ARRIA10) += $(obj)/$(SPL_BIN).sfp > endif > > ifdef CONFIG_ARCH_SUNXI > What about adding Kconfig option , something like CONFIG_TARGET_SOCFPGA_SFP , using it above and enabling it on Gen5 and A10 ? That way ,we won't have two entries with the same content.
On Thu, 2018-09-06 at 12:08 +0200, Marek Vasut wrote: > On 09/06/2018 05:02 AM, Dalon Westergreen wrote: > > Only the Cyclone5/Arria5 and Arria10 devices require the sfp > formated image for booting. This path ensures that the file is > only generated for those devices. > > Signed-off-by: Dalon Westergreen <dwesterg@gmail.com> > --- > scripts/Makefile.spl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl > index 252f13826d..76d08fd92b 100644 > --- a/scripts/Makefile.spl > +++ b/scripts/Makefile.spl > @@ -188,7 +188,8 @@ ALL-y += $(obj)/$(BOARD)-spl.bin > endif > > ifdef CONFIG_ARCH_SOCFPGA > -ALL-y += $(obj)/$(SPL_BIN).sfp > +ALL-$(CONFIG_TARGET_SOCFPGA_GEN5) += $(obj)/$(SPL_BIN).sfp > +ALL-$(CONFIG_TARGET_SOCFPGA_ARRIA10) += $(obj)/$(SPL_BIN).sfp > endif > > ifdef CONFIG_ARCH_SUNXI > > What about adding Kconfig option , something like > CONFIG_TARGET_SOCFPGA_SFP , using it above and enabling it on Gen5 and > A10 ? That way ,we won't have two entries with the same content. > Good idea.
diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 252f13826d..76d08fd92b 100644 --- a/scripts/Makefile.spl +++ b/scripts/Makefile.spl @@ -188,7 +188,8 @@ ALL-y += $(obj)/$(BOARD)-spl.bin endif ifdef CONFIG_ARCH_SOCFPGA -ALL-y += $(obj)/$(SPL_BIN).sfp +ALL-$(CONFIG_TARGET_SOCFPGA_GEN5) += $(obj)/$(SPL_BIN).sfp +ALL-$(CONFIG_TARGET_SOCFPGA_ARRIA10) += $(obj)/$(SPL_BIN).sfp endif ifdef CONFIG_ARCH_SUNXI
Only the Cyclone5/Arria5 and Arria10 devices require the sfp formated image for booting. This path ensures that the file is only generated for those devices. Signed-off-by: Dalon Westergreen <dwesterg@gmail.com> --- scripts/Makefile.spl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)